Delete/backspace ranges of text

This commit is contained in:
Isaiah Odhner 2023-04-26 17:49:12 -04:00
parent 06836d77bb
commit 1c9fb0ca1b
2 changed files with 42 additions and 6 deletions

View File

@ -126,7 +126,7 @@ cat file.ans
## Known Issues
- The Text tool doesn't collapse a text selection when typing, or allow deleting a range.
- The Text tool doesn't collapse a text selection when typing. Undo/Redo doesn't work with text. Ctrl+Z will delete the textbox.
- Selection box border is inside instead of outside (and lacks dashes). For the text box, I hid the border because it was too visually confusing, but it should also have an outer border.
- Pick Color can't be cancelled, since it samples the color continuously.
- Pressing both mouse buttons to cancel tools can sometimes result the the tool restarting, or it's just my mouse. It's probably my mouse, now that I think about it. But also, it should actually undo current action, not just end it.

View File

@ -7,7 +7,7 @@ import argparse
import asyncio
from enum import Enum
from random import randint, random
from typing import Any, List, Optional, Callable, Iterator, Tuple
from typing import Any, Generator, List, Optional, Callable, Iterator, Tuple
from watchdog.events import PatternMatchingEventHandler, FileSystemEvent, EVENT_TYPE_CLOSED, EVENT_TYPE_OPENED
from watchdog.observers import Observer
import stransi
@ -2752,6 +2752,34 @@ class PaintApp(App[None]):
textbox = self.image.selection
assert textbox.contained_image is not None, "Textbox mode should always have contained_image, to edit as text."
def offset_to_text_index(offset: Offset) -> int:
"""Converts an offset in the textbox to an index in the text."""
return offset.y * textbox.region.width + offset.x
def text_index_to_offset(index: int) -> Offset:
"""Converts an index in the text to an offset in the textbox."""
return Offset(index % textbox.region.width, index // textbox.region.width)
def selected_text_range() -> Generator[Offset, None, None]:
"""Yields all offsets within the text selection."""
start = offset_to_text_index(textbox.text_selection_start)
end = offset_to_text_index(textbox.text_selection_end)
for i in range(min(start, end), max(start, end) + 1):
yield text_index_to_offset(i)
def delete_selected_text() -> None:
"""Deletes the selected text, if any."""
assert textbox.contained_image is not None, "Textbox mode should always have contained_image, to edit as text." # Come on, Pyright.
# Delete the selected text.
for offset in selected_text_range():
textbox.contained_image.ch[offset.y][offset.x] = " "
textbox.textbox_edited = True
# Move the cursor to the start of the selection.
textbox.text_selection_end = textbox.text_selection_start = min(
textbox.text_selection_start,
textbox.text_selection_end,
)
# TODO: delete selected text if any, when typing
# Note: Don't forget to set textbox.textbox_edited = True
@ -2780,12 +2808,20 @@ class PaintApp(App[None]):
elif key == "down":
y = min(textbox.contained_image.height - 1, y + 1)
elif key == "backspace":
if textbox.text_selection_end == textbox.text_selection_start:
x = max(0, x - 1)
textbox.contained_image.ch[y][x] = " "
else:
delete_selected_text()
x, y = textbox.text_selection_end
textbox.textbox_edited = True
elif key == "delete":
if textbox.text_selection_end == textbox.text_selection_start:
textbox.contained_image.ch[y][x] = " "
x = min(textbox.contained_image.width - 1, x + 1)
else:
delete_selected_text()
x, y = textbox.text_selection_end
textbox.textbox_edited = True
elif key == "home":
x = 0