1j01/textual-paint
1
1
Fork 0
mirror of https://github.com/1j01/textual-paint.git synced 2024-12-21 22:01:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

Further clarify comment about selection cutout vs melding regions

Browse Source
This commit is contained in:
Isaiah Odhner 2023-04-25 17:35:44 -04:00
parent 5141044ef0
commit 66f4b77ff3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
paint.py
View File

@ -2102,8 +2102,10 @@ class PaintApp(App[None]):
self.erase_region(sel.region, sel.mask)
# TODO: Optimize the region storage. Right now I'm copying the whole image,
# because later when the selection is melded into the canvas, it currently
# falls under the same singular undo action.
# for the case of selection, because later, when the selection is melded into the canvas,
# it _implicitly updates_ the undo action, by changing the document without creating a new Action.
# This is the intended behavior, in that it allows the user to undo the
# selection and any changes to it as one action. But it's not efficient for large images.
# I could:
# - Update the region when melding to be the union of the two rectangles.
# - Make Action support a list of regions, and add the new region on meld.