1j01/textual-paint
1
1
Fork 0
mirror of https://github.com/1j01/textual-paint.git synced 2024-12-22 06:11:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: don't store reference to the live document in Action

Browse Source 
It feels in danger of accidental usage there, or preventing GC.
This commit is contained in:
Isaiah Odhner 2023-04-11 21:45:00 -04:00
parent 30cddbbde5
commit 67d256883d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
paint.py
View File

@ -313,7 +313,6 @@ class Action:
if region is None: if region is None:
region = Region(0, 0, document.width, document.height) region = Region(0, 0, document.width, document.height)
self.name = name self.name = name
self.live_document = document # only for undoing; TODO: move to parameter of undo()
self.region = region self.region = region
self.update(document) self.update(document)
@ -322,9 +321,9 @@ class Action:
self.sub_image_before = AnsiArtDocument(self.region.width, self.region.height) self.sub_image_before = AnsiArtDocument(self.region.width, self.region.height)
self.sub_image_before.copy_region(document, self.region) self.sub_image_before.copy_region(document, self.region)
def undo(self) -> None: def undo(self, target_document: AnsiArtDocument) -> None:
"""Undo this action. Note that a canvas refresh is not performed here.""" """Undo this action. Note that a canvas refresh is not performed here."""
self.live_document.copy_region(self.sub_image_before, target_region=self.region) target_document.copy_region(self.sub_image_before, target_region=self.region)
def bresenham_walk(x0: int, y0: int, x1: int, y1: int) -> None: def bresenham_walk(x0: int, y0: int, x1: int, y1: int) -> None:
"""Bresenham's line algorithm""" """Bresenham's line algorithm"""
@ -484,7 +483,7 @@ class PaintApp(App):
if len(self.undos) > 0: if len(self.undos) > 0:
action = self.undos.pop() action = self.undos.pop()
redo_action = Action("Undo " + action.name, self.image, action.region) redo_action = Action("Undo " + action.name, self.image, action.region)
action.undo() action.undo(self.image)
self.redos.append(redo_action) self.redos.append(redo_action)
self.canvas.refresh() self.canvas.refresh()
@ -492,7 +491,7 @@ class PaintApp(App):
if len(self.redos) > 0: if len(self.redos) > 0:
action = self.redos.pop() action = self.redos.pop()
undo_action = Action("Undo " + action.name, self.image, action.region) undo_action = Action("Undo " + action.name, self.image, action.region)
action.undo() action.undo(self.image)
self.undos.append(undo_action) self.undos.append(undo_action)
self.canvas.refresh() self.canvas.refresh()