1j01/textual-paint
1
1
Fork 0
mirror of https://github.com/1j01/textual-paint.git synced 2024-12-23 14:51:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only look upwards for handlers if the event bubbles

Browse Source
This commit is contained in:
Isaiah Odhner 2023-06-04 15:34:05 -04:00
parent 38dcdde2b9
commit cfe4104b6f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/textual_paint/inspector.py
View File

@ -609,9 +609,10 @@ class NodeInfo(Container):
handler_name = message_class.handler_name handler_name = message_class.handler_name
handler_names = [handler_name, f"_{handler_name}"] handler_names = [handler_name, f"_{handler_name}"]
# Find any listeners for this event # Find any listeners for this event
# TODO: only look upwards if the event bubbles # Only look upwards if the event bubbles
potential_handlers = dom_node.ancestors_with_self if message_class.bubble else [dom_node]
usages: list[Text] = [] usages: list[Text] = []
for ancestor in dom_node.ancestors_with_self: for ancestor in potential_handlers:
for handler_name in handler_names: for handler_name in handler_names:
if hasattr(ancestor, handler_name): if hasattr(ancestor, handler_name):
# Record which class the handler is defined on # Record which class the handler is defined on