Commit Graph

24 Commits

Author SHA1 Message Date
Isaiah Odhner
5426ed14a3 Use semantic key synonym 2023-09-11 18:02:20 -04:00
Isaiah Odhner
2b447a06d6 WIP: Polygon and Text tool tests 2023-09-11 18:02:20 -04:00
Isaiah Odhner
86a403eb80 WIP: test polygon tool prematurely closing polygon 2023-09-11 17:56:03 -04:00
Isaiah Odhner
1ae3cbe37b WIP: test polygon tool 2023-09-11 17:56:02 -04:00
Isaiah Odhner
9f12ba7833 Guard against future usage of unique class at runtime 2023-09-08 23:49:52 -04:00
Isaiah Odhner
cc6b0d65c0 Unify import style 2023-09-08 23:47:09 -04:00
Isaiah Odhner
d2300c96a3 Annotate tests with type hints 2023-09-08 23:38:37 -04:00
Isaiah Odhner
ad9ff303f1 Update fixture docstring 2023-09-08 22:53:58 -04:00
Isaiah Odhner
3cc70b6e4d Test About Paint dialog 2023-09-08 22:46:52 -04:00
Isaiah Odhner
ea5ca0c90f Fix flaky test due to pressed style of Show Details button 2023-09-08 22:40:49 -04:00
Isaiah Odhner
c5353f4e7b Test custom zoom dialog 2023-09-08 22:32:53 -04:00
Isaiah Odhner
628170d213 Test error dialog
It's pretty ridiculous in the expanded state, but better to show it.
Also, the button text isn't switching to "Hide Details".
2023-09-08 22:32:53 -04:00
Isaiah Odhner
faa9cefe85 Test expand canvas dialog 2023-09-08 21:40:29 -04:00
Isaiah Odhner
1b9cfe51b3 Fix dark mode tests failing to open dialogs
This was kind of mind-boggling, narrowing it down to dark mode,
and then to dark mode *but not CSS*.
I kept narrowing it down, and looked into how dark mode was implemented,
and finally figured this out.
`app.call_later(app.refresh_css)` in `App.watch_dark` causes a timing issue.
2023-09-08 21:29:12 -04:00
Isaiah Odhner
90f52f0655 It's not flaky... it's really the dark mode tests that are failing 2023-09-08 21:21:58 -04:00
Isaiah Odhner
278490f7d5 WIP: Add more tests 2023-09-08 20:03:30 -04:00
Isaiah Odhner
b9822a8290 Fix flaky tests due to cursor blinking 2023-09-08 20:03:17 -04:00
Isaiah Odhner
57ae2e8d44 Clean up 2023-09-08 20:03:17 -04:00
Isaiah Odhner
18c38fd3e0 Merge snapshot results for ASCII-only and Unicode UI tests
I'm basically doing TDD to snapshot testing!
I'm creating tests that don't pass yet, setting up an expectation
that the app match the given screenshots, which is funny in a nice
"improper hierarchy" sort of way, but it's possible because I do
actually have the app rendering how I want, just only in isolation.
If I run the ascii_only tests by themselves, I can get good results
from them, but running them interwoven with default Unicode-using UI
tests doesn't work yet, since the ASCII-only mode permanently changes
how certain widgets render, for the life of the process, so that's
what I'm applying TDD to: making it toggleable at runtime.

I commented out the Unicode tests, and uncommented the ASCII-only tests,
renamed test_snapshots.ambr to test_snapshots_ascii.ambr,
reverted the changes to test_snapshots.ambr to get the Unicode version,
ran my new merge_ambr.py script to join the sets of snapshots,
then replaced test_snapshots.ambr with test_snapshots_merged.ambr
Finally, I uncommented both sets of tests, and I'm ready to do TDD!
2023-09-08 14:44:56 -04:00
Isaiah Odhner
f09f5fbf55 Test light and dark theme variations with a pytest fixture
First I tried setting PYTEST_TEXTUAL_PAINT_ARGS as an environment variable, to be interpreted by args.py, but it turns out args.py is only executed once, not once per test. It's not using subprocesses, only importing and reimporting the app code, and instantiating new App instances, so parts of the code that are at the top level of modules is only evaluated once.

So I found a new strategy, of importing the `args` object in the test fixture and modifying it directly.

I also realized the --ascii-only option permanently modifies Textual's widgets and borders, and my own widgets, for the life of the process, so I'm holding off on that one. I should be able to make --ascii-only mode more dynamic, and could even target it as a runtime toggle, as a goal, since that's basically what I'll need to achieve to get it working for the tests, but thinking of it as a feature is more fun.
2023-09-08 02:18:48 -04:00
Isaiah Odhner
11939b6603 Resize screenshots for some tests 2023-09-07 17:46:48 -04:00
Isaiah Odhner
7d88cbe44f Rename test to match 2023-09-07 17:23:35 -04:00
Isaiah Odhner
f8f2d5ea01 Add snapshot tests for more keyboard-accessible dialogs 2023-09-07 17:22:34 -04:00
Isaiah Odhner
ed97f0afb0 WIP: set up snapshot testing 2023-09-07 15:19:10 -04:00