mirror of
https://github.com/1j01/textual-paint.git
synced 2024-08-17 20:00:41 +03:00
40220e22d2
This should fix this failure:
FAILED tests/test_snapshots.py::test_paint_character_picker_dialog[dark_unicode] - textual.css.query.NoMatches: No nodes match <DOMQuery query='CharacterSelectorDialogWindow'>
I noticed this first in a Windows VM, and am now seeing it in Ubuntu,
so it might have to do with the test running slowly.
This was back on textual 0.28.0 by the way; it doesn't have to do with
the recent updates (as far as I know; at least, not entirely.)
I've never had it reproduce when running in isolation with
pytest tests/test_snapshots.py::test_paint_character_picker_dialog
I tried adding a delay right before the query, and that DIDN'T work,
I got the failure at least once with that in place, so I think it was
failing to detect a double click, rather than querying while the window
was in the process of opening, and so I decided to try increasing the
double click threshold. The click() method of pilot has a cumulative
artificial delay of 0.3s, so two clicks is at least 0.6s and it's not
hard to imagine the event processing pushing that over 0.8s.
I actually created the `DOUBLE_CLICK_TIME` to allow overriding it in
tests, and I'm not sure if this actually works to override it.
|
||
|---|---|---|
| .. | ||
| __snapshots__ | ||
| __init__.py | ||
| conftest.py | ||
| extract_ambr.py | ||
| merge_ambr.py | ||
| pilot_helpers.py | ||
| pilot_recorder.py | ||
| test_behavior.py | ||
| test_encoding.py | ||
| test_snapshots.py | ||