diff --git a/CHANGELOG.md b/CHANGELOG.md index d4153a51..651a2516 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,8 @@ and this project adheres to ### Added +- Output of the default addresses of the upstreams used for resolving PTRs for + private addresses ([#3136]). - Detection and handling of recurrent PTR requests for locally-served addresses ([#3185]). - The ability to completely disable reverse DNS resolving of IPs from diff --git a/client/src/__locales/en.json b/client/src/__locales/en.json index d65585e0..dd39cbfd 100644 --- a/client/src/__locales/en.json +++ b/client/src/__locales/en.json @@ -10,6 +10,8 @@ "bootstrap_dns_desc": "Bootstrap DNS servers are used to resolve IP addresses of the DoH/DoT resolvers you specify as upstreams.", "local_ptr_title": "Private reverse DNS servers", "local_ptr_desc": "The DNS servers that AdGuard Home uses for local PTR queries. These servers are used to resolve the hostnames of clients with private IP addresses, for example \"192.168.12.34\", using rDNS. If not set, AdGuard Home uses the default DNS resolvers of your OS.", + "local_ptr_default_resolver": "By default, AdGuard Home will use the following DNS resolvers: {{ip}}", + "local_ptr_no_default_resolver": "AdGuard Home could not determine suitable private rDNS resolvers for this system.", "local_ptr_placeholder": "Enter one server address per line", "resolve_clients_title": "Enable reverse resolving of clients' IP addresses", "resolve_clients_desc": "If enabled, AdGuard Home will attempt to reversely resolve clients' IP addresses into their hostnames by sending PTR queries to corresponding resolvers (private DNS servers for local clients, upstream servers for clients with public IP addresses).", diff --git a/client/src/components/Settings/Dns/Upstream/Form.js b/client/src/components/Settings/Dns/Upstream/Form.js index 99364549..0e688393 100644 --- a/client/src/components/Settings/Dns/Upstream/Form.js +++ b/client/src/components/Settings/Dns/Upstream/Form.js @@ -143,6 +143,9 @@ const Form = ({ const upstream_dns = useSelector((store) => store.form[FORM_NAME.UPSTREAM].values.upstream_dns); const processingTestUpstream = useSelector((state) => state.settings.processingTestUpstream); const processingSetConfig = useSelector((state) => state.dnsConfig.processingSetConfig); + const defaultLocalPtrUpstreams = useSelector( + (state) => state.dnsConfig.default_local_ptr_upstreams, + ); const handleUpstreamTest = () => dispatch(testUpstreamWithFormValues()); @@ -212,6 +215,14 @@ const Form = ({
local_ptr_desc
+
+ {/** TODO: Add internazionalization for "" */} + {defaultLocalPtrUpstreams?.length > 0 ? ( + `"${s}"`).join(', ') }}>local_ptr_default_resolver + ) : ( + local_ptr_no_default_resolver + )} +