-: add one more test

home/clients.go

@@ -445,6 +445,7 @@ func (clients *clientsContainer) SetWhoisInfo(ip string, info [][]string) {
 		return
 	}
 
+	// Create a ClientHost implicitly so that we don't do this check again
 	ch = &ClientHost{
 		Source: ClientSourceWHOIS,
 	}
@@ -525,7 +526,6 @@ func (clients *clientsContainer) addFromHostsFile() {
 // The command's output is:
 // HOST (IP) at MAC on IFACE
 func (clients *clientsContainer) addFromSystemARP() {
-
 	if runtime.GOOS == "windows" {
 		return
 	}

home/clients_http.go

@@ -257,7 +257,6 @@ func (clients *clientsContainer) handleFindClient(w http.ResponseWriter, r *http
 			}
 			cj := clientHostToJSON(ip, ch)
 			el[ip] = cj
-
 		} else {
 			cj := clientToJSON(&c)
 			el[ip] = cj

home/clients_test.go

@@ -190,7 +190,7 @@ func TestClientsAddExistingHost(t *testing.T) {
 
 	// add a client
 	c = Client{
-		IDs:  []string{"1.1.1.1", "1:2:3::4", "aa:aa:aa:aa:aa:aa"},
+		IDs:  []string{"1.1.1.1", "1:2:3::4", "aa:aa:aa:aa:aa:aa", "2.2.2.0/24"},
 		Name: "client1",
 	}
 	ok, err := clients.Add(c)
@@ -221,4 +221,9 @@ func TestClientsAddExistingHost(t *testing.T) {
 	ok, err = clients.AddHost(testIP, "test", ClientSourceRDNS)
 	assert.False(t, ok)
 	assert.Nil(t, err)
+
+	// don't allow duplicates by CIDR
+	ok, err = clients.AddHost("2.2.2.2", "test", ClientSourceRDNS)
+	assert.False(t, ok)
+	assert.Nil(t, err)
 }