From ee7202a7b4a16eb8936ecaa81a27b3b81b982008 Mon Sep 17 00:00:00 2001 From: Eugene Burkov Date: Wed, 22 May 2024 13:11:58 +0300 Subject: [PATCH] dnsforward: fix http rdns check --- internal/dnsforward/http.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/internal/dnsforward/http.go b/internal/dnsforward/http.go index 76f88edc..5d4738de 100644 --- a/internal/dnsforward/http.go +++ b/internal/dnsforward/http.go @@ -340,7 +340,13 @@ func (req *jsonDNSConfig) checkPrivateRDNS( sysResolvers SystemResolvers, privateNets netutil.SubnetSet, ) (err error) { - if (req.UsePrivateRDNS == nil || !*req.UsePrivateRDNS) && req.LocalPTRUpstreams == nil { + switch { + case + req.UsePrivateRDNS != nil && *req.UsePrivateRDNS, + req.LocalPTRUpstreams != nil && len(*req.LocalPTRUpstreams) > 0: + // Only check the private RDNS servers if its usage has just been + // enabled or if it contains any addresses. + default: return nil }