From 7f1277940b98265a80b0321eae750363bea0defb Mon Sep 17 00:00:00 2001
From: Eric McCarthy <bendyarm@gmail.com>
Date: Thu, 16 Sep 2021 12:35:22 -0700
Subject: [PATCH] [tgc CI] make log more readable; allow tgc type inference to
 run even if there is a tgc canonicalization failure

---
 .github/workflows/acl2.yml | 34 ++++++++++++++++++++--------------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/acl2.yml b/.github/workflows/acl2.yml
index 68a0b47624..f027739300 100644
--- a/.github/workflows/acl2.yml
+++ b/.github/workflows/acl2.yml
@@ -1,6 +1,6 @@
 name: Leo-ACL2
 on: workflow_dispatch
-env: 
+env:
   RUST_BACKTRACE: 1
 
 # This job can only be run on linux (Ubuntu)
@@ -28,35 +28,37 @@ jobs:
       - name: Pull tgc executable
         run: |
           mkdir acl2 && cd acl2;
-          wget $(curl -s https://api.github.com/repos/AleoHQ/leo-acl2-bin/releases/latest \
-              | grep "browser_download_url.*.tgz"  \
-              | cut -d : -f 2,3 \
-              | tr -d \" \
-              | xargs)
+          wget $( curl -s https://api.github.com/repos/AleoHQ/leo-acl2-bin/releases/latest \
+                  | jq -r '.assets[0].browser_download_url' )
 
+          echo "Unpacking $(ls):"
           tar -xvzf $(ls)
-      
-      # Using the prepared ASTs and the pulled and unzipped tgc run theorem generation.
+
+      # Run theorem generation and checking using the prepared ASTs and the pulled and unzipped leo-acl2 tarball.
       - name: Run tgc over ASTs
         run: |
           canonicalization_errors=();
           type_inference_errors=();
+          num_dirs=0;
           for dir in `ls tmp/tgc`;
           do
             cd tmp/tgc/$dir; # enter the directory
+            num_dirs=$((num_dirs + 1));
             ./../../../acl2/tgc canonicalization initial_ast.json canonicalization_ast.json canonicalization-theorem.lisp > canonicalization_result.out || canonicalization_errors+=("$dir");
-            # Disabling Type inference for now
             ./../../../acl2/tgc type-inference canonicalization_ast.json type_inferenced_ast.json type-inference-theorem.lisp > type_inference_result.out || type_inference_errors+=("$dir");
             cd ../../..
           done;
 
+          echo "----------------"
+          echo "Ran tgc in ${num_dirs} directories."
+          echo "----------------"
           if [ ${#canonicalization_errors[@]} -eq 0 ]; then
             echo "Canonicalization - Success!"
           else
-            echo "Canonicalization Failures:";
+            echo "Canonicalization Failures (total: ${#canonicalization_errors[@]}):"
             for dir in ${canonicalization_errors[@]};
             do
-              echo $dir;
+              echo $dir
             done;
 
             #echo "Attaching logs:"
@@ -65,16 +67,16 @@ jobs:
             # cat tmp/tgc/$dir/canonicalization_result.out
             # cat tmp/tgc/$dir/canonicalization-theorem.lisp
             #done;
-            exit 1
           fi
 
+          echo "----------------"
           if [ ${#type_inference_errors[@]} -eq 0 ]; then
             echo "Type Inference - Success!"
           else
-            echo "Type Inference Failures:";
+            echo "Type Inference Failures (total: ${#type_inference_errors[@]}):"
             for dir in ${type_inference_errors[@]};
             do
-              echo $dir;
+              echo $dir
             done;
 
             #echo "Attaching logs:"
@@ -82,6 +84,10 @@ jobs:
             #do
             # cat tmp/tgc/$dir/type_inference_result.out
             #done;
+          fi
 
+          if [[ ${#canonicalization_errors[@]} -ne 0 || ${#type_inference_errors[@]} -ne 0 ]]; then
+            echo "----------------"
+            echo "Exiting with status 1 due to at least one tgc error."
             exit 1
           fi