Into the direct `Result` / `Option` combinator they correspond to, for concision / clarity.
Reviewed from automated suggestions generated from [comby-rust](https://github.com/huitseeker/comby-rust).
678: Bug 662 Fix r=collinc97 a=gluax
Allows -field values in input values, resolves#662. Also add tests for that and group - input values. Cleans up the re-written code used in a few places by adding a pub crate function. Depends on #626.
Co-authored-by: gluax <jonathan.t.pavlik@gmail.com>
Co-authored-by: gluax <16431709+gluax@users.noreply.github.com>
672: Feature/515 eliminate const vars r=collinc97 a=gluax
Resolves#515. Removes const keyword from statements. Also resolves#514. Still allows const y in function declaration of args.
673: feature/671-primefield-refactor r=collinc97 a=gluax
Resolves#671. Refactor "Field + PrimeField" -> "PrimeField" and all tests still pass.
Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com>
Co-authored-by: gluax <jonathan.t.pavlik@gmail.com>
Co-authored-by: Collin Chin <collin.chin@berkeley.edu>
670: feature_626/negative-group-contstraints r=collinc97 a=gluax
Resolves#626. Allows a negative group outside of a pair as well as negative numbers inside a pair group. Waiting to see if the later was necessary in the feature discussion, but I assume it would be.
Co-authored-by: gluax <jonathan.t.pavlik@gmail.com>
652: ASG refactor r=collinc97 a=Protryon
## Motivation
This PR makes the ASG more user friendly by using arenas instead of RefCell/Arc:
1. Impossible to leak the ASG by creating a circular strong reference chain
2. We don't need RefCell's everywhere to implement passes
663: Bug 625/fix negative fields not allowed r=collinc97 a=gluax
Resolves#625. Logic used to do so is in check if first character of string to convert is a negative sign. If so remove first character convert from string to field, and then negate it on the leo side. If first character wasn't a negative sign, do the same as before.
Co-authored-by: Protryon <max.bruce12@gmail.com>
Co-authored-by: gluax <jonathan.t.pavlik@gmail.com>
Co-authored-by: gluax <16431709+gluax@users.noreply.github.com>
653: Fix return type error for input-dependent branches r=collinc97 a=Protryon
This PR fixes failure to handle input-dependent branches. No tests added here since base case is covered, and this only occurs with production constraints. Should fix#535.
There is an additional issue not solved by this PR on branching on booleans from input.
Co-authored-by: Protryon <max.bruce12@gmail.com>
641: Bug/564 input array len not enforced r=collinc97 a=gluax
Resolves#564, depends on #563. The changes for this branch have pulled from PR #638, which is the PR that fixes#563.
Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com>
638: bug/563-array-input-wrong-dimensions r=collinc97 a=gluax
Closes#563. Fixes the array dimension builder when coming from the input file. Adds a test for it as well.
Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com>
633: duplicate name context test r=collinc97 a=gluax
Adding a test for duplicate name context that was resolved in #546.
634: fn call array params r=collinc97 a=gluax
Adding a test for bug #522, which was resolved by the asg.
Closes#522
Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com>
620: Feature/254 strengthen import rules r=collinc97 a=gluax
Grammar changes are a bit different than what was suggested in the original feature request #254. However, it should be logically equivalent and I think makes more sense on the rust side.
Closes#254
Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com>
