Also revise expectations. The changes look extensive in the diff, but only the
error codes have changed (at least, that's the expectation, and this has been
visually checked in some places of the diff).
As discussed, these are no longer in the grammar. If and when we need them, we
will re-add them.
This also removes some extra code that gives a specific error when mut is
used. However, that is in fact another bug, because `mut` is a valid identifier
in the current grammar, and thus this extra code unjustly rejects code that uses
`mut` as an identifier.
Adjust some tests and expectations.
Instead of commenting out this failing test, it seem better to add to a new file
for failing tests. If and when we change Leo to accept field literals in hex, we
can move the test from the Fail file to the Pass fail.
This also helps the ACL2 tester, which is currently not handling comment-out
tests of this form.
This was apparently disabled, but it did not start with a block comment.
This commit fixes it to start with a block comment as required.
This commit also makes it a failing test, which is appropriate because in the
current version of Leo we do not allow untyped literals (i.e. lone numerals as
expressions), and it is thus a good negative test for the current version of
Leo. When we extend Leo to allow untyped literals, we can simply flip the
expectation of this test from Fail to Pass.
Follow the grammar rule. The ordering operators are not associative.
Split previous tests into succeeding and failing ones.
Refresh expectations of old test files.
Add expectations of new test files.
There were four test files, found by @bendyarm, that use end-of-line comments
instead of block comments as prescribed by the README.md.
This commit changes them to block comments, for consistency with the README.md,
and uniformity across the files.
There is clearly nothing wrong with supporting block comments (which apparently
the Rust implementation of the Leo test framework already does). However, just
supporting block comments slightly simplifies the processing of the Leo test
files on the ACL2 side, as we are building that processing right now.
We could support end-of-line comments on the ACL2 side as well if desired. But
it seems unnecessary and unimportant at least for now. This is a quick PR, so
it's okay if it gets rejected and instead we want to support end-of-line
comments right away.
