AppFlowy-IO/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-10-27 11:58:35 +03:00
Code Issues Projects Releases Wiki Activity

chore: Catch platform errors (#1853)

Browse Source 
* refactor(Log): allow passing error and stacktrace to logs

This allows us to log errors and stacktraces in a more structured way.

* feat: catch platform errors

Adds handling for platform errors that are not caught by the
Flutter framework. Doing so will log the error properly and
prevent the app from crashing.
This commit is contained in:
Kristen McWilliam 2023-02-13 20:46:25 -05:00 committed by GitHub
parent 51041f6860
commit 7207e35349
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/app_flowy/lib/main.dart
View File

@ -1,4 +1,6 @@
import 'package:appflowy_backend/log.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:hotkey_manager/hotkey_manager.dart';
@ -19,6 +21,13 @@ class FlowyApp implements EntryPoint {
Future<void> main() async {
WidgetsFlutterBinding.ensureInitialized();
// Handle platform errors not caught by Flutter.
// Reduces the likelihood of the app crashing, and logs the error.
PlatformDispatcher.instance.onError = (error, stack) {
Log.error('Uncaught platform error', error, stack);
return true;
};
await EasyLocalization.ensureInitialized();
await hotKeyManager.unregisterAll();

20
frontend/app_flowy/packages/appflowy_backend/lib/log.dart
View File

@ -24,43 +24,43 @@ class Log {
);
}
static void info(dynamic msg) {
static void info(dynamic msg, [dynamic error, StackTrace? stackTrace]) {
if (isReleaseVersion()) {
log(0, toNativeUtf8(msg));
} else {
Log.shared._logger.i(msg);
Log.shared._logger.i(msg, error, stackTrace);
}
}
static void debug(dynamic msg) {
static void debug(dynamic msg, [dynamic error, StackTrace? stackTrace]) {
if (isReleaseVersion()) {
log(1, toNativeUtf8(msg));
} else {
Log.shared._logger.d(msg);
Log.shared._logger.d(msg, error, stackTrace);
}
}
static void warn(dynamic msg) {
static void warn(dynamic msg, [dynamic error, StackTrace? stackTrace]) {
if (isReleaseVersion()) {
log(3, toNativeUtf8(msg));
} else {
Log.shared._logger.w(msg);
Log.shared._logger.w(msg, error, stackTrace);
}
}
static void trace(dynamic msg) {
static void trace(dynamic msg, [dynamic error, StackTrace? stackTrace]) {
if (isReleaseVersion()) {
log(2, toNativeUtf8(msg));
} else {
Log.shared._logger.v(msg);
Log.shared._logger.v(msg, error, stackTrace);
}
}
static void error(dynamic msg) {
static void error(dynamic msg, [dynamic error, StackTrace? stackTrace]) {
if (isReleaseVersion()) {
log(4, toNativeUtf8(msg));
} else {
Log.shared._logger.e(msg);
Log.shared._logger.e(msg, error, stackTrace);
}
}
}