AppFlowy-IO/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-09-19 23:19:13 +03:00
Code Issues Projects Releases Wiki Activity

fix: #1290 [Bug] 300ms delay on buttons in titlebar (#1789)

Browse Source
This commit is contained in:
Lucas.Xu 2023-02-05 15:38:06 +07:00 committed by GitHub
parent addcabea44
commit cc9bd30356
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart
View File

@ -2,6 +2,7 @@ import 'package:flowy_infra/theme_extension.dart';
import 'package:flowy_infra/size.dart';
import 'package:flowy_infra_ui/style_widget/hover.dart';
import 'package:flowy_infra_ui/style_widget/text.dart';
import 'package:flowy_infra_ui/widget/ignore_parent_gesture.dart';
import 'package:flowy_infra_ui/widget/spacing.dart';
import 'package:flutter/material.dart';
import 'package:textstyle_extensions/textstyle_extensions.dart';
@ -176,7 +177,12 @@ class FlowyTextButton extends StatelessWidget {
highlightColor: Colors.transparent,
elevation: 0,
constraints: constraints,
onPressed: onPressed,
onPressed: () {},
child: child,
);
child = IgnoreParentGestureWidget(
onPress: onPressed,
child: child,
);

31
frontend/app_flowy/packages/flowy_infra_ui/lib/widget/ignore_parent_gesture.dart Normal file
View File

@ -0,0 +1,31 @@
import 'package:flutter/material.dart';
class IgnoreParentGestureWidget extends StatelessWidget {
const IgnoreParentGestureWidget({
Key? key,
required this.child,
this.onPress,
}) : super(key: key);
final Widget child;
final VoidCallback? onPress;
@override
Widget build(BuildContext context) {
// https://docs.flutter.dev/development/ui/advanced/gestures#gesture-disambiguation
// https://github.com/AppFlowy-IO/AppFlowy/issues/1290
return Listener(
onPointerDown: (event) {
onPress?.call();
},
onPointerSignal: (event) {},
onPointerMove: (event) {},
onPointerUp: (event) {},
onPointerHover: (event) {},
onPointerPanZoomStart: (event) {},
onPointerPanZoomUpdate: (event) {},
onPointerPanZoomEnd: (event) {},
child: child,
);
}
}