code organization

* alphabetically sort `engine` methods
 * renamd `engine` methods to group related methods
This commit is contained in:
Eon S. Jeon 2018-11-07 00:43:06 +09:00
parent 65372709f2
commit 77f3d34799
2 changed files with 26 additions and 26 deletions

View File

@ -83,24 +83,6 @@ function TilingEngine(driver) {
self.tiles = Array();
self.screens = Array();
self.manage = function(client) {
if(client.specialWindow)
return false;
self.tiles.push(new Tile(client));
self.arrange();
return true;
}
self.unmanage = function(client) {
self.tiles = self.tiles
.filter(function(t) {
return t.client != client && !t.isError;
});
self.arrange();
}
self.arrange = function() {
self.screens.forEach(function(screen) {
if(screen.layout === null)
@ -127,7 +109,7 @@ function TilingEngine(driver) {
});
}
self.arrangeClient = function(client) {
self.clientArrange = function(client) {
self.tiles.forEach(function(tile) {
if(tile.client != client) return;
@ -143,11 +125,29 @@ function TilingEngine(driver) {
});
}
self.addScreen = function(screenId) {
self.clientManage = function(client) {
if(client.specialWindow)
return false;
self.tiles.push(new Tile(client));
self.arrange();
return true;
}
self.clientUnmanage = function(client) {
self.tiles = self.tiles
.filter(function(t) {
return t.client != client && !t.isError;
});
self.arrange();
}
self.screenAdd = function(screenId) {
self.screens.push(new Screen(screenId));
}
self.removeScreen = function(screenId) {
self.screenRemove = function(screenId) {
self.screens = self.screens
.filter(function(screen) {
return screen.id !== screenId;

View File

@ -30,13 +30,13 @@ function KWinDriver() {
// DEBUG: print("clientAdded " + client + " " + client.resourceClass);
// TODO: check resourceClasses for some windows
if(!engine.manage(client))
if(!engine.clientManage(client))
return;
client.desktopChanged.connect(engine.arrange);
client.geometryChanged.connect(function() {
if(client.move || client.resize) return;
engine.arrangeClient(client);
engine.clientArrange(client);
});
client.moveResizedChanged.connect(function() {
if(client.move || client.resize) return;
@ -52,16 +52,16 @@ function KWinDriver() {
* Sometimes, the client is not found in the tile list, and causes an
* exception in `engine.arrange`.
*/
engine.unmanage(client);
engine.clientUnmanage(client);
// DEBUG: print(" -> numTiles=" + engine.tiles.length);
};
self._onNumberScreensChanged = function(count) {
// DEBUG: print("numberScreenChanged " + count);
while(engine.screens.length < count)
engine.addScreen(engine.screens.length);
engine.screenAdd(engine.screens.length);
while(engine.screens.length > count)
engine.removeScreen(engine.screens.length - 1);
engine.screenRemove(engine.screens.length - 1);
};
/*