Chia-Network/chia-blockchain
1
0
Fork 0
mirror of https://github.com/Chia-Network/chia-blockchain.git synced 2024-08-17 06:41:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

ban peers for 10 minutes when violating consensus rules (#16323)

Browse Source
This commit is contained in:
Arvid Norberg 2023-09-14 21:08:18 +02:00 committed by GitHub
parent cd9d6eff33
commit 540747fae1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
chia/protocols/protocol_timing.py
View File

@ -4,3 +4,4 @@ from __future__ import annotations
INVALID_PROTOCOL_BAN_SECONDS = 10
API_EXCEPTION_BAN_SECONDS = 10
INTERNAL_PROTOCOL_ERROR_BAN_SECONDS = 10 # Don't flap if our client is at fault
CONSENSUS_ERROR_BAN_SECONDS = 600

14
chia/server/ws_connection.py
View File

@ -17,7 +17,11 @@ from typing_extensions import Protocol, final
from chia.cmds.init_funcs import chia_full_version_str
from chia.protocols.protocol_message_types import ProtocolMessageTypes
from chia.protocols.protocol_state_machine import message_response_ok
from chia.protocols.protocol_timing import API_EXCEPTION_BAN_SECONDS, INTERNAL_PROTOCOL_ERROR_BAN_SECONDS
from chia.protocols.protocol_timing import (
API_EXCEPTION_BAN_SECONDS,
CONSENSUS_ERROR_BAN_SECONDS,
INTERNAL_PROTOCOL_ERROR_BAN_SECONDS,
)
from chia.protocols.shared_protocol import Capability, Error, Handshake
from chia.server.api_protocol import ApiProtocol
from chia.server.capabilities import known_active_capabilities
@ -26,7 +30,7 @@ from chia.server.rate_limits import RateLimiter
from chia.types.blockchain_format.sized_bytes import bytes32
from chia.types.peer_info import PeerInfo
from chia.util.api_decorators import get_metadata
from chia.util.errors import ApiError, Err, ProtocolError, TimestampError
from chia.util.errors import ApiError, ConsensusError, Err, ProtocolError, TimestampError
from chia.util.ints import int16, uint8, uint16
from chia.util.log_exceptions import log_exceptions
@ -445,8 +449,12 @@ class WSChiaConnection:
self.log.error(f"Exception: {e} {type(e)}, closing connection {self.get_peer_logging()}. {tb}")
else:
self.log.debug(f"Exception: {e} while closing connection")
if isinstance(e, ConsensusError):
ban_time = CONSENSUS_ERROR_BAN_SECONDS
else:
ban_time = API_EXCEPTION_BAN_SECONDS
# TODO: actually throw one of the errors from errors.py and pass this to close
await self.close(API_EXCEPTION_BAN_SECONDS, WSCloseCode.PROTOCOL_ERROR, Err.UNKNOWN)
await self.close(ban_time, WSCloseCode.PROTOCOL_ERROR, Err.UNKNOWN)
finally:
if task_id in self.api_tasks:
self.api_tasks.pop(task_id)