Chia-Network/chia-blockchain
1
0
Fork 0
mirror of https://github.com/Chia-Network/chia-blockchain.git synced 2024-10-04 06:48:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix wallet RPC client's get_transaction_count return type (#17257)

Browse Source 
Fix wallet RPC client's get_transaction_count return type.
This commit is contained in:
Amine Khaldi 2024-01-10 21:37:28 +01:00 committed by GitHub
parent d511e74e0e
commit 9926f26398
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
chia/rpc/wallet_rpc_client.py
View File

@ -165,11 +165,8 @@ class WalletRpcClient(RpcClient):
return [TransactionRecord.from_json_dict_convenience(tx) for tx in res["transactions"]]
async def get_transaction_count(
self,
wallet_id: int,
confirmed: Optional[bool] = None,
type_filter: Optional[TransactionTypeFilter] = None,
) -> List[TransactionRecord]:
self, wallet_id: int, confirmed: Optional[bool] = None, type_filter: Optional[TransactionTypeFilter] = None
) -> int:
request: Dict[str, Any] = {"wallet_id": wallet_id}
if type_filter is not None:
request["type_filter"] = type_filter.to_json_dict()

11
tests/wallet/rpc/test_wallet_rpc.py
View File

@ -913,13 +913,12 @@ async def test_get_transaction_count(wallet_rpc_environment: WalletRpcTestEnviro
assert len(all_transactions) > 0
transaction_count = await client.get_transaction_count(1)
assert transaction_count == len(all_transactions)
assert await client.get_transaction_count(1, confirmed=False) == 0
assert (
await client.get_transaction_count(
1, type_filter=TransactionTypeFilter.include([TransactionType.INCOMING_CLAWBACK_SEND])
)
== 0
transaction_count = await client.get_transaction_count(1, confirmed=False)
assert transaction_count == 0
transaction_count = await client.get_transaction_count(
1, type_filter=TransactionTypeFilter.include([TransactionType.INCOMING_CLAWBACK_SEND])
)
assert transaction_count == 0
@pytest.mark.limit_consensus_modes(allowed=[ConsensusMode.PLAIN, ConsensusMode.HARD_FORK_2_0], reason="save time")