Chia-Network/chia-blockchain
1
0
Fork 0
mirror of https://github.com/Chia-Network/chia-blockchain.git synced 2024-11-09 17:36:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

It is okay to return a result in some cases when median == -1 (#14285)

Browse Source 
* It is okay to return a result in some cases when median == -1. These cases are handled in the call to parse()

* Remove incorrect test
This commit is contained in:
Adam Kelly 2023-01-13 14:09:40 -08:00 committed by GitHub
parent 5303c0eecc
commit d83c93bb2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chia/full_node/fee_estimator.py
View File

@ -83,7 +83,7 @@ class SmartFeeEstimator:
def estimate_result_to_fee_estimate(self, r: EstimateResult) -> FeeEstimate: def estimate_result_to_fee_estimate(self, r: EstimateResult) -> FeeEstimate:
fee: float = self.parse(r) fee: float = self.parse(r)
if fee == -1 or r.median == -1: if fee == -1:
return FeeEstimate("Not enough data", r.requested_time, FeeRate(uint64(0))) return FeeEstimate("Not enough data", r.requested_time, FeeRate(uint64(0)))
else: else:
# convert from mojo / 1000 clvm_cost to mojo / 1 clvm_cost # convert from mojo / 1000 clvm_cost to mojo / 1 clvm_cost

46
tests/fee_estimation/test_fee_estimation_unit_tests.py
View File

@ -104,52 +104,6 @@ def test_steady_fee_pressure() -> None:
assert estimates_after == block_estimates assert estimates_after == block_estimates
def test_fee_estimation_inception() -> None:
"""
Confirm that estimates are given only for blocks farther out than the smallest
transaction block wait time we have observed.
"""
max_block_cost_clvm = uint64(1000 * 1000)
estimator1 = create_bitcoin_fee_estimator(max_block_cost_clvm)
wallet_tool = WalletTool(test_constants)
cost = uint64(5000000)
fee = uint64(10000000)
start = 100
end = 300
for height in range(start, end):
height = uint32(height)
# Transactions will wait in the mempool for 1 block
items = make_block(wallet_tool, height, 1, cost, fee, num_blocks_wait_in_mempool=1)
estimator1.new_block(FeeBlockInfo(uint32(height), items))
e = []
for seconds in range(40, 5 * 60, 40):
est = estimator1.estimate_fee_rate(time_offset_seconds=seconds)
e.append(est.mojos_per_clvm_cost)
# Confirm that estimates are available for near blocks
assert e == [2, 2, 2, 2, 2, 2, 2]
##########################################################
estimator5 = create_bitcoin_fee_estimator(max_block_cost_clvm)
for height in range(start, end):
height = uint32(height)
# Transactions will wait in the mempool for 5 blocks
items = make_block(wallet_tool, height, 1, cost, fee, num_blocks_wait_in_mempool=5)
estimator5.new_block(FeeBlockInfo(uint32(height), items))
e1 = []
for seconds in range(40, 5 * 60, 40):
est = estimator5.estimate_fee_rate(time_offset_seconds=seconds)
e1.append(est.mojos_per_clvm_cost)
# Confirm that estimates start after block 4
assert e1 == [0, 0, 0, 2, 2, 2, 2]
def test_init_buckets() -> None: def test_init_buckets() -> None:
buckets = init_buckets() buckets = init_buckets()
assert len(buckets) > 1 assert len(buckets) > 1