* initial commit
* assert coin added in test
* add support functions
* add RPC calls (untestested and surely unworking)
also change innerpuz
* missing comma
* update puzzle clvm hex sha256
* fixes
* add load_wallet for nft_wallet
* add singleton 1.1 and update innerpuz for it
* update wallet for new innerpuz
* use singleton 1.1
* swap DID to singleton 1.1
* Fix DID Wallet and DID Innerpuz
* list hint
* don't push automatically
* change to determine_coin_type
* stash debug
* fix get_hints()
* small fix en route to bigger fix later
* push for straya
* checkpoint
* coin discovered in wallet
* re-enable push of attests because message spends are different
* change a few node calls for rebase and rebase
* black and flake8
* flake8 test formatting
* Add transfer test and some transfer functions
* fix bug where innerpuzzle would not recreate itself properly
* fix get_info for received NFT and reovme breakpoint
* fix messages
* debug commit
* receive and send it back!
* send it back and remove NFTs after they're sent
* fix adding duplicates bug
* mint NFT with RPC calls test
* save newer coin info over older info
* finish RPC tests
* update to new version of singleton
black
* change puzzle to remove need for receive spend when trade_price = 0
* Begin conversion to trade price list
* fix test to new trade_price_list system
* Move towards goals in chialisp
* fix clvm testss
* remove unused code
* more chialisp changes working towards CAT royalties
* much progress on CAT royalties
* round down to even on royalties
* add delay to fix inconsistent tests
* remove unused file
* add assertions and fine tune sleep
* add richer support for URIs / metadata and add periphery functions
* switch to metadata, switch to puzzle announcements
* update innerpuz commit hash
* add clvm files to recomp list
* fix rpc test
* flake8 fixes for tests
* flake 8 stupid fix
* Big change to NFT innerpuz (#11141)
* new innerpuz with passing clvm tests
* more work on url updating
* fix broken add_url tests
* fix nft_wallet generate_nft code
* more progress
* fix wallet and change to auto-send on tradeprice == 0
* flake8 and black
* NFTs are always amount 1
removed some unnecessary new_did info detritus from wallet
* move trade_price_list into tp_solution
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* Update chia/wallet/nft_wallet/nft_puzzles.py
* typing for create_full_puzzle_with_curry_params
* Typing for update_metadata
* Typing for get_trade_prices_list_from_inner_solution
Co-authored-by: Jeff <jeff@chia.net>
* Merge commit with main (9ff3fc993f) (#11137)
* Merged with main (9ff3fc993f)
* Linter and some test fixes
* isort, linting, test fix
* Fixes and bumped the GUI to point to nftdev
* Couple of fixes
* Bumping GUI to 7aa199a4fb
* Bumping GUI to 155866f6d0
* DID changes all in one (#10559)
* Chialisp draft
* Modify python code
* Reformat & Fix tests
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* Handle recovery
* Chialisp draft
* Modify python code
* Reformat & Fix tests
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* add clvm files to recomp list
* fix rpc test
* flake8 fixes for tests
* flake 8 stupid fix
* Bug fix & flake8 fix for NFT tests
* Modify python code
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* Generalize the message puzzle
* Add Pubkey as hint
* Receive DID
* Add DID APIs & Tests
* Fix tests
* Test fixes. in_transaction is now passed as a param to the various callers that eventually call save_info.
* Workflow Fix
* Add test config for DID/NFT
* Update workflow test yaml
* Fix install test script
* Fix typo
* Resolve comments
* Fix tests
* Change did_innerpuz and fix wallets for new design (#11196)
* correcting the design of did_innerpuz and related wallet changes
* remove breakpoint comments
* change decimal point accuracy of percentage system
* secure new_amount by fixing it to our current amount
* rename and update comments for new_amount - now my_amount
* rename P2_PUZZLE to simply INNER_PUZZLE
* fix variable re-declaration for flake/merge
* black and flake8 - inclduing wallet_state_manager bug fix
* update RPCs related to add_url
added commented out tests too, but DID needs fixing first
* Fix bugs in transfer case
* Fix pre-commit
* Fix install.sh test for bookworm
Co-authored-by: matt <matt@chia.net>
Co-authored-by: Jeff Cruikshank <jeff@chia.net>
Co-authored-by: matt-o-how <48453825+matt-o-how@users.noreply.github.com>
Co-authored-by: ytx1991 <t.yu@chia.net>
* Merge commit with main 1.3.4 (d154105a6b) (#11276)
* slight simplification of interpreting the bytes received by the timelord. avoid redundant round-trips to strings (#10316)
* move build and twine to be dev deps rather than workflow installs (#10291)
* add db validate function to check consistency of blockchain database (#10398)
* streamable: Cache stream functions (#10419)
Apply the same pattern as we have for deserialization to serialization.
This avoids all those recursive runtime lookups for "how to stream this
object" which brings a nice speedup:
```
compare: benchmark
mode | µs/iteration old | µs/iteration new | diff %
to_bytes | 447.57 | 193.56 | -56.75
compare: full_block
mode | µs/iteration old | µs/iteration new | diff %
to_bytes | 110.32 | 61.09 | -44.62
```
* Stop assuming `True == 1` (#10396)
* Stop assuming `True == 1`
* Removed unnecessary lines which confuses code readers
* simplify self_hostname. It doesn't need to depend on initial-config.yaml -> create_block_tools() -> global variable bt (#10371)
* Fix balance calculation so it works with future unconfirmed tx (#10447)
* Only update height if we have processed everything before that height. (#10415)
* Only update height if we have processed everything before that height.
* Remove debug return
* Forgot this file
* Better sorting of coin states, and disconnect peer if we are connected to trusted
* Fix disconnect, and don't mutate arguments
* Fix comment
* Update chia/wallet/wallet_node.py
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Update chia/wallet/wallet_state_manager.py
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Address comments
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* GC connections in wallet (#10450)
* Fix the year from 2021 to 2022 (#10462)
* Ms.unused code (#10453)
* Remove old backup stuff
* Remove references to CC (couloured coins) which is deprecated terminology
* removed no longer used import
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Don't load initial data older than 5 days (#10481)
* When loading initial data, don't include IPs older than 5 days in the best timestamp dict
* Don't load version data for hosts older than 5 days
* Update the DMG background image (#10289)
* Update the DMG background image
* Updated with latest design.
* Updated background.tiff with latest design
* Fancier DMG customization support via build_dmg.js
* npm_macos -> npm_macos_m1
* Pass in the app path to build_dmg.js
* Peppering with __init__.py files to satisfy the precommit hook
* Return the fees of an offer via RPC (#10480)
* farmer: Cleanup request retry and some logs (#10484)
* farmer: Bump next update times regardless of the request results
* farmer: Drop additional "success/failure" log logic
We already print the PUT response in `_pool_put_farmer` the other parts
just lead to confusion if the pool didn't implement the PUT correct.
* farmer: Print error responses from the pool with `WARNING` log level
* Fix method name (#10500)
* updated gui to e2202874e1
* reverted to gui 800a0f6556
* updated gui to 672cf2a74a
* Only rewrite config when there is a difference (#10522)
* Only rewrite config when there is a difference
* Use variable
* Preserve existing pool payout_instructions when creating a PoolWallet (#10507)
* Preserve existing pool payout_instructions when creating a PoolWallet
* Updated the logged string when payout_instructions needs to be generated.
* Tests for update_pool_config
* isort
* Logging change, linter fixes, and more comments.
* Abort trusted sync if a state update fails (#10523)
* Abort trusted sync if a state update fails
* Fix lint
* fix updating of sub-epoch-summary map (part of BlockHeightMap) when the entirey change, including genesis changes (#10486)
* Fix propagation of errors when adding a key with an invalid mnemonic (#10274)
* Fix propagation of error messages originating from the keychain server
* Test that adding key with an invalid mnemonic returns the expected error
* Added daemon tests for the add_private_key RPC. Reverted wallet_rpc_client test as the daemon test is better suited for GUI testing.
* Reformatting updates
* Formatting change as requested by the pre-commit gods.
* catch up test_add_private_key() with dynamic ports (#10530)
* Updated background and icon positions. (#10531)
* improve the picking of free ports for tests (#10491)
* Hide balances until we are synced (#10501)
* make multiprocessing start method configurable (#10528)
* make multiprocessing start method configurable
* forkserver
* corrections
* fixup
* optional
* more optional
* stop attempting anchors in the yaml
* rework config handling
* comment
* Update URL for direct download of windows whl for upnp (#10540)
* Add incoming tx records when cancelling an offer (#10538)
* Add incoming tx records when cancelling an offer
* show fee on all txs
* wallet: Reduce log level for `Pulled from queue` message (#10529)
* pools: Drop redundant `PoolWalletInfo.from_json_dict` (#10524)
It exists the same way in its base class `Streamable`.
* correct multiprocessing start method logging, add python_default (#10547)
* correct multiprocessing start method logging, add python_default
* todo -> regular comment
* correct some comments to refer to CATs (#10548)
* correct some comments to refer to CATs
* one more
* and in a test
* Detect hints correctly in the TX (#10543)
* Detect hints correctly in the TX
* Only support list hints
* Allow CAT autodiscovery, refactor CAT default naming (#10308)
* Allow CAT autodiscovery
* Add wallet autodiscovery test
* Use dict get for automatically_add_unknown_cats with default false
* Refactor name generation for new CATs into one place
* Remove hardcoded default cat wallet name from wallet rpc test
* initial-config.yaml comment nit
* Wallet consistancy (#10532)
* use db transaction, -1 in synced up to height, delete unused funcitons
* use transaction info in key-val-store/pool-store
* cat stores
* db lock
* remove unused lock, set synced not always in transaction
* fix store tests
Co-authored-by: wjblanke <wjb98672@gmail.com>
* benchmarks: Implement streamable data comparison (#10433)
* Resubmit peak to timelord for failure. (#10551)
* Initial commit resubmit peak to timelord.
* Change how toandle exception.
* Add some logging. (#10556)
* Fix `install-gui.sh` (#10460)
* Fixed an issue where running with gui git branch specified failed
* Fixed an issue where install-gui.sh failed if npm>=7 and NodeJS < 16 were installed
* Fixed inconsistent npm path issue
* Fixed typo
* Add fee to changing pool, and more PlotNFT syncing fixes (#10545)
* Add fee to changing pool, and more aggressive disconnect of untrusted
* Don't publish fee TX
* Lint
* Small plotnft related fixes
* More plotnft fixes
* Apply quexington suggestion
* correct param for in_transaction
* Support get_transaction and get_transactions in plotnft
* Re-add publish_transaction and add comment
* Don't rerun additions
* adding 1.3.0 release notes to changelog (#10578)
* adding 1.3.0 release notes to changelog
* Typos. thx @paninaro
* Adding requested adjustments to changelog
* Require pytest-asyncio>=0.17.0 for @fixture() (#10560)
* Convert tests/core/util/test_streamable.py to use pytest. Remove unneeded class. (#10577)
* make sync fixtures not use async def (#10504)
This is particularly relevant in cases where the scope is not function as
that forces use of a wider scoped event loop fixture as well.
* Fixup some hidden test errors (#10442)
* Touching up changelog (#10584)
* removing known issue that was only applicable to a beta release
* Adding additional fixes to the changelog
* Adding Unreleased section to track upcoming changes
* context manager for socket in find_available_listen_port(), catch OSError (#10567)
* Bump CAT wallet test timeout to 40 minutes (#10605)
* Remove block tools and keychain globals (#10358)
* Use bt fixture
* rebase
* Use local_hostname
* Fix test_json (inheritance from unittest.TestCase)
* Use correct BlockTools fixture for test_simulation
* Pass bt fixture into cost calculation tests
* flake8
* Add missing parameters to test functions
* Fix from rebase issues
* Remove set_shared_instance
* Update comment
* Remove unneeded comments
* Remove unused code
* Remove unused code, run `multiprocessing.set_start_method("spawn")` at correct time.
* Revert unrelated change
* Set daemon_port. Teardown services in correct order.
BIG thanks to Mariano Sorgente for debugging help.
* Add back type signature - rebase issue
* Apply review fixes from Jeff
* Document why we need a later pytest-asyncio version
* Correct type for _configure_legacy_backend
* See what's going on during CI mypy run
* github workflows
* mypy typing
* Remove legacy Keyring create method
* Start daemon first
* Shutdown daemon coroutine properly
* Remove un-needed daemon_port argument
* Set chia-blockchain-gui to hash in main
* Remove connect_to_daemon_port
* Remove code that set "daemon_port" before calling `setup_daemon`
* Remove self_hostname fixture and extra self_hostname global
* Fix two test files that were not importing self_hostname
* self_hostname fixture
* Remove more unused test code
* Simplify fixture
* a problem with using random.randint() to pick a port is that all processes (running in parallel) are seeded the same, and so pick the same ports at the same time, causing conflicts. This uses proper entropy instead. (#10621)
* `chia keys show` will default to displaying the first observer-derived wallet address. With the addition of the `-d` option, the non-observer derived wallet address can be displayed. (#10615)
* pools: Fix `plotnft claim` command's output (#10609)
If you currently claim rewards `claim_cmd` fails to print the txhash
with the lookup hint in `submit_tx_with_confirmation`
```
Error performing operation on Plot NFT -f 172057028 wallet id: 12:
'dict' object has no attribute 'name'
```
Because `submit_tx_with_confirmation` expects a `TransactionRecord` as
result from its callable parameter `func` but `pw_absorb_rewards`
returns a dict which includes the `TransactionRecord` as value for the
key `transaction`. This PR makes sure all other methods used as `func`
callable have the same return behaviour as `pw_absorb_rewards`. We could
have adjusted it the other way around (only return `TransactionRecord`
in `pw_absorb_rewards`) but then we would drop information in the RPC
client.
With this PR you get:
```
Do chia wallet get_transaction -f 172057028 -tx
0x34f74a1ffd9da9a493b78463e635996fd03d4f805ade583acb9764df73355f9c to
get status
```
* fix initial-config typo - log_maxbytesrotation (#10598)
* Fix invalid DB commit (#10594)
* Fix invalid DB commit
* More fixes
* Add raise
* Fix test
* correct spelling of genrated (#10653)
* fix [Bug] #10569 (#10571)
* Version control (#10479)
* Added version control enforcement to macOS m1
* Added enforced version control
* Added enforce version compliance
* Added enforced version compliance
* Added enforced versioning
* Updating this to include DRY internal action.
* Removed some unintended whitespace.
* Removed some unintended whitespace.
* CI re-run
* Trying to figure out why it's failing one test.
* Trying to figure out why it's failing one test.
* Trying to figure out why it's failing one test.
* plotting: Only lock while actually accessing `PlotManager.plots` (#10675)
* Fix exception when `chia keys migrate` is run without needing migration (#10655)
* Fix exception when `chia keys migrate` is run without needing migration
* Linter fixes
* Slightly different query for V2 DBs for getting compact/uncompact block counts, to ensure the available index is used / avoid a table scan (#10661)
* Check prefix on send_transaction before sending (#10566)
* Check prefix on send_transaction
* Fix failing RPC tests - xch -> txch since tests are a testnet and we enforce valid prefixes with this PR
* Ak.convert fixtures (#10612)
* Use bt fixture
* rebase
* Use local_hostname
* flake8
* Remove set_shared_instance
* Remove unneeded comments
* Revert unrelated change
* Add back type signature - rebase issue
* Correct type for _configure_legacy_backend
* See what's going on during CI mypy run
* github workflows
* mypy typing
* Remove legacy Keyring create method
* Start daemon first
* Set chia-blockchain-gui to hash in main
* Fix two test files that were not importing self_hostname
* self_hostname fixture
* Convert all class fixtures to top level functions
* updated gui to cdfa2b9821
* Better management of KeyringWrapper's keys_root_path when using TempKeyring for tests (#10636)
* Better management of KeyringWrapper's keys_root_path when using TempKeyring for tests.
* Move keys_root_path restoration code into `cleanup()`
Added an assert to detect if an unexpected shared KeyringWrapper is injected during a test.
* Conditionally restore keys_root_path for testing
* better TLS1.3 check (#10552)
* better TLS1.3 check
* catch ValueError instead of Exception
* Code simplification and cleanup
* a few nits in comments
* Add configuration locking (#10680)
* Add configuration locking
Extracted from https://github.com/Chia-Network/chia-blockchain/pull/10631
* note that fasteners will likely be replaced by filelock
* Fix test_multiple_writers on macOS
* create_all_ssl() doesn't need to be inside the config access lock
* add warnings about not using async within get_config_lock() get lock contexts
* no need to pre-touch the lock file
* .yaml.lock instead of just .lock
* test_multiple_writers() is sync
* Revert "add warnings about not using async within get_config_lock() get lock contexts"
This reverts commit 681af3835b.
* reduce lock context size in chia_init()
* use an exit stack in load_config()
* avoid config existence precheck
* only lock around the read in load_config()
* do not raise e, just raise
* tidy new imports
* fix queue empty check in test_config.py
* remove commented out code in test_config.py
* remove unused import
Co-authored-by: Jeff Cruikshank <jeff@chia.net>
* fix usage of the bt fixture in conftest fixtures (#10688)
* bump pre-commit mypy to 0.940 (#10672)
* remove some event_loop() fixtures (#10420)
* remove event_loop() fixtures
* flake8
* flake8
* remove sys.exit() from daemon shutdown
* bump full node test timeout. a lot... to see.
* fixup some tests
* back to module scope event loop fixture for test_full_node.py
* Update test_full_node.py
* Iterator...
* for the whole directory
* some fixtures back to module scope for reduced runtime
* back to 40 minute workflow timeouts
* these are being addressed separately
* updated gui to c992d07c95
* tests: Add `_PYTEST_RAISE` to fix exception breakpoints with pytest (#10487)
It's currently not possible to have the debuger stop on an uncaucht
exception when debugging tests. With this patch, adding
`_PYTEST_RAISE=1` to the environment variables in the pytest
configuration template fixes this.
* Fixed test failures on Windows. (#10740)
* Convert helper method do_spend from a class method to a function (#10613)
* Remove unused test code (#10614)
* Ak.setup nodes (#10619)
* Remove unused test code
* Centralize fixture uses of setup_n_nodes
* Centralize fixure uses of setup_two_nodes
* Break up setup_nodes into setup_services, for individial services, and setup_nodes, for initializing different simulator configurations
* Sort imports
* more entropy in random listen ports (#10743)
* update chia-blockchain-gui one commit for npm build fix (#10776)
* Updating Changelog for point release (#10781)
* Updating Changelog for point release
* Adding missing changelog items
* run benchmarks separately (#10754)
* run benchmarks separately
* only run benchmarks once, with the most recent python version we support
* Change name to order of returned values. Enforce mandatory naming and inclusion of start_services parameter (#10769)
* cmds: Implement `chia rpc` command (#10763)
* cmds: Implement `chia rpc` command
* Enable "timelord" client + some refactoring to enable "crawler" client
* wallet: Fix `STANDARD_WALLET` creation for `wallet_info.id != 1` (#10757)
* wallet: Optional wallet type parameter for `get_wallets` and `wallet show` (#10739)
* wallet: Add optional `type` parameter to `get_wallets` and `wallet show`
* tests: Use the `type` parameter for `get_wallets` in pool rpc tests
* cmds: Ask for the name of the wallet type in CLI
* harvester: Reuse legacy refresh interval if new params aren't available (#10729)
* mypy 0.941 for pre-commit (#10728)
* Add maker fee to remaining offer RPCs (#10726)
* Add healthcheck endpoint to rpc services (#10718)
* Add healthcheck endpoint to rpc services
* Trailing whitespace ding
* Fix typos lastest > latest (#10720)
* fix typo in command line argument parsing for chia db validate (#10716)
* New RPC get_coin_records_by_hint - Get coins for a given hint (#10715)
* RPC endpoint to retrieve coins by hint
* RPC client update for get_coin_records_by_hint
* start writing tests for get_coin_records_by_hint
* Address linting concerns.
* Address flake8. Fix the get_coin_ids() call.
* convert hint to bytes32
* tests for get_coin_records_by_hint
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
* require test-cache repo is found in CI (#10711)
* Issues found in RPC API review (#10702)
* Removed unnecessary substitution
* Recovered property which was accidentally removed in full node RPC API
* Added backward compatibility to `get_additions_and_removals` full_node RPC API
* Fixed full_node rpc client
* minor followup to config locking (#10696)
* minor lock scope reduction
* use the lock in tests
* Use the passed root_path in configure CLI command (#10694)
* Improve the CI runs w.r.t. timelord installation (#10673)
* Superficial analysis showed that only two test groups require (for now) installing the timelord. This change aims to save us hours of CI running time by simply running the install timelord script only for those test groups, with everything else having it omitted. Dedicated to @hoffmang9
* We don't need these anymore.
* less optional around ssl (#10558)
* less optional
* clean up cruft
* more
* more
* just a little less optional
* cmds: Fix trusted peer hint in `chia wallet show` (#10695)
`config` is the root config here.
* Enable clvm_tools_rs by default (#10554)
* Enable clvm_tools_rs by default
* Re-add clvm_tools dep for now as it provides python idioms for interacting with clvm data
* Take lint formatting
* Adam: Try making this non-parallel
* Try fix for threading issue in tests
* Test whether turning off parallel runs causes things to work (temp)
* Test use of temp files in clvm_tools_rs as a candidate solution for atomic replacement of hex output
* Use proper git+https url scheme (oops)
* Update to candidate 0.1.6 so we can test
* Revert version bump to re-test
* Test whether we can re-enable parallelism
* Attempt to mitigate concurrent test running: return own conception of the compiled output. This will work if the failing path is downstream of recompilation
* fix path to hex file
* Probe for source of 0-length data
* Further exploration: more assertions, hopefully to trigger in the test on ci
* Do an even more paranoid check to verify that we observe a file whose filesystem reported size is much smaller than expected
* Try a heavier handed approach, using heavyweight lockfiles on the filesystem
* Import a simple lockfile implementation and use it to enforce mutual exclusion. Simplify it and remove the unwanted os traffic
* Take lint, precommit advice, bump to clvm_tools_rs 0.1.6 now that it's released
* Fix lint
* While i was working on this, -n auto was on the command line so i think this didn't actually do anything, but reverting my change just in case
* Lint
* label the hashes re: pr
* Add a lock.py for spot exclusivity using the filesystem (re: adam in the pr) and a convenience wrapper that hides the details
* Formatting warning
* Ensure type info is present and do the obvious return of the inner function's result
* Use double quotes (lint)
* Properly balance blank lines
* Lint: alphabetize imports
* One line is required here (lint)
* Remove unnecessary assignment
* when creating a new blockchain database implicitly, make it v2 (#10498)
* when creating a new blockchain database implicitly, make it v2
* fix config deadlock
* add select_coins RPC method (#10495)
* add select_coins RPC method
* typing fix
* fix typing, casts
* add RPC coin selection tests
* black formatting
* fix select_coins tests
* improve error messages from chia db upgrade, specifically to help users if the disk is full (#10494)
* more set -o errexit (#10468)
* more set -o errexit -o pipefail
* no pipefail, too fancy for dash at least...
* Bump clvm_tools_rs to fix a problem running as daemon caused by old log message that is now eliminated (#10788)
* when running multiple services in the same process (in tests), don't initialize logging for all of them, and don't set the proctitle of the test (#10686)
* stop helping mkdir() do what it already does (#10802)
* stop helping mkdir() do what it already does
* flake8
* Capitalize display of Rpc -> RPC in `chia show -s` (#10797)
* Remove accidental parameters from calls to setup_simulators_and_wallets and prevent future mistakes (#10770)
* stop using deadsnakes, unless we need it (#10752)
* stop using deadsnakes. and see...
* only install dead snakes stuff if building the timelord on linux
* small change to fix branch in contributing (#10805)
* small change to fix branch in contributing
* Update CONTRIBUTING.md
* Rename confusing fixtures, especially ones with the same name but dif… (#10772)
* Rename confusing fixtures, especially ones with the same name but different implementation
* rename test_environment to test_plot_environment
* Make it so setup_two_nodes is no longer the name of a fixture and a utility function
* revert premature fixture rename: two_wallet_nodes_start_height_1
* atomic rollback for wallet (#10799)
* atomic rollback for wallet
* Handle cases where one node doesn't have the coin we are looking for (#10829)
* Continue if one node doesn't have the coin
* Pass in coin_state list
* Pass in the single coinstate instead of list
* more simplifications
* run tests in parallel in CI (#10499)
* Fix timelord installation for Debian. (#10841)
* add optional persistence to SpendSim (#10780)
* add optional persistence to SpendSim
* Accidental rename
* remove duplicate event_loop (#10768)
* Adding check for python3.9 alongside python3.10 on Arch (#10363)
* Adding check for python3.9 alongside python3.10 on Arch
* Adjusting install.sh instructions for Arch
* Disabling prescribed python install for Arch
* Setting Arch install script to exit 0 to pass tests
* Adding workflow step for functional Arch install testing
* Adding noconfirm to pacman install command
* Relocating Arch support message for install.sh
* use DEFAULT_ROOT_PATH in tests (#10801)
* Disable the pytest-monitor plugin in CI if not checking results (#10837)
* disable the pytest-monitor plugin if not reporting results
pytest-monitor uses multiprocessing and has caused multiple confusing
issues. Perhaps it can be adjusted to not use multiprocessing, but
for now lets just isolate the oddities to where we actually use it.
* use a template for resource usage check, similar to timelord install
* hint testconfig.custom_vars
* Check for requesting items when creating an offer (#10864)
* updated gui to 054d7b342e
* Added `-n`/`--new-address` option to `chia wallet get_address` (#10861)
* Added `-n`/`--new-address` option to `chia wallet get_address`
* Formatting fix
* Complemented --new-address with --latest-address per feedback
* Minor output formatting/enhancements for `chia wallet show` (#10863)
* Minor output formatting/enhancements for `chia wallet show`
* Updated format based on internal poll results
* Linter fix and row rearrangement.
* Hardcoded SSL test certs/keys (#10828)
* Hardcoded SSL test certs/keys
* Added a second set of certs/keys.
Cert/key sets are infinitely cycled-through using get_next_private_ca_cert_and_key() and get_next_nodes_certs_and_keys()
* More cert/key sets and a tool to generate them
* Updated SSL generator to sign with the appropriate root CA.
Fixed linter issues.
* Linter fixes
* Updated generate_ssl_for_nodes() based on feedback
* reduce indentation in a few functions in blockchain.py by negating early-exit checks and loop continues (#10872)
* fix typo and index issues in wallet database (#10273)
* fix typo in wallet_puzzle_store
* check some SQL statements
* deduplicate name SQL index
* deduplicate wallet_type index
* deduplicate wallet_id index
* Update appdmg to 0.6.4 to work with macos 12.3 (#10886)
* fixup and enable condition checking tests (#10888)
* fixup and enable tests for the edge cases of absolute timestamp and absolute height conditions in mempool_manager
* Update chia/full_node/full_node_api.py
Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com>
Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com>
* Bump colorlog from 5.0.1 to 6.6.0 (#9207)
Bumps [colorlog](https://github.com/borntyping/python-colorlog) from 5.0.1 to 6.6.0.
- [Release notes](https://github.com/borntyping/python-colorlog/releases)
- [Commits](https://github.com/borntyping/python-colorlog/compare/v5.0.1...v6.6.0)
---
updated-dependencies:
- dependency-name: colorlog
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump actions/checkout from 2 to 3 (#10505)
* Bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update actions in templates too
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
* Bump github/super-linter from 4.8.1 to 4.9.1 (#10894)
* Bump github/super-linter from 4.8.1 to 4.9.1
Bumps [github/super-linter](https://github.com/github/super-linter) from 4.8.1 to 4.9.1.
- [Release notes](https://github.com/github/super-linter/releases)
- [Changelog](https://github.com/github/super-linter/blob/main/docs/release-process.md)
- [Commits](https://github.com/github/super-linter/compare/v4.8.1...v4.9.1)
---
updated-dependencies:
- dependency-name: github/super-linter
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Ignore too-many-function-args in test_type_checking.py
* black
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
* fix type annotations for get_block_generator() (#10907)
* fix type annotations for FullBlock.header_hash and FullBlock.prev_header_hash (#10909)
* new DBWrapper supporting concurrent readers (#10166)
* new DBWrapper supporting concurrent readers
* adress review comments
* fixup default database version, when file doesn't exist
* remove unused argument
* use rust clvm in Program.run() (#10878)
* remove Program.from_serialized_program
* run the rust clvm implementation (instead of python) even for wallet programs
* Fix flaky trade test (#10921)
* single thread executor (#10919)
* add inline executor and an option to run single-threaded
* add option to run test_full_sync in single-thread mode, to include block validation in profiles. Also attempt to speed it up by disabling db_sync
* await the db commit in the async version of set_db_version (#10906)
* bump pre-commit mypy to v0.942 (#10902)
* bump clvm_tools dependency to make every chia-blockchain installation get the new brun that reports cost accurately (#10880)
* wallet: Drop unused `WalletStateManager.load_wallets` (#10756)
* Switch to integrated lock_and_load_config() context manager (#10698)
* minor lock scope reduction
* use the lock in tests
* Use the passed root_path in configure CLI command
* switch to lock_and_load_config()
* oops
* cleanup
* make _load_config_maybe_locked() private
* black
* Remove future improvement opportunity TODO comment
* move pytest.ini to the root directory (#10892)
* move pytest.ini to the root directory
* pytest.ini: testpaths = tests
https://docs.pytest.org/en/7.1.x/reference/reference.html?highlight=testpaths#confval-testpaths
* set CHIA_ROOT in tests instead of symlinking (#10682)
* attempt to checkout test-cache directly to desired location
* rebuild workflows
* maybe we can use CHIA_ROOT
* use CHIA_ROOT to find blocks and plots for tests
* oops
* more informational printing
* oops
* --capture no for debugging
* flake8
* import os
* undo some unrelated changes now covered elsewhere
* undo some debug changes
* rebuild workflows
* Remove sys.exit() from chia daemon /exit endpoint (#10454)
* asyncio.get_event_loop() is deprecated in 3.10, stop using it (mostly) (#10418)
* asyncio.get_event_loop() is deprecated in 3.10, stop using it
https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.get_event_loop
> Deprecated since version 3.10: Deprecation warning is emitted if there is no running event loop. In future Python releases, this function will be an alias of get_running_loop().
* black
* run tests in CI via coverage (#9704)
* Add coverage (without collection)
* Separate test_block_compression() to avoid coverage-related hangs
* Revert "Separate test_block_compression() to avoid coverage-related hangs"
This reverts commit ebad3d0017.
* multiprocessing.set_start_method("spawn")
* multiprocessing.set_start_method() in conftest.py
* hand hold cc wallet tests
* lint
* spawn for running chia as well
* handle already set start method case
* a bit more timeout for test_multiple_writers
* more timeout for test_writer_lock_blocked_by_readers
* 45 minute tieout for tests/pools/
* 45 minute tieout for tests/pools/
* some more hand holding sleeps
* report coverage in each workflow
only really useful to make sure it is capturing something
* oops
* complete the job name and the JOB_NAME
* better coverage result file names
* reset worker process titles
* rebuild workflows
* rebuild workflows
* black
* black
* rebuild workflows
* push timeouts
* actually include the updated workflows...
* push more workflow timeouts
* parallel=True
* rebuild workflows
* restrict click to < 8.1 for black (#10923)
https://github.com/pallets/click/issues/2225
Doing this instead of updating since updating black will change several
files due to some formatting change. I would like to take that on
separately from unbreaking CI.
* fixup workflow template merge env duplication (#10925)
* ignore lack of hinting on clvm_tools.binutils.assemble() (#10926)
* Contextualize some store test db names. (#10942)
* Type check values in RL Wallet (#10935)
* Use uint128 for wallet balances (#10936)
* Add more type checks to CAT Wallet (#10934)
* Bump actions/github-script from 4 to 6 (#10246)
* Bump actions/github-script from 4 to 6
Bumps [actions/github-script](https://github.com/actions/github-script) from 4 to 6.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](https://github.com/actions/github-script/compare/v4...v6)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update to github.rest.* for calls to API for compat w/ github-script@v5+
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
* Bump actions/setup-node from 2.4.1 to 3 (#10506)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.4.1 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v2.4.1...v3)
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump actions/cache from 2.1.6 to 3 (#10846)
* Bump actions/cache from 2.1.6 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2.1.6...v3)
---
updated-dependencies:
- dependency-name: actions/cache
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update actions in templates also
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
* Fix trailing bytes shown in CAT asset ID row when using `chia wallet show` (#10924)
* Truncate CAT asset_id output to 32 bytes. A wallet RPC change is needed
to properly separate out the asset ID from the TAIL program returned by
`get_all_wallet_info_entries()`
* Move the truncation to the assignment location
* Consolidate test fixtures (#10778)
* Rename confusing fixtures, especially ones with the same name but different implementation
* revert premature fixture rename: two_wallet_nodes_start_height_1
* Consolidate test fixtures
* Quick fix for improper v2 DB initialization when targeting testnet (#10952)
* bump timing threashold for mempool performance test (#10953)
* Ms.parallel pool t (#10966)
* Try parallel pool tests
* Also change workflow files
* Run less combinations
* Todo for bad test
* Try lower n
* run more tests in parallel on CI (#10960)
* run more tests in parallel on CI
* fix test_farmer_get_harvesters to wait for plots to be loaded before asking about them
* improve error message when a block is missing from the blockchain database (#10958)
* improve error message when a block is missing from the blockchain database
* Update chia/full_node/block_height_map.py
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Also throw DB error on double spending a coin (#10947)
* Throw error on double spending a coin
* Throw error on double spending a coin
* Improve test
* reorg fixes (#10943)
* when going through a reorg, maintain all chain state until the very end, when the new fork has been fully validated and added
* when rolling back the chain, also rollback the height-to-hash map
* add tests
* Fix the issues in main (failing tests) (#10977)
* Fix one of the issues in test_blockchain
* Only rollback after all async operations are finished
* back to a single option for workflow parallel config (#10979)
* limit test output on CI by dropping -s and -v. Also, only print the 10 slowest tests, instead of all (#10959)
* Ms.flaky gen speed (#10965)
* Flaky test sometimes goes slower than 1 second
* Add sleep to reduce flakiness
* Increase timeout instead of sleeping to hopefully reduce flakiness
* fix test_full_sync.py to only feed the blocks in the main chain to the node (#10974)
* Bump peter-evans/create-pull-request from 3 to 4 (#10950)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3 to 4.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/v3...v4)
---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* normalized_to_identity_cc_ip from get_consecutive_blocks was being passed in as overflow_cc_challenge in get_full_block_and_block_record (#10941)
* fix performance tests (#10983)
* Check for vulnerable openssl (#10988)
* Check for vulnerable openssl
* Update OpenSSL on MacOS
* First attempt - openssl Ubuntu 18.04 and 20.04
* place local/bin ahead in PATH
* specify install openssl
* correct path
* run ldconfig
* stop building and check for patched openssl
* spell sudo right by removing it
* Remove openssl building - 1st attempt RHs
* Test Windows OpenSSL version HT @AmineKhaldi
* Non Hobo patch the winstaller for CVE-2022-0778 (#10995)
* apt show not needed (#10997)
* install/upgrade openssl on Arch Linux also (#10999)
* Compile python 3.9.11 which is aware of the openssl issue (#11001)
* install.sh is not upgrading OpenSSL on MacOS (#11003)
* MacOS isn't updating OpenSSL in install.sh
* Exit if no brew on MacOS
* Code the if tree like a pro instead.
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* force index in get_coin_records_by_names (#10987)
* force index in get_coin_records_by_names
* fix lint
* Fix remaining linting issues (#10962)
* FIx remaining linting issues
* Revert type:ignore
* Revert token_bytes change
* streamable|pools: Fix `Optional` parsing in `dataclass_from_dict` (#10573)
* Test more `Optional` parsing in `dataclass_from_dict`
* Fix optional parsing in `dataclass_from_dict`
* Fix pool wallet / tests
* run_generator2 rust call and compact conditions data structure (#8862)
* use run_generator2 rust call and compact spend bundle conditions data structure pervasively.
* address review comments
* Faster full node tests (#10986)
* Start fast full node tests
* Perf improvement on send_transaction
* Major performance improvement for mempool test
* Speed up another test
* Speed up mempool tests startup
* Lint
* Debug tests
* Try function scope for wallet_nodes
* Update comment
* Force apt to install the things we asked it to (#11047)
* Force apt to install the things we asked it to
* Update .github/workflows/benchmarks.yml
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
* github: Drop unused `BUILD_VDF_CLIENT` variables (#11050)
From my understanding this is only used by `chiavdf` source builds which
happen only if `install-timelord.sh` gets called but it doesn't in the
addressed cases.
* bump up to 2.1.7 to fix inotify issue resolved by 848 (#11042)
* fix memory leak in test_full_sync (#11004)
* full_node: Drop unused `MempoolManager.constants_json` (#11046)
* simplify some header hash getting and assertions (#11007)
* Remove websockets dependency & do some refactoring (#10611)
* remove old ws
* Prepare test blocks and plots only for tests that need them. This saves us a couple more hours of CI running time. (#10975)
* Adding clean-workspace step to benchmarks (#11063)
* Checkout test blocks and plots for benchmarks workflow (#11068)
* Improve handling of unknown pending balances (likely change from addi… (#10984)
* Improve handling of unknown pending balances (likely change from adding a maker fee).
Minor improvement for fingerprint selection -- enter/return selects the logged-in fingerprint.
* Minor output formatting improvements when showing offer summaries.
Minor wallet key selection improvements.
Added tests for print_offer_summary
* Linter fixes
* isort fix
* Coroutine -> Awaitable
* Removed problematic fee calculation from get_pending_amounts per feedback.
* print average block rate at different block height windows (#11064)
* add -d for Install.ps1 (#11062)
* Set keychain_proxy to None in await_closed() to support reinitialization (#11075)
* Set keychain_proxy to None in await_closed() to support reinitialization.
* Added `shutting_down` param to _await_closed() to control whether the keychain_proxy is closed.
* Significantly speedup preparing test blocks and plots by opting for a release download instead of a shallow git clone, and also by putting a caching layer on top of that. (#11065)
* Bump github/super-linter from 4.9.1 to 4.9.2 (#11067)
Bumps [github/super-linter](https://github.com/github/super-linter) from 4.9.1 to 4.9.2.
- [Release notes](https://github.com/github/super-linter/releases)
- [Changelog](https://github.com/github/super-linter/blob/main/docs/release-process.md)
- [Commits](https://github.com/github/super-linter/compare/v4.9.1...v4.9.2)
---
updated-dependencies:
- dependency-name: github/super-linter
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove dead snakes usage from benchmark tests (#11053)
* Handle INSTALL_PYTHON_VERSION in Install.ps1, otherwise search 3.9/3.8/3.7 (#11034)
* Handle INSTALL_PYTHON_VERSION in Install.ps1, otherwise search 3.9/3.8/3.7
* fix python availability check in Install.ps1
* when Install.ps1 does not find an acceptable python, list supported versions in order
* Update Install.ps1
Co-authored-by: Matt Hauff <quexington@gmail.com>
Co-authored-by: Matt Hauff <quexington@gmail.com>
* wallet: Drop `puzzles/genesis_checkers.py` and related puzzles (#10790)
Its all duplicated code and puzzles as far as i can tell, see
`chia/wallet/puzzles/tails.py`.
* Bump cryptography from 3.4.7 to 36.0.2 (#10787)
Bumps [cryptography](https://github.com/pyca/cryptography) from 3.4.7 to 36.0.2.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/3.4.7...36.0.2)
---
updated-dependencies:
- dependency-name: cryptography
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* wallet: Improve logging in `create_more_puzzle_hashes` (#10761)
* wallet: Improve logging in `create_more_puzzle_hashes`
It's pretty spammy currently when scanning puzzle hashes.
* scan -> create, Scanning -> Creating
* `scanning_msg` -> `creating_msg`
* Add /cat_get_unacknowledged API for accessing unknown CATs (#10382)
* Add /cat_get_unacknowledged API for accessing unknown CATs
* Reformat & fix cast issue
* Integration tested & add unit test
* Handle optional uint32
* Reformat
* Reformat
* Reformat
* Merge PR 10308
* Reformat
* Fix concurrent issue
* Add state change notification
* rename API
* Fix failing tests
* Updated state_change name
Co-authored-by: Jeff Cruikshank <jeff@chia.net>
* Increases the probability of connecting to local trusted node (#10633)
* extend tests in test_blockchain to include more conditions, as well as ensuring consensus rules allow unknown condition parameters (#11079)
* chia|tests|github: Implement, integrate and test plot sync protocol (#9695)
* protocols|server: Define new harvester plot refreshing protocol messages
* protocols: Bump `protocol_version` to `0.0.34`
* tests: Introduce `setup_farmer_multi_harvester`
Allows to run a test setup with 1 farmer and mutiple harvesters.
* plotting: Add an initial plot loading indication to `PlotManager`
* plotting|tests: Don't add removed duplicates to `total_result.removed`
`PlotRefreshResult.removed` should only contain plots that were loaded
properly before they were removed. It shouldn't contain e.g. removed
duplicates or invalid plots since those are synced in an extra sync step
and not as diff but as whole list every time.
* harvester: Reset `PlotManager` on shutdown
* plot_sync: Implement plot sync protocol
* farmer|harvester: Integrate and enable plot sync
* tests: Implement tests for the plot sync protocol
* farmer|tests: Drop obsolete harvester caching code
* setup: Add `chia.plot_sync` to packages
* plot_sync: Type hints in `DeltaType`
* plot_sync: Drop parameters in `super()` calls
* plot_sync: Introduce `send_response` helper in `Receiver._process`
* plot_sync: Add some parentheses
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* plot_sync: Additional hint for a `Receiver.process_path_list` parameter
* plot_sync: Force named parameters in `Receiver.process_path_list`
* test: Fix fixtures after rebase
* tests: Fix sorting after rebase
* tests: Return type hint for `plot_sync_setup`
* tests: Rename `WSChiaConnection` and move it in the outer scope
* tests|plot_sync: More type hints
* tests: Rework some delta tests
* tests: Drop a `range` and iterate over the list directly
* tests: Use the proper flags to overwrite
* test: More missing duplicates tests
* tests: Drop `ExpectedResult.reset`
* tests: Reduce some asserts
* tests: Add messages to some `assert False` statements
* tests: Introduce `ErrorSimulation` enum in `test_sync_simulated.py`
* tests: Use `secrects` instead of `Crypto.Random`
* Fixes after rebase
* Import from `typing_extensions` to support python 3.7
* Drop task name to support python 3.7
* Introduce `Sender.syncing`, `Sender.connected` and a log about the task
* Add `tests/plot_sync/config.py`
* Align the multi harvester fixture with what we do in other places
* Update the workflows
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Add wallentx as additional assignee on mozilla CA update PRs (#11089)
* rebuild workflows (#11092)
* transition to using chia_rs module (#11094)
* Fix the case of claiming a large number of coins (#11038)
* Fix the case of claiming a large number of coins with a fee from a pool wallet
* Revert change to unrelated test
* Set PoolWallet.DEFAULT_MAX_CLAIM_SPENDS to 300
* A few review improvements
* Ms.fast test blockchain (#11051)
* more work on test blockchain
* Optimize test_blockchain.py
* Fix weight proof bug
* Rename variable
* first rc_sub_slot hash bug
* New plots
* try with a new ID
* Run without cache
* Address test blocks and plots preparation.
* Update constant in test_compact_protocol().
* Update this constant too.
* Revert accidental altering of the gui submodule in ae7e3295f280a591e76c4dffdea75fb74ea5de6f.
* Fix benchmark test
* Revert mozilla-ca change
* Rebase on main
Co-authored-by: almog <almogdepaz@gmail.com>
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
* can we get by without dead snakes? (#11070)
* can we get by without dead snakes?
* Update install-timelord.sh
* Revert "Update install-timelord.sh"
This reverts commit cba3250b09.
* do not install python dev package for timelords build in ci
it is already there...
* more quotes for sh
* Changelog from 1.3.3 (#11081)
* Updating changelog
* Update appdmg to 0.6.4 to work with macos 12.3 (#10886)
* restrict click to < 8.1 for black
https://github.com/pallets/click/issues/2225
Doing this instead of updating since updating black will change several
files due to some formatting change. I would like to take that on
separately from unbreaking CI.
* Check for vulnerable openssl (#10988)
* Check for vulnerable openssl
* Update OpenSSL on MacOS
* First attempt - openssl Ubuntu 18.04 and 20.04
* place local/bin ahead in PATH
* specify install openssl
* correct path
* run ldconfig
* stop building and check for patched openssl
* spell sudo right by removing it
* Remove openssl building - 1st attempt RHs
* Test Windows OpenSSL version HT @AmineKhaldi
* Get updated openssl version (#10991)
* Get updated openssl version
* Update pyinstaller
* Fix typo
* lets try this
* Let's try this
* Try this
Co-authored-by: Earle Lowe <e.lowe@chia.net>
* Gh 1.3.3v2 (#11011)
* Non Hobo patch the winstaller for CVE-2022-0778 (#10995)
* install.sh is not upgrading OpenSSL on MacOS (#11003)
* MacOS isn't updating OpenSSL in install.sh
* Exit if no brew on MacOS
* Code the if tree like a pro instead.
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Remove hobo patch
* apt show not needed (#10997)
* install/upgrade openssl on Arch Linux also
* Update CHANGELOG
* revert Arch change backport
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: wallentx <william.allentx@gmail.com>
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
Co-authored-by: Gene Hoffman <30377676+hoffmang9@users.noreply.github.com>
Co-authored-by: William Allen <wallentx@users.noreply.github.com>
Co-authored-by: Earle Lowe <e.lowe@chia.net>
* consistently name installer github actions artifact zips (#11096)
* git -C and consistent activation in installer builds (#11098)
* updated gui to d714c21b4e
* only check the version once in installer build workflows (#11099)
* updated gui to 5f8b23fc7d
* updated gui to fccbd3e10d
* streamable: Simplify and force correct usage (#10509)
* streamable: Merge `strictdataclass` into `Streamable` class
* tests: Test not supported streamable types
* streamable: Reorder decorators
* streamable: Simplify streamable decorator and force correct usage/syntax
* streamable: Just move some stuff around in the file
* streamable: Improve syntax error messages
* mypy: Drop `type_checking.py` and `test_type_checking.py` from exclusion
* streamable: Use cached fields instead of `__annotations__`
This is now possible after merging `__post_init__` into `Streamable`
* Introduce `DefinitionError` as `StreamableError`
* `/t` -> ` `
* Expose farm_block RPC for simulator (#10830)
* expose farm block api to RPC for simulator
* lint
* pre-commit lint
* Ms.plot load perf2 (#10978)
* 2.7 seconds -> 0.45 seconds
* Merge
* Work on create_plots refactor
* Try to fix tests
* Try to fix tests
* Use new functions
* Fix block_tools by adding dir
* Extra argument
* Try to fix cyclic import
* isort
* Drop warning
* Some cleanups around `exclude_final_dir` and directory adding
* Cleanup `min_mainnet_k_size` checks
* Drop unrelated changes
* Fixes after rebase
* Fix cyclic import
* Update tests/block_tools.py
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
* Update tests/block_tools.py
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
* rebase and more fixes (#10885)
* derivation from just a master public key (#11140)
* Add dependencies macos rhel chiavdf (#11142)
* Added steps, when building the chiavdf wheel for macos and rhel-based systems, to install cmake and/or gmp.
* updated gui to d5b75bcf7a
* Revert "derivation from just a master public key (#11140)" (#11143)
This reverts commit db536c615a.
* Mark the github workspace as safe (#11159)
* Mark the github workspace as safe
* Move the git config step after git is installed in the test containers
* updated gui to 81303fb962
* optimize wallet tool by not caching the puzzle_hash -> derivation index, but caching puzzle_hash -> secret key (which is the lookup we're actually interested in). This avoids duplicating the actual derivation (#11154)
* make listen port colissions in CI less likely (#11164)
* Use get latest release endpoint for plotters, so that we ignore any pre-releases that could be returned by listReleases (#11165)
* Build cli only version of debs (#11166)
* Build cli only version of debs
* Export the vars needed by j2
* Fix paths
* Add symlink to chia in /usr/local/bin/
* Upload the cli only debs to s3
* Add init.py
* Ensure SHA is on the dev build for amd64
* add tool to generate a blockchain with full blocks, as a benchmark (#11146)
* Simplify how the chia symlink is created in the CLI .deb (#11188)
* fix block_tools feature when specifying a list of block references. Also add feature keep_going_until_tx_block. (#11185)
* Fix filename of latest intel dev installer (#11203)
* Add start_crawler and start_seeder to pyinstaller config (#11205)
* Pin mac intel installer to 10.15 (#11209)
* Revert "Pin mac intel installer to 10.15 (#11209)" (#11210)
This reverts commit 93a61eece1.
* Adding changelog (#11223)
* Adding changelog (#11223)
Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: ChiaMineJP <admin@chiamine.jp>
Co-authored-by: Mariano Sorgente <3069354+mariano54@users.noreply.github.com>
Co-authored-by: David Barratt <davidbarratt@users.noreply.github.com>
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
Co-authored-by: Matt Hauff <quexington@gmail.com>
Co-authored-by: William Blanke <wjb98672@gmail.com>
Co-authored-by: Juraj Oršulić <juraj.orsulic@fer.hr>
Co-authored-by: Yostra <straya@chia.net>
Co-authored-by: Florin Chirica <fchirica96@gmail.com>
Co-authored-by: Richard Kiss <him@richardkiss.com>
Co-authored-by: William Allen <wallentx@users.noreply.github.com>
Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com>
Co-authored-by: Johannes Tysiak <vinyl@users.sf.net>
Co-authored-by: Don Kackman <dkackman@gmail.com>
Co-authored-by: austinsirkin <a.sirkin@chia.net>
Co-authored-by: Earle Lowe <30607889+emlowe@users.noreply.github.com>
Co-authored-by: Brandon Butler <b.butler@chia.net>
Co-authored-by: Dave <72020697+daverof@users.noreply.github.com>
Co-authored-by: Freddie Coleman <f.coleman@hotmail.co.uk>
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
Co-authored-by: arty <art.yerkes@gmail.com>
Co-authored-by: Francesco Truzzi <ftruzzi@users.noreply.github.com>
Co-authored-by: hugepants <hugepants@users.noreply.github.com>
Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
Co-authored-by: Gene Hoffman <30377676+hoffmang9@users.noreply.github.com>
Co-authored-by: roseiliend <90035993+roseiliend@users.noreply.github.com>
Co-authored-by: Kronus91 <ytx1991@gmail.com>
Co-authored-by: almog <almogdepaz@gmail.com>
Co-authored-by: wallentx <william.allentx@gmail.com>
Co-authored-by: Earle Lowe <e.lowe@chia.net>
Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Co-authored-by: Patrick Maslana <79757486+pmaslana@users.noreply.github.com>
* WIP commit for the new NFT spec
* Update to optimized singleton
* flesh out ownership layer
* nft_transfer_nft: (#11181)
* Introduce some error handling.
* The new_did_inner_hash and trade_price params should be optional for now.
* Add get_confirmed_balance(), get_unconfirmed_balance(), get_spendable_balance(), get_pending_change_balance() and get_max_send_amount() to NFTWallet. This fixes chia wallet show when NFTs are involved. (#11256)
* Needed for DID CLI: (#11268)
* RPC: Add /did_set_wallet_name and /did_get_wallet_name.
* DIDWallet: Add set_name() and get_name().
* Generalize the Offer class to more than CATs
* Remove CAT dependencies from trade_manager
* Fix offer RPC
* isort
* Further generalize the Offer drivers
* Update trade manager with new generalizations
* Fix offer RPC again
* Move outer_puzzles.py
* pivot from string to clvm for dict entries
* add test coverage for driver dict in RPC
* Remove some CAT specific stuff from tm
* Add comments explaining the changes
* Minor fixes
* isort and flake8
* More linting
* Include drivers in offer summary
* Better autodetection of drivers on offer creation
* Forgot to update rpc test
* checkpoint
* fix test and optimise state_layer puz
* rebuild workflows
* Pass Recovery Info in the Transfer case (#11249)
* Chialisp draft
* Modify python code
* Reformat & Fix tests
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* Handle recovery
* Chialisp draft
* Modify python code
* Reformat & Fix tests
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* add clvm files to recomp list
* fix rpc test
* flake8 fixes for tests
* flake 8 stupid fix
* Bug fix & flake8 fix for NFT tests
* Modify python code
* Chialisp draft
* Modify python code
* Bug fix & flake8 fix for NFT tests
* Generalize the message puzzle
* Add Pubkey as hint
* Receive DID
* Add DID APIs & Tests
* Fix tests
* Test fixes. in_transaction is now passed as a param to the various callers that eventually call save_info.
* Workflow Fix
* Add test config for DID/NFT
* Update workflow test yaml
* Fix install test script
* Fix typo
* Resolve comments
* Fix tests
* Change did_innerpuz and fix wallets for new design (#11196)
* correcting the design of did_innerpuz and related wallet changes
* remove breakpoint comments
* change decimal point accuracy of percentage system
* secure new_amount by fixing it to our current amount
* rename and update comments for new_amount - now my_amount
* rename P2_PUZZLE to simply INNER_PUZZLE
* fix variable re-declaration for flake/merge
* black and flake8 - inclduing wallet_state_manager bug fix
* update RPCs related to add_url
added commented out tests too, but DID needs fixing first
* Fix bugs in transfer case
* Fix pre-commit
* Fix install.sh test for bookworm
* Pass recovery info in the transfer case
* add clvm files to recomp list
* flake8 fixes for tests
* flake 8 stupid fix
* Modify python code
* Bug fix & flake8 fix for NFT tests
* Pass recovery info in the transfer case
* Fix tests
* Fix security issue of the recovery empty list
* Revert test code
* Allow assign fee when creating the wallet
* reformat
* Add option for pass recovery list
* DID wallet name generation & deduplication
* Fix test
* Remove file reading code
* Fix tests
Co-authored-by: matt <matt@chia.net>
Co-authored-by: Jeff Cruikshank <jeff@chia.net>
Co-authored-by: matt-o-how <48453825+matt-o-how@users.noreply.github.com>
Co-authored-by: ytx1991 <t.yu@chia.net>
* Bumping GUI to 447ac34942
* metadata checkpoint
* fix state layer for metadata updater
* add test for metadata updating
* removed second param for create_ann condition
* forgot to compile clvm
* compiled updated clvm sha256
* * Add fees support to DID wallet creation RPC client. (#11363)
* Initial iteration of the chia wallet did create command. (#11237)
* Add nft_get_nft_info API (#11351)
* Add nft_get_nft_info API
* Refine NFT uncurry code
* Resolve comments
* Resolve comments
Co-authored-by: ytx1991 <t.yu@chia.net>
* almost generates a new nft
* generating nfts
* rpc fix
* DID set wallet name RPC API: Ensure that the wallet type is a DID wallet before proceeding. (#11391)
* Initial iteration of the chia wallet did set_name command. (#11334)
* make NFTWallet a dataclass (#11139)
* make NFTWallet a dataclass
* isort
* flake8
* mypy
* Optional
* Implement nft transfer program
* Resolve comment
* transfer wip
* checkpoint
* basic rpc api working
* Fix data hash issue
* pre commit hooks passing, tests pass
* removed old NFT tests
* workflow files?
* Attempt to fix workflows.
* Workflows?
* Prepare test blocks and plots for NFT wallet tests.
* Reflect the previous commit into workflows.
* clvm compilation fix
* future proof create_coin in nft state layer
* Add RPC client support for the create_new_wallet API. (#11430)
* nft_get_nfts returns a nicer response
* get nfts rpc should now conform to old format
* checkpoint
* Fix tests
* Remove impossible case
* metadata updater working with latest puzzles
* removed unused method
* mypy fix
* Bumping GUI to df86eca99a
* added state change events in nft wallet (#11469)
* added state change events in nft wallet
* Attempt to fix workflows.
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
* Bumping GUI to b4d3eebfe3
* fix for clvm compilation fail
* made nft state layer more future proof
* Add `chia.wallet.nft_wallet` to packages in setup.py
* Initial iteration of the NFT0 chia wallet nft create command. (#11476)
* Add wallet RPC client support for the NFT0 nft_mint_nft API. (#11477)
* Automatically create NFT wallet (#11482)
* Create NFT Wallet if there is not a NFT wallet
* Fix pre-commit
* Remove unnecessary log
* fix to merge into main_dids
* Initial iteration of the NFT0 chia nft mint command.
* Initial iteration of the NFT0 chia wallet nft add_uri command.
* Initial iteration of the NFT0 chia wallet nft transfer command.
* Initial iteration of the NFT0 chia wallet nft list command.
* NFT0: Make the wallet ID required for adding a URI.
* Bumping GUI to 725d77abba
* NFT0: Make the wallet ID required for transferring an NFT.
* Add fee option for NFT & limit NFT wallet creation (#11492)
* Add fee option for NFT & limit NFT wallet creation
* Fix pre-commit
* Add fee for update metadata
* Add the ability to set fees for minting NFTs, transferring NFTs and adding URIs to NFTs.
* Fix handling fees on the RPC API side.
* fix for missing minted coins
* updating metadata with multiple uris fix
* Consolidate test_did_rpc.py into test_wallet_rpc.py and make the tests use the wallet RPC client. (#4)
* Update workflows and minor formatting.
* faster tests, other fixes
* potentially fixes the did test failure
Co-authored-by: matt <matt@chia.net>
Co-authored-by: Yostra <straya@chia.net>
Co-authored-by: matt-o-how <48453825+matt-o-how@users.noreply.github.com>
Co-authored-by: Jeff <jeff@chia.net>
Co-authored-by: Kronus91 <ytx1991@gmail.com>
Co-authored-by: ytx1991 <t.yu@chia.net>
Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: ChiaMineJP <admin@chiamine.jp>
Co-authored-by: Mariano Sorgente <3069354+mariano54@users.noreply.github.com>
Co-authored-by: David Barratt <davidbarratt@users.noreply.github.com>
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
Co-authored-by: Matt Hauff <quexington@gmail.com>
Co-authored-by: William Blanke <wjb98672@gmail.com>
Co-authored-by: Juraj Oršulić <juraj.orsulic@fer.hr>
Co-authored-by: Florin Chirica <fchirica96@gmail.com>
Co-authored-by: Richard Kiss <him@richardkiss.com>
Co-authored-by: William Allen <wallentx@users.noreply.github.com>
Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com>
Co-authored-by: Johannes Tysiak <vinyl@users.sf.net>
Co-authored-by: Don Kackman <dkackman@gmail.com>
Co-authored-by: austinsirkin <a.sirkin@chia.net>
Co-authored-by: Earle Lowe <30607889+emlowe@users.noreply.github.com>
Co-authored-by: Brandon Butler <b.butler@chia.net>
Co-authored-by: Dave <72020697+daverof@users.noreply.github.com>
Co-authored-by: Freddie Coleman <f.coleman@hotmail.co.uk>
Co-authored-by: arty <art.yerkes@gmail.com>
Co-authored-by: Francesco Truzzi <ftruzzi@users.noreply.github.com>
Co-authored-by: hugepants <hugepants@users.noreply.github.com>
Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
Co-authored-by: Gene Hoffman <30377676+hoffmang9@users.noreply.github.com>
Co-authored-by: roseiliend <90035993+roseiliend@users.noreply.github.com>
Co-authored-by: almog <almogdepaz@gmail.com>
Co-authored-by: wallentx <william.allentx@gmail.com>
Co-authored-by: Earle Lowe <e.lowe@chia.net>
Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Co-authored-by: Patrick Maslana <79757486+pmaslana@users.noreply.github.com>
Co-authored-by: Sebastjan <trepca@gmail.com>
Co-authored-by: Andreas Greimel <andreas@mintgarden.io>
* Resend transactions (#11167)
* Resend transactions
* Don't recheck transactions more frequently than timeout
* Add wallet resend parameter to config, move timeout code out of tx store, but close to call site
* Add a test for wallet transaction resend
* Add test for wallet retry
* isort new files for precommit and update workflows
* Use correct fixture name
* LGTM - remove unused import
Co-authored-by: Earle Lowe <e.lowe@chia.net>
* less except -> false (#10219)
* less except -> false
* establish_connection() and .perform_handshake() can just return None
* remove more pointless, and no wrong, assertions
* Write python version error to stderr (#11239)
Co-authored-by: wjblanke <wjb98672@gmail.com>
* simplify SizedBytes and StructStream (#11429)
* simplify SizedBytes and StructStream
* lint
* super() !!!
* do not pass parameter up to super().__init__()
* Update chia/util/struct_stream.py
Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
* parse fixed-width int data from class name
* add int512 and uint128 .from_bytes(), test .parse() failures
* test serialization against struct.pack()
* use typing_extensions for final
* override ignore
* stop using struct for StructStream
oh the irony
* fixup .to_bytes() to accept parameters again for where we use that
* bring back signed parameter
* format
* adjust tests for new exception
* eliminate custom coding for uint128 and int512
* tidy
* remove unused StructStream.PACK attribute
* add direct tests for parse_metadata_from_name()
* stricter hinting
* remove no-longer-needed typeshed work-around
* apply strict type checking to all touched files
* remove StructStream override of .to_bytes()
* tidy
* types touchup
* add unused parameter comments
Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
Co-authored-by: wjblanke <wjb98672@gmail.com>
* Allow services to set a non-default max request body size limit (#11516)
* updated bls to 13 (#11529)
* reduce the redundant computations of coin_ids in block_body_validation (#11530)
* add test for streamable -> json conversion (#11527)
* add test for streamable -> json conversion
* fixup test
* Uses the new `from_bytes_unchecked` method in blspy, to improve perfo… (#11463)
* Uses the new `from_bytes_unchecked` method in blspy, to improve performance
* Update test
* Fix merge conflict
* Use from_bytes_unchecked in post_init and from_json
* More uniform code
* rename test files that are missing test_ prefix (#10712)
* rename test files that are missing test_ prefix
* update mypy and isort excludes
* skip test_get_host_addr6() in GitHub Actions under macOS
* rebuild workflows
* Coin Selection Refactor With CAT Coin Selection Refactor (#9975)
* add exact match and best exact match algorithms
* optimize algorithm further
this might be good.
* lint
* fix bad logic
* add final algorithms
* delete lint
* oops
* Update coin_selection.py
* simplify and fix knapsack algoritm
* simplify code and correct logic
* make it way better.
* clarify comments and check for edge cases.
* add comments and stuff
* improve coin selection
addressed comments
Thanks!
* add coin_selection rpc tests.
* clean up and add new unit tests
* undo test changes
* add extra test cases
* move coin_selection to its own function and switch to it for cat and main wallet.
* add cat tests
* lint
* make function align with standards
also removed test
* make test better
* add proper types
* Improve code clarity
* wallet: fix coin selection bugs
* wallet: add an assert just in case
* tests: add some sleeps to reduce flakiness
* Isort
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* fix bad merge
* lint
* fix tests
* address aforementioned changes.
* remove wallet test
* isort
* more tests and fixes
* lint
* rename to amount for coin selection rpc
* fix incase we have no smaller coins
* fix tests + lint
* re add asserts
* oops
missed me.
* lint
* fix test
* Squashed commit of the following:
commit 34a2235de5
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Apr 13 10:09:42 2022 -0400
clarify comment
commit adbf7f4f94
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 20:27:05 2022 -0400
linty lint
commit 5ebc1ac9fd
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 20:17:19 2022 -0400
add failure test and final changes
commit 7e5a21b4c2
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 19:35:18 2022 -0400
add descriptions and slim down code
commit 31c95b916d
Merge: d7b91295bd9b0ef5f3
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Mon Apr 11 10:12:05 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit d7b91295b5
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Sun Apr 10 20:31:09 2022 -0400
lint
commit 30dc7c0ab4
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Sun Apr 10 20:25:52 2022 -0400
fix tests
commit 6c8c2e4874
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 15:06:00 2022 -0400
remove duplicate code.
commit 9f79b6f304
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 15:01:10 2022 -0400
address more concerns
commit 67c1b3929f
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 12:59:05 2022 -0400
fix logic error
commit 2d19a53245
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 11:47:52 2022 -0400
simplify and de duplicate code
commit 6ab1cc79bb
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 21:34:50 2022 -0400
add function and select individual coin
commit 582c17aa8d
Merge: ce2165942618fbaeba
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 21:14:37 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit ce21659429
Merge: 16aabb3fd6daba28db
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:53:21 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit 16aabb3fd5
Merge: 0b9fc28452286fe426
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:49:02 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit 0b9fc28455
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:38:12 2022 -0400
lint
commit 62e74c72f4
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:34:22 2022 -0400
fix logic and tests
commit e738f44320
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 18:52:05 2022 -0400
deal with dust and add tests
* make sure that we do not use any dust
* minor change
* address concerns
* adjust comments
* adjust comment
Co-authored-by: Mariano Sorgente <sorgente711@gmail.com>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* rebuild workflows (#11543)
* remove the cache from CoinStore. It appears the cost of maintaining the cache outweighs the gains. (#11540)
* Keep daemon websocket alive during keyring unlock (#11371)
* When prompting to unlock the keyring during daemon launch, it's possible
that the daemon websocket connection will timeout before the user has
entered their passphrase. We can't quickly detect that the connection
has timed-out, so instead we now reconnect after collecting the
passphrase, unlock the keyring, and then close the old connection.
* mypy fix
* Switch to using asyncio.loop.run_in_executor to collect the passphrase on its own thread.
* Use a new ThreadPoolExecutor configured with 1 worker thread.
* Support searching derived addresses on testnet. (#11449)
* Support searching derived addresses on testnet.
* Added tests
* Optimize code to not perform useless subgroup checks (#11546)
* Optimize code to not perform useless subgroup checks
* Revert less important optimizations
* hints and strict type checking for test_wallet (#11541)
* hints and strict type checking for test_wallet
* fixup
* flip flop
* disable pytest-monitor by default (#11507)
* disable pytest-monitor by default
* take 2
* make recurse_jsonify() work directly on types (#11537)
* make recurse_jsonify() work directly on types, circumventing the dataclasses.asdict() step. This enables simpler integration of non dataclasses into the Streamable and JSON protocols
* add benchmark for Streamable.to_json_dict()
* tests: Split up and improve `test_wallet_rpc.py` (#11552)
This breaks up the one big test into
```
test_send_transaction
test_create_signed_transaction
test_create_signed_transaction_with_coin_announcement
test_create_signed_transaction_with_puzzle_announcement
test_send_transaction_multi
test_get_transactions
test_get_transaction_count
test_cat_endpoints
test_offer_endpoints
test_key_and_address_endpoints
```
Note that there is still much more room for improvements. Also the
following tests can still be split up more:
```
test_get_transactions
test_cat_endpoints
test_offer_endpoints
test_key_and_address_endpoints
```
* Remove unneeded uint64() intermediate in CAT wallet (#11575)
* Get get_args() and get_origin() from typing_extensions (#11571)
* Get get_args() and get_origin() from typing_extensions
* Update streamable.py
* cleanup
* Fix several flaky tests (#11576)
* Increase some of the timeouts to reduce flakiness
* Experiment with CI for flakiness
* Force more runs
* Add argument name
* Fix flaky mempool test
* Attempt to fix another flaky test
* Fix wallet retry test
* Missing arg
* Lint
* Increase benchmark test time
* Debug
* Debug
* Simplify retry test
* Lint
* More lint
* Return false instead of assert
* No need to check disconnect twice (since we don't break, this was flaky)
* Remove useless changes
* Accidental changes revert
* Accidental changes revert 2
* Accidental changes revert 3
* Revert fixture
* Fix a few additional flaky tests (#11597)
* Fix a few additional flaky tests
* Lint
* Update tests/core/full_node/stores/test_full_node_store.py
Co-authored-by: Jeff <jeff@chia.net>
* Fix merge conflict
* Remove unnecessary function
Co-authored-by: Jeff <jeff@chia.net>
* Bind port 0 to fix race condition when grabbing available ports (#11578)
* port 0 to fix flakiness
* Try fixing setup_full_system
* Try fixing setup_full_system, and lint
* More attempts to fix
* No more calls to get random ports in setup_nodes
* Revert accidental changes
* Timelord extra arg
* Try with port 0
* Fix daemon test, and lint
* Try without 0.0.0.0
* Back to 0.0.0.0
* Try a few timelord changes to get test running
* Increase timeout again
* Use the correct interface to get the port
* INFO logging to debug issue
* Revert "INFO logging to debug issue"
This reverts commit 7c379e5cca.
* Fix advertised port log
* Add extra log
* Logging back
* Rollback the timelord changes
* Try port 0 timelord
* Revert "Try port 0 timelord"
This reverts commit 4997faf3b2.
* Try full green, change ordering
* Remove unused var
* speed up simulation and cleanup
* Now try without the port config
* Fix a flaky call to get_event_loop
* Try getting the port dynamically
* No dynamic port
* Try changing the ordering
* Try adding a sleep
* Back to what works
* Timelord before vdf clients
* Dynamic port for 1st timelord
* Revert "Dynamic port for 1st timelord"
This reverts commit 0f322a15b7.
* Revert "Timelord before vdf clients"
This reverts commit 3286c34696.
* Revert "Back to what works"
This reverts commit 30380dffb7.
* Revert "Try adding a sleep"
This reverts commit 9212b665a6.
* Revert "Try changing the ordering"
This reverts commit a62597d70d.
* Revert "No dynamic port"
This reverts commit 5d2e15749b.
* Revert "Try getting the port dynamically"
This reverts commit ef9cd75679.
* Revert "Fix a flaky call to get_event_loop"
This reverts commit 01a000fdfb.
* Try one to 0
* Just not 0
* Don't get port dynamically
* Cleanup a bit
* Fix
* Some cleanup work
* Some cleanup work
* Fix daemon test
* Cleanup
* Remove arguments
* restore missing hints being stored as None (instead of 0-length bytes) (#11568)
* Coin simplification (#11567)
* factor out as_list() from Coin into free function. Remove unused name_str() from Coin. Minor optimization of hash_coin_ids() for common case.
* extend Coin unit test
* test installer on fedora:36, drop 33
* add tests.util.misc.assert_maximum_duration for benchmark assertions (#11589)
* add tests.util.misc.assert_maximum_duration for benchmark assertions
* fix some imports
* more
* lint
* correct duration
* hint fixup
* rename to caller_file_and_line()
* set default timer to thread_time()
* extract gc manager and default to disabling
* self calibrate overhead
* wrap none-ness behind .results() method
* add messages
* from __future__ import annotations
* yield out self
* final from typing_extensions
* split it
* just use Future
* tweak
* tweak
* correction in loosely hint checked file
* all future indexing in hints
* union for the hints
* rename
* assert_runtime()
* another rename...
* message -> label
* label all results with test names
* oops
* early return from _set_spent function (#11594)
* check for removals before calling function
* move condition to function
* remove redundant condition (#11582)
* fix built-in profiler to work for mac (#11590)
* Bump actions/setup-python from 2 to 3 (#10949)
* Bump actions/setup-python from 2 to 3
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v2...v3)
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Fixup templates for python@v3
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
* avoid cancelling release/** and long_lived/** (#11519)
* tests: Some adjustments in `test_offer_endpoints` (#11558)
This is a follow up after #11552 which basically used the initial parts
of `test_cat_endpoints` to make `test_offer_endpoints` working. Now this
PR drops a lot of the stuff we can assume to be not needed in this test
because its tested in `test_cat_endpoints` and it adds some general
improvments to it.
* async sleep and require connection reset error for DoS test (#11612)
* fix jsonify bool
* Remove is not None and length assertion in select_coins() (#11569)
* Remove is not None and length assertion in select_coins()
The `coins is not None` check seems unneeded since `select_coins()` is hinted to return `Set[Coin]`. The length requirement needlessly restricts from being able to request a zero amount. Either situation would either trigger an exception in the next assert, or trigger the assert itself for non-zero amounts requested.
* also remove from cat_wallet.py
* new port 0 stuff
Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com>
Co-authored-by: Earle Lowe <e.lowe@chia.net>
Co-authored-by: Evan Graham <me@luakt.net>
Co-authored-by: wjblanke <wjb98672@gmail.com>
Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
Co-authored-by: Mariano Sorgente <3069354+mariano54@users.noreply.github.com>
Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
Co-authored-by: Mariano Sorgente <sorgente711@gmail.com>
Co-authored-by: Jeff <jeff@chia.net>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: neurosis69 <83925572+neurosis69@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gene Hoffman <hoffmang@hoffmang.com>
Co-authored-by: William Allen <wallentx@users.noreply.github.com>
This is a follow up after #11552 which basically used the initial parts
of `test_cat_endpoints` to make `test_offer_endpoints` working. Now this
PR drops a lot of the stuff we can assume to be not needed in this test
because its tested in `test_cat_endpoints` and it adds some general
improvments to it.
* port 0 to fix flakiness
* Try fixing setup_full_system
* Try fixing setup_full_system, and lint
* More attempts to fix
* No more calls to get random ports in setup_nodes
* Revert accidental changes
* Timelord extra arg
* Try with port 0
* Fix daemon test, and lint
* Try without 0.0.0.0
* Back to 0.0.0.0
* Try a few timelord changes to get test running
* Increase timeout again
* Use the correct interface to get the port
* INFO logging to debug issue
* Revert "INFO logging to debug issue"
This reverts commit 7c379e5cca.
* Fix advertised port log
* Add extra log
* Logging back
* Rollback the timelord changes
* Try port 0 timelord
* Revert "Try port 0 timelord"
This reverts commit 4997faf3b2.
* Try full green, change ordering
* Remove unused var
* speed up simulation and cleanup
* Now try without the port config
* Fix a flaky call to get_event_loop
* Try getting the port dynamically
* No dynamic port
* Try changing the ordering
* Try adding a sleep
* Back to what works
* Timelord before vdf clients
* Dynamic port for 1st timelord
* Revert "Dynamic port for 1st timelord"
This reverts commit 0f322a15b7.
* Revert "Timelord before vdf clients"
This reverts commit 3286c34696.
* Revert "Back to what works"
This reverts commit 30380dffb7.
* Revert "Try adding a sleep"
This reverts commit 9212b665a6.
* Revert "Try changing the ordering"
This reverts commit a62597d70d.
* Revert "No dynamic port"
This reverts commit 5d2e15749b.
* Revert "Try getting the port dynamically"
This reverts commit ef9cd75679.
* Revert "Fix a flaky call to get_event_loop"
This reverts commit 01a000fdfb.
* Try one to 0
* Just not 0
* Don't get port dynamically
* Cleanup a bit
* Fix
* Some cleanup work
* Some cleanup work
* Fix daemon test
* Cleanup
* Remove arguments
* Increase some of the timeouts to reduce flakiness
* Experiment with CI for flakiness
* Force more runs
* Add argument name
* Fix flaky mempool test
* Attempt to fix another flaky test
* Fix wallet retry test
* Missing arg
* Lint
* Increase benchmark test time
* Debug
* Debug
* Simplify retry test
* Lint
* More lint
* Return false instead of assert
* No need to check disconnect twice (since we don't break, this was flaky)
* Remove useless changes
* Accidental changes revert
* Accidental changes revert 2
* Accidental changes revert 3
* Revert fixture
This breaks up the one big test into
```
test_send_transaction
test_create_signed_transaction
test_create_signed_transaction_with_coin_announcement
test_create_signed_transaction_with_puzzle_announcement
test_send_transaction_multi
test_get_transactions
test_get_transaction_count
test_cat_endpoints
test_offer_endpoints
test_key_and_address_endpoints
```
Note that there is still much more room for improvements. Also the
following tests can still be split up more:
```
test_get_transactions
test_cat_endpoints
test_offer_endpoints
test_key_and_address_endpoints
```
* add exact match and best exact match algorithms
* optimize algorithm further
this might be good.
* lint
* fix bad logic
* add final algorithms
* delete lint
* oops
* Update coin_selection.py
* simplify and fix knapsack algoritm
* simplify code and correct logic
* make it way better.
* clarify comments and check for edge cases.
* add comments and stuff
* improve coin selection
addressed comments
Thanks!
* add coin_selection rpc tests.
* clean up and add new unit tests
* undo test changes
* add extra test cases
* move coin_selection to its own function and switch to it for cat and main wallet.
* add cat tests
* lint
* make function align with standards
also removed test
* make test better
* add proper types
* Improve code clarity
* wallet: fix coin selection bugs
* wallet: add an assert just in case
* tests: add some sleeps to reduce flakiness
* Isort
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* fix bad merge
* lint
* fix tests
* address aforementioned changes.
* remove wallet test
* isort
* more tests and fixes
* lint
* rename to amount for coin selection rpc
* fix incase we have no smaller coins
* fix tests + lint
* re add asserts
* oops
missed me.
* lint
* fix test
* Squashed commit of the following:
commit 34a2235de5
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Apr 13 10:09:42 2022 -0400
clarify comment
commit adbf7f4f94
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 20:27:05 2022 -0400
linty lint
commit 5ebc1ac9fd
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 20:17:19 2022 -0400
add failure test and final changes
commit 7e5a21b4c2
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Tue Apr 12 19:35:18 2022 -0400
add descriptions and slim down code
commit 31c95b916d
Merge: d7b91295bd9b0ef5f3
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Mon Apr 11 10:12:05 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit d7b91295b5
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Sun Apr 10 20:31:09 2022 -0400
lint
commit 30dc7c0ab4
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Sun Apr 10 20:25:52 2022 -0400
fix tests
commit 6c8c2e4874
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 15:06:00 2022 -0400
remove duplicate code.
commit 9f79b6f304
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 15:01:10 2022 -0400
address more concerns
commit 67c1b3929f
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 12:59:05 2022 -0400
fix logic error
commit 2d19a53245
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Thu Mar 31 11:47:52 2022 -0400
simplify and de duplicate code
commit 6ab1cc79bb
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 21:34:50 2022 -0400
add function and select individual coin
commit 582c17aa8d
Merge: ce2165942618fbaeba
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 21:14:37 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit ce21659429
Merge: 16aabb3fd6daba28db
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:53:21 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit 16aabb3fd5
Merge: 0b9fc28452286fe426
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:49:02 2022 -0400
Merge branch 'jack-cat-coinselection' into jn_coinselection_dust
commit 0b9fc28455
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:38:12 2022 -0400
lint
commit 62e74c72f4
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 20:34:22 2022 -0400
fix logic and tests
commit e738f44320
Author: Jack Nelson <jack@jacknelson.xyz>
Date: Wed Mar 30 18:52:05 2022 -0400
deal with dust and add tests
* make sure that we do not use any dust
* minor change
* address concerns
* adjust comments
* adjust comment
Co-authored-by: Mariano Sorgente <sorgente711@gmail.com>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
* Resend transactions
* Don't recheck transactions more frequently than timeout
* Add wallet resend parameter to config, move timeout code out of tx store, but close to call site
* Add a test for wallet transaction resend
* Add test for wallet retry
* isort new files for precommit and update workflows
* Use correct fixture name
* LGTM - remove unused import
Co-authored-by: Earle Lowe <e.lowe@chia.net>
* Move wallet RPC test setup into a fixture
* Fix `mypy` issues
* Enable `isort`
* Move `tx_in_mempool` out and reuse it instead of `tx_in_mempool_2`
* Introduce `get_confirmed_balance` and `get_unconfirmed_balance`
* Use `pytest.raises`
* Only test with an untrusted full node
* Introduce `generate_funds`
* Drop sleeps and create less blocks
* Recover trusted/untrusted sync parameterization
* Implement `test_cat_creation_unique_lineage_store()`
Make sure creating CAT wallets leads to unique lineage stores.
* Fix `CATLineageStore` creation in `create_new_cat_wallet`
We currently create the `CATLineageStore` before the new asset id exists
which leads to all CATs created by `create_new_cat_wallet` using the
same lineage store table:
`lineage_proofs_0000000000000000000000000000000000000000`.
* Create `CATLineageStore` in `generate_issuance_bundle`
* Rename confusing fixtures, especially ones with the same name but different implementation
* revert premature fixture rename: two_wallet_nodes_start_height_1
* Consolidate test fixtures
Matt Hauff
Kyle Altendorf
Amine Khaldi
xdustinface
dustinface
Mariano Sorgente
Jack Nelson
Adam Kelly
Arvid Norberg
Earle Lowe
Kronus91