c4c165eabd
* Remove valid # type: ignore
A user ran into an exception on this line that mypy should have caught. Let's see what it says.
```python-traceback
2021-05-06T07:31:41.595 full_node full_node_server : ERROR Exception , exception Stack: Traceback (most recent call last):
File "chia\server\server.py", line 356, in start_client
File "aiohttp\client.py", line 763, in _ws_connect
File "aiohttp\client.py", line 521, in _request
File "aiohttp\connector.py", line 535, in connect
File "aiohttp\connector.py", line 892, in _create_connection
File "aiohttp\connector.py", line 1032, in _create_direct_connection
File "aiohttp\connector.py", line 969, in _wrap_create_connection
File "asyncio\base_events.py", line 949, in create_connection
File "asyncio\selector_events.py", line 473, in sock_connect
concurrent.futures._base.CancelledError
2021-05-06T07:31:45.016 daemon asyncio : ERROR Task exception was never retrieved
future: <Task finished coro=<kill_service() done, defined at chia\daemon\server.py:833> exception=AttributeError("'list' object has no attribute 'pid'")>
Traceback (most recent call last):
File "chia\daemon\server.py", line 841, in kill_service
File "chia\daemon\server.py", line 805, in kill_process
AttributeError: 'list' object has no attribute 'pid'
2021-05-06T07:32:09.965 full_node full_node_server : ERROR Exception: <class 'concurrent.futures._base.CancelledError'>, closing connection None. Traceback (most recent call last):
File "chia\server\server.py", line 531, in api_call
File "asyncio\tasks.py", line 435, in wait_for
concurrent.futures._base.CancelledError
2021-05-06T07:33:20.573 full_node full_node_server : ERROR Exception , exception Stack: Traceback (most recent call last):
File "chia\server\server.py", line 356, in start_client
File "aiohttp\client.py", line 763, in _ws_connect
File "aiohttp\client.py", line 521, in _request
File "aiohttp\connector.py", line 535, in connect
File "aiohttp\connector.py", line 892, in _create_connection
File "aiohttp\connector.py", line 1032, in _create_direct_connection
File "aiohttp\connector.py", line 969, in _wrap_create_connection
```
* fix plotter service killing
* just make it always be a list of processes for all services
* catch up tests
* Update chia/daemon/server.py
|
||
|---|---|---|
| .. | ||
| blockchain | ||
| clvm | ||
| cmds | ||
| core | ||
| db | ||
| farmer_harvester | ||
| fee_estimation | ||
| generator | ||
| plot_sync | ||
| plotting | ||
| pools | ||
| simulation | ||
| tools | ||
| util | ||
| wallet | ||
| weight_proof | ||
| __init__.py | ||
| build-init-files.py | ||
| build-job-matrix.py | ||
| check_pytest_monitor_output.py | ||
| check_sql_statements.py | ||
| chia-start-sim | ||
| conftest.py | ||
| connection_utils.py | ||
| README.md | ||
| testconfig.py | ||
Test CI Job generation
The CI jobs for these tests are managed by build-workflows.py.
If you add a test file, or move one to another directory, please run build-workflows.py.
Tests are recognized by the file glob test_*.py.
Changing the contents of a file does not require running build-workflows.py.
We currently use github actions. Default runners have two vcpus. The workflows are located in ../.github/workflows/.
The inputs to build-workflows.py are the templates in runner-templates, the file testconfig.py in this directory, and the optional config.py files in some test subdirectories.
Files in the template directory ending in include.yml are included in jobs based on the per-directory settings.
The generated workflows are output to ../.github/workflows/.
Each subdirectory below the directories root_test_dirs in testconfig.py becomes a job in the github workflow matrix.
If your jobs run too long, simply move some tests into new subdirectories and run build-workflows.py.
A workflow built from a parent directory does not include the tests in its subdirectories.
The subdirectory jobs do not include the tests from their parents.
testconfig.py
In the top tests directory, testconfig.py contains the application settings and the per-directory default settings.
config.py
Each directory has an optional config.py file, which can override the per-directory default settings.
Per directory settings defaults:
parallel = False
checkout_blocks_and_plots = True
install_timelord = True
job_timeout = 30
Parallel test execution
If you are certain that all the tests in a directory can run in parallel, set parallel = True in config.py inside that directory.
Optional job stages
Set checkout_blocks_and_plots to False to omit checking out the test-cache repo.
Set install_timelord to False to omit the step of installing a Time Lord for your directory's job.
Job Timeout
Set job_timeout to the number of minutes you want the CI system to wait before it kills your job.
Add two or three minutes to allow for job setup.