Chocobozzz/PeerTube
1
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2024-09-11 13:37:10 +03:00
Code Issues Projects Releases Wiki Activity

Fix registering unamed settings

Browse Source
This commit is contained in:
Chocobozzz 2024-07-10 12:12:07 +02:00
parent 6d12f018cd
commit c5de5ef1d0
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/tests/fixtures/peertube-plugin-test/main.js vendored
View File

@ -19,6 +19,16 @@ async function register ({ registerHook, registerSetting, settingsManager, stora
]
})
registerSetting({
label: 'Unnamed 1',
type: 'input'
})
registerSetting({
label: 'Unnamed 2',
type: 'input'
})
const actionHooks = [
'action:application.listening',
'action:notifier.notification.created',

3
packages/tests/src/plugins/plugin-settings.ts
View File

@ -31,7 +31,8 @@ describe('Test plugin settings', function () {
npmName: 'peertube-plugin-test'
})
expect(registeredSettings.length).to.equal(1)
expect(registeredSettings.length).to.equal(3)
expect(registeredSettings.map(r => r.label)).to.have.members([ 'Unique setting', 'Unnamed 1', 'Unnamed 2' ])
})
it('Should return the latest registered settings', async function () {

3
server/core/lib/plugins/register-helpers.ts
View File

@ -204,7 +204,8 @@ export class RegisterHelpers {
private buildRegisterSetting () {
return (options: RegisterServerSettingOptions) => {
this.settings = [
...this.settings.filter((s) => s.name !== options.name),
...this.settings.filter(s => !s.name || s.name !== options.name),
options
]
}