1
1
mirror of https://github.com/Eugeny/tabby.git synced 2024-12-24 19:13:31 +03:00

Inform users about 16 color limit with WSL

This patch adds a warning that when using WSL we're limited to 16 colors. It took me about 4 hours debugging why it didn't work, and this patch hopefully prevents others from wasting 4 hours.
This commit is contained in:
Felicia Hummel 2018-12-05 00:38:19 +01:00
parent ca05c1b819
commit 1d593e0495
2 changed files with 8 additions and 0 deletions

View File

@ -14,6 +14,10 @@ h3.mb-3 Shell
[ngValue]='shell.id'
) {{shell.name}}
.alert.alert-info.d-flex.align-items-center(*ngIf='config.store.terminal.shell.startsWith("wsl")')
.mr-auto WSL terminal only supports 16 colors until ConPTY is implemented in node-pty
button.btn.btn-secondary((click)='openConPtyInfo()') More Information
.form-line(*ngIf='config.store.terminal.shell == "custom"')
.header
.title Custom shell

View File

@ -30,6 +30,10 @@ export class ShellSettingsTabComponent {
this.shells = (await Promise.all(this.config.enabledServices(this.shellProviders).map(x => x.provide()))).reduce((a, b) => a.concat(b))
}
openConPtyInfo() {
this.electron.shell.openExternal('https://github.com/Microsoft/node-pty/issues/216')
}
ngOnDestroy () {
this.configSubscription.unsubscribe()
}