From 3f160eee46ae14ce3d4154250731658a5f89ea1d Mon Sep 17 00:00:00 2001 From: Eugene Date: Fri, 1 Mar 2024 20:33:20 +0100 Subject: [PATCH] fixed duplicate multiline-paste prompts --- tabby-core/src/components/baseTab.component.ts | 1 - tabby-core/src/components/splitTab.component.ts | 2 +- tabby-core/src/services/tabs.service.ts | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tabby-core/src/components/baseTab.component.ts b/tabby-core/src/components/baseTab.component.ts index 26bea09f..908aa2b1 100644 --- a/tabby-core/src/components/baseTab.component.ts +++ b/tabby-core/src/components/baseTab.component.ts @@ -226,7 +226,6 @@ export abstract class BaseTabComponent extends BaseComponent { this.destroyed.next() } this.destroyed.complete() - this.hostView.destroy() } /** @hidden */ diff --git a/tabby-core/src/components/splitTab.component.ts b/tabby-core/src/components/splitTab.component.ts index 4ad78410..c190afbd 100644 --- a/tabby-core/src/components/splitTab.component.ts +++ b/tabby-core/src/components/splitTab.component.ts @@ -767,10 +767,10 @@ export class SplitTabComponent extends BaseTabComponent implements AfterViewInit } destroy (): void { - super.destroy() for (const x of this.getAllTabs()) { x.destroy() } + super.destroy() } layout (): void { diff --git a/tabby-core/src/services/tabs.service.ts b/tabby-core/src/services/tabs.service.ts index 30683be2..5e03a3d2 100644 --- a/tabby-core/src/services/tabs.service.ts +++ b/tabby-core/src/services/tabs.service.ts @@ -37,6 +37,7 @@ export class TabsService { const componentRef = componentFactory.create(this.injector) const tab = componentRef.instance tab.hostView = componentRef.hostView + tab.destroyed$.subscribe(() => componentRef.destroy()) Object.assign(tab, params.inputs ?? {}) return tab }