Eugeny/tabby
1
1
Fork 0
mirror of https://github.com/Eugeny/tabby.git synced 2024-12-23 10:32:29 +03:00
Code Issues Projects Releases Wiki Activity

lint & enabled linter on Azure pipelines

Browse Source
This commit is contained in:
Eugene Pankov 2019-07-24 11:24:57 +02:00
parent b6aa1f764b
commit dc9508f80d
13 changed files with 34 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.yml
View File

@ -31,6 +31,7 @@ rules:
'@typescript-eslint/promise-function-async': off
'@typescript-eslint/no-unnecessary-type-assertion': off
'@typescript-eslint/require-array-sort-compare': off
'@typescript-eslint/no-floating-promises': off
'@typescript-eslint/no-use-before-define':
- error
- classes: false

2
app/src/plugins.ts
View File

@ -176,7 +176,7 @@ export async function loadPlugins (foundPlugins: PluginInfo[], progress: Progres
pluginModule['bootstrap'] = packageModule.bootstrap
plugins.push(pluginModule)
console.timeEnd(label)
await (new Promise(x => setTimeout(x, 50)))
await new Promise(x => setTimeout(x, 50))
} catch (error) {
console.error(`Could not load ${foundPlugin.name}:`, error)
}

3
azure-pipelines.yml
View File

@ -86,6 +86,9 @@ jobs:
- script: yarn run build
displayName: 'Build'
- script: yarn run lint
displayName: 'Lint'
- script: node scripts/prepackage-plugins.js
displayName: 'Prepackage plugins'

4
terminus-core/src/components/appRoot.component.ts
View File

@ -128,8 +128,8 @@ export class AppRootComponent {
})
this.hostApp.windowCloseRequest$.subscribe(async () => {
await this.app.closeAllTabs() && this.hostApp.closeWindow();
});
await this.app.closeAllTabs() && this.hostApp.closeWindow()
})
if (window['safeModeReason']) {
ngbModal.open(SafeModeModalComponent)

4
terminus-core/src/components/tabHeader.component.ts
View File

@ -10,7 +10,7 @@ import { AppService } from '../services/app.service'
import { HostAppService, Platform } from '../services/hostApp.service'
/** @hidden */
export interface ISortableComponent {
export interface SortableComponentProxy {
setDragHandle (_: HTMLElement)
}
@ -34,7 +34,7 @@ export class TabHeaderComponent {
private hostApp: HostAppService,
private ngbModal: NgbModal,
private hotkeys: HotkeysService,
@Inject(SortableComponent) private parentDraggable: ISortableComponent,
@Inject(SortableComponent) private parentDraggable: SortableComponentProxy,
@Optional() @Inject(TabContextMenuItemProvider) protected contextMenuProviders: TabContextMenuItemProvider[],
) {
this.hotkeys.matchedHotkey.subscribe((hotkey) => {

6
terminus-core/src/services/app.service.ts
View File

@ -209,16 +209,16 @@ export class AppService {
/**
* Attempts to close all tabs, returns false if one of the tabs blocked closure
*/
async closeAllTabs () : Promise<boolean> {
async closeAllTabs (): Promise<boolean> {
for (const tab of this.tabs) {
if (!await tab.canClose()) {
return false;
return false
}
}
for (const tab of this.tabs) {
tab.destroy()
}
return true;
return true
}
/** @hidden */

4
terminus-core/src/services/config.service.ts
View File

@ -71,8 +71,8 @@ export class ConfigProxy {
}
}
getValue (_key: string): any { }
setValue (_key: string, _value: any) { }
getValue (_key: string): any { } // eslint-disable-line @typescript-eslint/no-empty-function
setValue (_key: string, _value: any) { } // eslint-disable-line @typescript-eslint/no-empty-function
}
@Injectable({ providedIn: 'root' })

12
terminus-core/src/services/docking.service.ts
View File

@ -30,8 +30,8 @@ export class DockingService {
}
const newBounds: Bounds = { x: 0, y: 0, width: 0, height: 0 }
const fill = this.config.store.appearance.dockFill <= 1 ? this.config.store.appearance.dockFill : 1;
const fill = this.config.store.appearance.dockFill <= 1 ? this.config.store.appearance.dockFill : 1
const [minWidth, minHeight] = this.hostApp.getWindow().getMinimumSize()
if (dockSide === 'left' || dockSide === 'right') {
@ -64,15 +64,15 @@ export class DockingService {
}
getScreens () {
const primaryDisplayID = this.electron.screen.getPrimaryDisplay().id;
return this.electron.screen.getAllDisplays().sort((a,b) => (
const primaryDisplayID = this.electron.screen.getPrimaryDisplay().id
return this.electron.screen.getAllDisplays().sort((a, b) =>
a.bounds.x === b.bounds.x ? a.bounds.y - b.bounds.y : a.bounds.x - b.bounds.x
)).map((display,index) => {
).map((display,index) => {
return {
id: display.id,
name: display.id === primaryDisplayID ? 'Primary Display' : `Display ${index +1}`,
}
});
})
}
private repositionWindow () {

13
terminus-core/src/services/updater.service.ts
View File

@ -29,7 +29,7 @@ export class UpdaterService {
this.autoUpdater = electron.remote.require('electron-updater').autoUpdater
this.autoUpdater.autoInstallOnAppQuit = !!config.store.enableAutomaticUpdates;
this.autoUpdater.autoInstallOnAppQuit = !!config.store.enableAutomaticUpdates
this.autoUpdater.on('update-available', () => {
this.logger.info('Update available')
@ -76,20 +76,19 @@ export class UpdaterService {
this.electron.shell.openExternal(this.updateURL)
} else {
if (process.platform === 'win32') {
let downloadpath = await this.autoUpdater.downloadUpdate();
let downloadpath = await this.autoUpdater.downloadUpdate()
fs.exists(downloadpath[0], (exists) => {
if (exists) {
fs.copyFile(downloadpath[0], os.tmpdir() + 'terminus-installer-temp.exe', (err) => {
if (!err) {
spawn(os.tmpdir() + 'terminus-installer-temp.exe', ['--force-run'], {detached: true, stdio: 'ignore'});
spawn(os.tmpdir() + 'terminus-installer-temp.exe', ['--force-run'], { detached: true, stdio: 'ignore' })
}
});
})
}
})
} else {
await this.downloaded;
this.autoUpdater.quitAndInstall(false, true);
await this.downloaded
this.autoUpdater.quitAndInstall(false, true)
}
}
}

8
terminus-settings/src/components/settingsTab.component.ts
View File

@ -70,12 +70,12 @@ export class SettingsTabComponent extends BaseTabComponent {
onConfigChange()
const onScreenChange = () => {
this.zone.run(() => this.screens = this.docking.getScreens());
this.zone.run(() => this.screens = this.docking.getScreens())
}
electron.screen.on('display-added', onScreenChange);
electron.screen.on('display-removed', onScreenChange);
electron.screen.on('display-metrics-changed', onScreenChange);
electron.screen.on('display-added', onScreenChange)
electron.screen.on('display-removed', onScreenChange)
electron.screen.on('display-metrics-changed', onScreenChange)
hotkeys.getHotkeyDescriptions().then(descriptions => {
this.hotkeyDescriptions = descriptions

2
terminus-ssh/src/services/ssh.service.ts
View File

@ -138,7 +138,7 @@ export class SSHService {
let agent: string = null
if (this.hostApp.platform === Platform.Windows) {
const pageantRunning = new Promise<boolean>(resolve => {
windowsProcessTreeNative.getProcessList(list => {
windowsProcessTreeNative.getProcessList(list => { // eslint-disable-line block-scoped-var
resolve(list.some(x => x.name === 'pageant.exe'))
}, 0)
})

4
terminus-terminal/src/api/baseTerminalTab.component.ts
View File

@ -15,7 +15,7 @@ import { TerminalContextMenuItemProvider } from './contextMenuProvider'
/** @hidden */
export interface IToastrService {
export interface ToastrServiceProxy {
info (_: string)
}
/**
@ -80,7 +80,7 @@ export class BaseTerminalTabComponent extends BaseTabComponent implements OnInit
protected sessions: SessionsService,
protected electron: ElectronService,
protected terminalContainersService: TerminalFrontendService,
@Inject(ToastrService) protected toastr: IToastrService,
@Inject(ToastrService) protected toastr: ToastrServiceProxy,
protected log: LogService,
@Optional() @Inject(TerminalDecorator) protected decorators: TerminalDecorator[],
@Optional() @Inject(TerminalContextMenuItemProvider) protected contextMenuProviders: TerminalContextMenuItemProvider[],

2
terminus-terminal/src/services/sessions.service.ts
View File

@ -284,7 +284,7 @@ export class Session extends BaseSession {
} catch (e) {
return null
}
let cwd = lines[(lines[1] === 'fcwd') ? 2 : 1].substring(1)
let cwd = lines[lines[1] === 'fcwd' ? 2 : 1].substring(1)
if (cwd.startsWith(catalinaDataVolumePrefix)) {
cwd = cwd.substring(catalinaDataVolumePrefix.length)
}