GaloisInc/cryptol
1
1
Fork 0
mirror of https://github.com/GaloisInc/cryptol.git synced 2024-09-11 14:06:13 +03:00
Code Issues Projects Releases Wiki Activity

Remove uses of bigNatSubUnsafe. This doesn't seem to make

Browse Source 
a difference for the obeserved crash.
This commit is contained in:
Rob Dockins 2021-07-14 22:55:37 -07:00
parent 889bfd6511
commit c69acab2a2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Cryptol/PrimeEC.hs
View File

@ -118,7 +118,10 @@ mod_mul p x y = (BN.bigNatMul x y) `BN.bigNatRem` (primeMod p)
-- | Compute the modular difference of two input values. The inputs are
-- required to be in reduced form, and will output a value in reduced form.
mod_sub :: PrimeModulus -> BigNat# -> BigNat# -> BigNat#
mod_sub p x y = mod_add p x (BN.bigNatSubUnsafe (primeMod p) y)
mod_sub p x y =
case BN.bigNatSub (primeMod p) y of
(# | y' #) -> mod_add p x y'
(# (# #) | #) -> x -- BOGUS!
-- | Compute the modular square of an input value @x@; that is, @x*x@.
-- The input is not required to be in reduced form, and the output
@ -201,7 +204,9 @@ ec_add p s t
-- cases for subtracting points which might be the identity.
ec_sub :: PrimeModulus -> ProjectivePoint -> ProjectivePoint -> ProjectivePoint
ec_sub p s t = ec_add p s u
where u = t{ py = BN.bigNatSubUnsafe (primeMod p) (py t) }
where u = case BN.bigNatSub (primeMod p) (py t) of
(# | y' #) -> t{ py = y' }
(# (# #) | #) -> panic "ec_sub" ["cooridnate not in reduced form!", show (bigNatToInteger (py t))]
{-# INLINE ec_sub #-}