macaw/x86/tests/x64/test-tail-call.exe.expected

R { funcs = [ (Addr 1 0x2c0, [(Addr 1 0x2c0, 7)])
            , (Addr 1 0x2d0, [(Addr 1 0x2d0, 11)])
            , (Addr 1 0x2e0, [(Addr 1 0x2e0, 11), (Addr 1 0x2eb, 16), (Addr 1 0x2fb, 1)])
            ]
  , ignoreBlocks = []
  }
Add test case for object jump table. 2018-07-21 04:16:52 +03:00			`R { funcs = [ (Addr 1 0x2c0, [(Addr 1 0x2c0, 7)])`
Add test-plt test case, and fix discovery to use trust symbols. 2018-12-04 11:04:23 +03:00			`, (Addr 1 0x2d0, [(Addr 1 0x2d0, 11)])`
Revisit handling of tail calls It turns out that we have to be more conservative with tail call identification, as incorrectly identifying a block as the target of a tail call (instead of a branch) can cause other branch classifiers to fail if that block is the target of another jump. Ultimately, we will need to give up some tail call recognition (since they are in general indistinguishable from jumps), and instead only identify known call targets as tail call candidates. With additional global analysis we could do better. Fixes #294 2022-06-24 23:52:42 +03:00			`, (Addr 1 0x2e0, [(Addr 1 0x2e0, 11), (Addr 1 0x2eb, 16), (Addr 1 0x2fb, 1)])`
Add test case for object jump table. 2018-07-21 04:16:52 +03:00			`]`
Fix tail call classification (#286) The tail call classifier came after the jump classifier, which was a problem because it is less strict than the tail call classifier, meaning it would always fire. This commit moves direct jump to be the last classifier applied, giving the others a chance. Includes a test case in the ARM backend. This requires some updates to some of the expected test results, as a few blocks are now classified as tail calls that were plain jumps before. They really could be considered either. I think it would be nice if these could be classified as jumps instead, but the reason they are flagged as tail calls is mostly down to the fact that their surrounding context is so simple that either interpretation works. Correcting this would require some heuristics based on additional analysis passes. The test harness for macaw symbolic required a few changes because the new detection of some jumps as tail calls introduces new calls into the symbolic test suites. However, the symbolic testing harness did not support calls before. Adding support required a bit of plumbing, including a more extensive code discovery pass. Fixes #285 2022-05-10 17:29:55 +03:00			`, ignoreBlocks = []`
Add test case for object jump table. 2018-07-21 04:16:52 +03:00			`}`