Make X86Stmt more generic to reuse code in reopt.

This commit is contained in:
Joe Hendrix 2017-10-02 17:02:00 -07:00
parent c77d1ac421
commit 1ebc6f247b
No known key found for this signature in database
GPG Key ID: 8DFA5FF784098C4F
2 changed files with 88 additions and 94 deletions

View File

@ -922,8 +922,11 @@ getLoc (l0 :: ImpLocation ids tp) =
-- TODO: Check tag register is assigned. -- TODO: Check tag register is assigned.
return $! ValueExpr e return $! ValueExpr e
addArchStmt :: X86Stmt (Value X86_64 ids) -> X86Generator st_s ids ()
addArchStmt s = addStmt $ ExecArchStmt (X86Stmt s)
addWriteLoc :: X86PrimLoc tp -> Value X86_64 ids tp -> X86Generator st_s ids () addWriteLoc :: X86PrimLoc tp -> Value X86_64 ids tp -> X86Generator st_s ids ()
addWriteLoc l v = addStmt $ ExecArchStmt $ WriteLoc l v addWriteLoc l v = addArchStmt $ WriteLoc l v
-- | Assign a value to a location -- | Assign a value to a location
setLoc :: forall ids st_s tp setLoc :: forall ids st_s tp
@ -1029,7 +1032,7 @@ instance S.Semantics (X86Generator st_s ids) where
src_v <- eval src src_v <- eval src
dest_v <- eval dest dest_v <- eval dest
is_reverse_v <- eval is_reverse is_reverse_v <- eval is_reverse
addStmt $ ExecArchStmt $ MemCopy val_sz count_v src_v dest_v is_reverse_v addArchStmt $ MemCopy val_sz count_v src_v dest_v is_reverse_v
memcmp sz count src dest is_reverse = do memcmp sz count src dest is_reverse = do
count_v <- eval count count_v <- eval count
@ -1044,7 +1047,7 @@ instance S.Semantics (X86Generator st_s ids) where
val_v <- eval val val_v <- eval val
dest_v <- eval dest dest_v <- eval dest
df_v <- eval dfl df_v <- eval dfl
addStmt $ ExecArchStmt $ MemSet count_v val_v dest_v df_v addArchStmt $ MemSet count_v val_v dest_v df_v
rep_scas True is_reverse sz val buf count = do rep_scas True is_reverse sz val buf count = do
val_v <- eval val val_v <- eval val
@ -1093,7 +1096,7 @@ instance S.Semantics (X86Generator st_s ids) where
fnstcw addr = do fnstcw addr = do
addr_val <- eval addr addr_val <- eval addr
addStmt $ ExecArchStmt $ StoreX87Control addr_val addArchStmt $ StoreX87Control addr_val
pshufb w x y = do pshufb w x y = do
x_val <- eval x x_val <- eval x
@ -1454,7 +1457,7 @@ addValueListDemands = mapM_ (viewSome addValueDemands)
x86DemandContext :: DemandContext X86_64 ids x86DemandContext :: DemandContext X86_64 ids
x86DemandContext = x86DemandContext =
DemandContext { addArchStmtDemands = addValueListDemands . valuesInX86Stmt DemandContext { addArchStmtDemands = addValueListDemands . valuesInX86Stmt
, addArchFnDemands = addValueListDemands . valuesInX86Fn , addArchFnDemands = addValueListDemands . foldMapFC (\v -> [Some v])
, archFnHasSideEffects = x86PrimFnHasSideEffects , archFnHasSideEffects = x86PrimFnHasSideEffects
} }

View File

@ -15,10 +15,11 @@ module Data.Macaw.X86.ArchTypes
( -- * Architecture ( -- * Architecture
X86_64 X86_64
, X86PrimFn(..) , X86PrimFn(..)
, valuesInX86Fn
, rewriteX86PrimFn , rewriteX86PrimFn
, x86PrimFnHasSideEffects , x86PrimFnHasSideEffects
, X86ArchStmt(..)
, X86Stmt(..) , X86Stmt(..)
, ppX86Stmt
, valuesInX86Stmt , valuesInX86Stmt
, rewriteX86Stmt , rewriteX86Stmt
, X86TermStmt(..) , X86TermStmt(..)
@ -30,6 +31,7 @@ import Data.Bits
import Data.Foldable import Data.Foldable
import Data.Parameterized.NatRepr import Data.Parameterized.NatRepr
import Data.Parameterized.Some import Data.Parameterized.Some
import Data.Parameterized.TraversableF
import Data.Parameterized.TraversableFC import Data.Parameterized.TraversableFC
import Data.Set (Set) import Data.Set (Set)
import qualified Data.Set as Set import qualified Data.Set as Set
@ -56,21 +58,6 @@ data X86TermStmt ids = X86Syscall
instance PrettyF X86TermStmt where instance PrettyF X86TermStmt where
prettyF X86Syscall = text "x86_syscall" prettyF X86Syscall = text "x86_syscall"
rewriteX86TermStmt :: X86TermStmt src -> Rewriter X86_64 src tgt (X86TermStmt tgt)
rewriteX86TermStmt f =
case f of
X86Syscall -> pure X86Syscall
------------------------------------------------------------------------
-- X86_64 specific declarations
data X86_64
type instance ArchReg X86_64 = X86Reg
type instance ArchFn X86_64 = X86PrimFn
type instance ArchStmt X86_64 = X86Stmt
type instance ArchTermStmt X86_64 = X86TermStmt
------------------------------------------------------------------------ ------------------------------------------------------------------------
-- X86PrimLoc -- X86PrimLoc
@ -261,19 +248,6 @@ instance IsArchFn X86PrimFn where
X86Rem w n d -> sexprA "rem" [ pure (text $ show $ typeWidth $ repValSizeMemRepr w), pp n, pp d ] X86Rem w n d -> sexprA "rem" [ pure (text $ show $ typeWidth $ repValSizeMemRepr w), pp n, pp d ]
rewriteX86PrimFn :: X86PrimFn (Value X86_64 src) tp
-> Rewriter X86_64 src tgt (Value X86_64 tgt tp)
rewriteX86PrimFn f =
case f of
MMXExtend e -> do
tgtExpr <- rewriteValue e
case tgtExpr of
BVValue _ i -> do
pure $ BVValue (knownNat :: NatRepr 80) $ 0xffff `shiftL` 64 .|. i
_ -> evalRewrittenArchFn (MMXExtend tgtExpr)
_ -> do
evalRewrittenArchFn =<< traverseFC rewriteValue f
-- | This returns true if evaluating the primitive function implicitly -- | This returns true if evaluating the primitive function implicitly
-- changes the processor state in some way. -- changes the processor state in some way.
x86PrimFnHasSideEffects :: X86PrimFn f tp -> Bool x86PrimFnHasSideEffects :: X86PrimFn f tp -> Bool
@ -294,23 +268,20 @@ x86PrimFnHasSideEffects f =
X86Div{} -> True -- /\ .. X86Div{} -> True -- /\ ..
X86Rem{} -> True -- /\ .. X86Rem{} -> True -- /\ ..
valuesInX86Fn :: X86PrimFn v tp -> [Some v]
valuesInX86Fn = foldMapFC (\v -> [Some v])
------------------------------------------------------------------------ ------------------------------------------------------------------------
-- X86Stmt -- X86Stmt
-- | An X86 specific statement. -- | An X86 specific statement.
data X86Stmt ids data X86Stmt (v :: Type -> *)
= forall tp . = forall tp .
WriteLoc !(X86PrimLoc tp) !(Value X86_64 ids tp) WriteLoc !(X86PrimLoc tp) !(v tp)
| StoreX87Control !(BVValue X86_64 ids 64) | StoreX87Control !(v (BVType 64))
-- ^ Store the X87 control register in the given location. -- ^ Store the X87 control register in the given location.
| MemCopy !Integer | MemCopy !Integer
!(Value X86_64 ids (BVType 64)) !(v (BVType 64))
!(Value X86_64 ids (BVType 64)) !(v (BVType 64))
!(Value X86_64 ids (BVType 64)) !(v (BVType 64))
!(Value X86_64 ids BoolType) !(v BoolType)
-- ^ Copy a region of memory from a source buffer to a destination buffer. -- ^ Copy a region of memory from a source buffer to a destination buffer.
-- --
-- In an expression @MemCopy bc v src dest dir@ -- In an expression @MemCopy bc v src dest dir@
@ -322,63 +293,83 @@ data X86Stmt ids
-- * 'True' means we should decrement buffer pointers after each copy. -- * 'True' means we should decrement buffer pointers after each copy.
-- * 'False' means we should increment the buffer pointers after each copy. -- * 'False' means we should increment the buffer pointers after each copy.
| forall n . | forall n .
MemSet !(Value X86_64 ids (BVType 64)) MemSet !(v (BVType 64))
-- /\ Number of values to assign -- /\ Number of values to assign
!(Value X86_64 ids (BVType n)) !(v (BVType n))
-- /\ Value to assign -- /\ Value to assign
!(Value X86_64 ids (BVType 64)) !(v (BVType 64))
-- /\ Address to start assigning from. -- /\ Address to start assigning from.
!(Value X86_64 ids BoolType) !(v BoolType)
-- /\ Direction flag -- /\ Direction flag
instance PrettyF X86Stmt where instance FunctorF X86Stmt where
prettyF (WriteLoc loc rhs) = pretty loc <+> text ":=" <+> ppValue 0 rhs fmapF = fmapFDefault
prettyF (StoreX87Control addr) = pretty addr <+> text ":= x87_control"
prettyF (MemCopy sz cnt src dest rev) = instance FoldableF X86Stmt where
foldMapF = foldMapFDefault
instance TraversableF X86Stmt where
traverseF go stmt =
case stmt of
WriteLoc loc v -> WriteLoc loc <$> go v
StoreX87Control v -> StoreX87Control <$> go v
MemCopy bc v src dest dir -> MemCopy bc <$> go v <*> go src <*> go dest <*> go dir
MemSet v src dest dir -> MemSet <$> go v <*> go src <*> go dest <*> go dir
ppX86Stmt :: (forall tp . f tp -> Doc) -> X86Stmt f -> Doc
ppX86Stmt pp stmt =
case stmt of
WriteLoc loc rhs -> pretty loc <+> text ":=" <+> pp rhs
StoreX87Control addr -> pp addr <+> text ":= x87_control"
MemCopy sz cnt src dest rev ->
text "memcopy" <+> parens (hcat $ punctuate comma args) text "memcopy" <+> parens (hcat $ punctuate comma args)
where args = [pretty sz, pretty cnt, pretty src, pretty dest, pretty rev] where args = [pretty sz, pp cnt, pp src, pp dest, pp rev]
prettyF (MemSet cnt val dest d) = MemSet cnt val dest d ->
text "memset" <+> parens (hcat $ punctuate comma args) text "memset" <+> parens (hcat $ punctuate comma args)
where args = [pretty cnt, pretty val, pretty dest, pretty d] where args = [pp cnt, pp val, pp dest, pp d]
rewriteX86Stmt :: X86Stmt src -> Rewriter X86_64 src tgt () ------------------------------------------------------------------------
rewriteX86Stmt f = -- X86_64
newtype X86ArchStmt ids = X86Stmt (X86Stmt (Value X86_64 ids))
data X86_64
type instance ArchReg X86_64 = X86Reg
type instance ArchFn X86_64 = X86PrimFn
type instance ArchStmt X86_64 = X86ArchStmt
type instance ArchTermStmt X86_64 = X86TermStmt
rewriteX86PrimFn :: X86PrimFn (Value X86_64 src) tp
-> Rewriter X86_64 src tgt (Value X86_64 tgt tp)
rewriteX86PrimFn f =
case f of case f of
WriteLoc loc rhs -> do MMXExtend e -> do
tgtStmt <- tgtExpr <- rewriteValue e
WriteLoc loc case tgtExpr of
<$> rewriteValue rhs BVValue _ i -> do
appendRewrittenArchStmt tgtStmt pure $ BVValue (knownNat :: NatRepr 80) $ 0xffff `shiftL` 64 .|. i
StoreX87Control addr -> do _ -> evalRewrittenArchFn (MMXExtend tgtExpr)
tgtStmt <- _ -> do
StoreX87Control evalRewrittenArchFn =<< traverseFC rewriteValue f
<$> rewriteValue addr
appendRewrittenArchStmt tgtStmt
MemCopy bc cnt src dest dir -> do
tgtStmt <-
MemCopy bc
<$> rewriteValue cnt
<*> rewriteValue src
<*> rewriteValue dest
<*> rewriteValue dir
appendRewrittenArchStmt tgtStmt
MemSet cnt val dest dir -> do
tgtStmt <-
MemSet
<$> rewriteValue cnt
<*> rewriteValue val
<*> rewriteValue dest
<*> rewriteValue dir
appendRewrittenArchStmt tgtStmt
valuesInX86Stmt :: X86Stmt ids -> [Some (Value X86_64 ids)] instance PrettyF X86ArchStmt where
valuesInX86Stmt (WriteLoc _ rhs) = [Some rhs] prettyF (X86Stmt s) = ppX86Stmt pretty s
valuesInX86Stmt (StoreX87Control addr) = [Some addr]
valuesInX86Stmt (MemCopy _ cnt src dest d) = [ Some cnt, Some src, Some dest, Some d ]
valuesInX86Stmt (MemSet cnt val dest d) = [ Some cnt, Some val, Some dest, Some d ]
refsInX86Stmt :: X86Stmt ids -> Set (Some (AssignId ids)) valuesInX86Stmt :: X86ArchStmt ids -> [Some (Value X86_64 ids)]
refsInX86Stmt = assignIdSetFromValues . valuesInX86Stmt valuesInX86Stmt (X86Stmt s) = foldMapF (\v -> [Some v]) s
instance StmtHasRefs X86Stmt where instance StmtHasRefs X86ArchStmt where
refsInStmt = refsInX86Stmt refsInStmt = assignIdSetFromValues . valuesInX86Stmt
rewriteX86Stmt :: X86ArchStmt src -> Rewriter X86_64 src tgt ()
rewriteX86Stmt (X86Stmt f) = do
s <- traverseF rewriteValue f
appendRewrittenArchStmt (X86Stmt s)
rewriteX86TermStmt :: X86TermStmt src -> Rewriter X86_64 src tgt (X86TermStmt tgt)
rewriteX86TermStmt f =
case f of
X86Syscall -> pure X86Syscall