git.iko.soy/Idris-dev
on 3dfa841 help sign in
Idris-dev/CONTRIBUTING.md
117 lines 5.2 kB history raw
1# Contributing to Idris-Dev
3The Idris Community welcomes pull requests, bug reporting, and bug squashing!
4However, we cannot do it all ourself, and want to make it as easy as possible to contribute changes to get things working.
5Here are a few guidelines that we would like contributors to follow so that we can have a chance of keeping on top of things.
7## Getting Started
91. Make sure you are familiar with [Git](http://git-scm.com/book).
101. Make sure you have a [GitHub account](https://github.com/signup/free).
111. Make sure you are familiar with: [Idris](http://eb.host.cs.st-andrews.ac.uk/writings/idris-tutorial.pdf).
121. Make sure you can install `Idris`:
13 * [Mac OS X](https://github.com/idris-lang/Idris-dev/wiki/Idris-on-OS-X-using-Homebrew)
14 * [Ubuntu](https://github.com/idris-lang/Idris-dev/wiki/Idris-on-Ubuntu)
15 * [Debian](https://github.com/idris-lang/Idris-dev/wiki/Idris-on-Debian)
16 * [Windows](https://github.com/idris-lang/Idris-dev/wiki/Idris-on-Windows)
18# Issue Reporting
20Before you report an issue, or wish to add cool functionality please try and check to see if there are existing [issues](https://github.com/idris-lang/Idris-dev/issues) and [pull requests](https://github.com/idris-lang/Idris-dev/pulls).
21We do not want you wasting your time, duplicating somebody's work!
23## The Campsite Rule
25A basic rule when contributing to Idris is the **campsite rule**: leave the codebase in better condition than you found it.
26Please clean up any messes that you find, and don't leave behind new messes for the next contributor.
28## Making Changes
30Idris developers and hackers try to adhere to something similar to the [successful git branching model](http://nvie.com/posts/a-successful-git-branching-model/).
31The steps are straightforward.
33For those new to the project:
351. Fork the `idris-dev` repo e.g.
37 $ git clone git@github.com/<your github user name>/Idris-dev.git
38 $ git remote add upstream git@github.com:idris-lang/Idris-dev.git
40For those already contributing to the project:
421. Ensure your existing clone is up-to-date with current HEAD e.g.
44 $ git fetch upstream
45 $ git merge upstream/master
47The remaining steps are the same:
491. Create, and checkout onto, a topic branch on which to base you work.
50 * This is typically the master branch.
51 * For your own sanity, please avoid working on the `master` branch.
53 $ git branch fix/master/my_contrib master
54 $ git checkout fix/master/my_contrib
561. Make commits of logical units.
571. Check for unnecessary whitespace with
59 $ git diff --check
611. Make sure your commit messages are along the lines of:
63 Short (50 chars or less) summary of changes
65 More detailed explanatory text, if necessary. Wrap it to about 72
66 characters or so. In some contexts, the first line is treated as the
67 subject of an email and the rest of the text as the body. The blank
68 line separating the summary from the body is critical (unless you omit
69 the body entirely); tools like rebase can get confused if you run the
70 two together.
72 Further paragraphs come after blank lines.
74 - Bullet points are okay, too
76 - Typically a hyphen or asterisk is used for the bullet, preceded by a
77 single space, with blank lines in between, but conventions vary here
791. Make sure you have added any necessary tests for your changes.
801. Run all the tests to assure nothing else was accidentally broken.
82 $ make test
841. Push your changes to a topic branch in your fork of the repository.
86 $ git push origin fix/master/my_contrib
881. Go to GitHub and submit a pull request to `idris-dev`
90From there you will have to wait on one of the `idris-dev` committers to respond to the request.
91This response might be an accept or some changes/improvements/alternatives will be suggest.
92We do not guarantee that all requests will be accepted.
94## Increases chances of acceptance.
96To help increase the chance of your pull request being accepted:
981. Run the tests.
991. Update the documentation, the surrounding one, examples elsewhere, guides, whatever is affected by your contribution
1001. Use appropriate code formatting for both `Idris` and `Haskell`.
102## Additional Resources
104* [Idris Wiki](https://github.com/idris-lang/Idris-dev/wiki);
105* [Zen Of Idris](https://github.com/idris-lang/Idris-dev/wiki/The-Zen-of-Idris);
106* Idris FAQs: [Official](http://www.idris-lang.org/documentation/faq/); [Unofficial](https://github.com/idris-lang/Idris-dev/wiki/Unofficial-FAQ);
107* [Idris Manual](https://github.com/idris-lang/Idris-dev/wiki/Manual);
108* [Idris Tutorial](http://eb.host.cs.st-andrews.ac.uk/writings/idris-tutorial.pdf);
109* [Idris News](http://www.idris-lang.org/news/);
110* [other Idris docs](http://www.idris-lang.org/documentation/).
111* [Using Pull Requests](https://help.github.com/articles/using-pull-requests)
112* [General GitHub Documentation](https://help.github.com/).
115Adapted from the most excellent contributing files from the [Puppet project](https://github.com/puppetlabs/puppet) and [Factroy Girl Rails](https://github.com/thoughtbot/factory_girl_rails/blob/master/CONTRIBUTING.md)