on master help sign in
Call gcc using rawSystem
27d6b04Melvar Chen
main/Main.hs+2−2
@@ -81,7 +81,7 @@ showver = do putStrLn $ "Idris version " ++ ver
81
81
82showLibs :: IO b
82showLibs :: IO b
83showLibs = do libFlags <- getLibFlags
83showLibs = do libFlags <- getLibFlags
84− putStrLn libFlags
84+ putStrLn $ unwords libFlags
85 exitWith ExitSuccess
85 exitWith ExitSuccess
86
86
87showLibdir :: IO b
87showLibdir :: IO b
@@ -91,5 +91,5 @@ showLibdir = do dir <- getIdrisLibDir
91
91
92showIncs :: IO b
92showIncs :: IO b
93showIncs = do incFlags <- getIncFlags
93showIncs = do incFlags <- getIncFlags
94− putStrLn incFlags
94+ putStrLn $ unwords incFlags
95 exitWith ExitSuccess
95 exitWith ExitSuccess
src/IRTS/CodegenC.hs+24−27
@@ -24,24 +24,22 @@ codegenC ci = codegenC' (simpleDecls ci)
24 (outputFile ci)
24 (outputFile ci)
25 (outputType ci)
25 (outputType ci)
26 (includes ci)
26 (includes ci)
27− (concatMap mkObj (compileObjs ci))
27+ (compileObjs ci)
28− (concatMap mkLib (compileLibs ci) ++
28+ (map mkLib (compileLibs ci) ++
29− concatMap incdir (importDirs ci))
29+ map incdir (importDirs ci))
30− (concatMap mkFlag (compilerFlags ci))
30+ (compilerFlags ci)
31 (debugLevel ci)
31 (debugLevel ci)
32
32
33− where mkObj f = f ++ " "
34− mkLib l = "-l" ++ l ++ " "
33+ where mkLib l = "-l" ++ l
35− mkFlag l = l ++ " "
36− incdir i = "-I" ++ i ++ " "
34+ incdir i = "-I" ++ i
37
35
38codegenC' :: [(Name, SDecl)] ->
36codegenC' :: [(Name, SDecl)] ->
39 String -> -- output file name
37 String -> -- output file name
40 OutputType -> -- generate executable if True, only .o if False
38 OutputType -> -- generate executable if True, only .o if False
41 [FilePath] -> -- include files
39 [FilePath] -> -- include files
42− String -> -- extra object files
40+ [String] -> -- extra object files
43− String -> -- extra compiler flags (libraries)
41+ [String] -> -- extra compiler flags (libraries)
44− String -> -- extra compiler flags (anything)
42+ [String] -> -- extra compiler flags (anything)
45 DbgLevel ->
43 DbgLevel ->
46 IO ()
44 IO ()
47codegenC' defs out exec incs objs libs flags dbg
45codegenC' defs out exec incs objs libs flags dbg
@@ -64,23 +62,22 @@ codegenC' defs out exec incs objs libs flags dbg
64 comp <- getCC
62 comp <- getCC
65 libFlags <- getLibFlags
63 libFlags <- getLibFlags
66 incFlags <- getIncFlags
64 incFlags <- getIncFlags
67− let gcc = comp ++ " " ++
68− gccDbg dbg ++ " " ++
65+ let args = [gccDbg dbg] ++
69− gccFlags ++
66+ gccFlags ++
70− -- # Any flags defined here which alter the RTS API must also be added to config.mk
67+ -- # Any flags defined here which alter the RTS API must also be added to config.mk
71− " -DHAS_PTHREAD -DIDRIS_ENABLE_STATS" ++
68+ ["-DHAS_PTHREAD", "-DIDRIS_ENABLE_STATS",
72− " -I. " ++ objs ++ " -x c " ++
69+ "-I."] ++ objs ++ ["-x", "c"] ++
73− (if (exec == Executable) then "" else " -c ") ++
70+ (if (exec == Executable) then [] else ["-c"]) ++
74− " " ++ tmpn ++
71+ [tmpn] ++
75− " " ++ libFlags ++
72+ libFlags ++
76− " " ++ incFlags ++
73+ incFlags ++
77− " " ++ libs ++
74+ libs ++
78− " " ++ flags ++
75+ flags ++
79− " -o " ++ out
76+ ["-o", out]
80-- putStrLn gcc
77-- putStrLn gcc
81− exit <- system gcc
78+ exit <- rawSystem comp args
82 when (exit /= ExitSuccess) $
79 when (exit /= ExitSuccess) $
83− putStrLn ("FAILURE: " ++ gcc)
80+ putStrLn ("FAILURE: " ++ show comp ++ " " ++ show args)
84
81
85headers xs =
82headers xs =
86 concatMap
83 concatMap
@@ -92,7 +89,7 @@ debug _ = ""
92
89
93-- We're using signed integers now. Make sure we get consistent semantics
90-- We're using signed integers now. Make sure we get consistent semantics
94-- out of them from gcc. See e.g. http://thiemonagel.de/2010/01/signed-integer-overflow/
91-- out of them from gcc. See e.g. http://thiemonagel.de/2010/01/signed-integer-overflow/
95−gccFlags = " -fwrapv -fno-strict-overflow"
92+gccFlags = ["-fwrapv", "-fno-strict-overflow"]
96
93
97gccDbg DEBUG = "-g"
94gccDbg DEBUG = "-g"
98gccDbg TRACE = "-O2"
95gccDbg TRACE = "-O2"
src/IRTS/System.hs+9−9
@@ -38,31 +38,31 @@ getTargetDir :: IO String
38getTargetDir = environment "TARGET" >>= maybe getDataDir return
38getTargetDir = environment "TARGET" >>= maybe getDataDir return
39
39
40#if defined(FREEBSD) || defined(DRAGONFLY)
40#if defined(FREEBSD) || defined(DRAGONFLY)
41−extraLib = " -L/usr/local/lib"
41+extraLib = ["-L/usr/local/lib"]
42#else
42#else
43−extraLib = ""
43+extraLib = []
44#endif
44#endif
45
45
46#ifdef IDRIS_GMP
46#ifdef IDRIS_GMP
47−gmpLib = " -lgmp"
47+gmpLib = ["-lgmp"]
48#else
48#else
49−gmpLib = ""
49+gmpLib = []
50#endif
50#endif
51
51
52getLibFlags = do dir <- getDataDir
52getLibFlags = do dir <- getDataDir
53− return $ "-L" ++ (dir </> "rts") ++
53+ return $ ["-L" ++ (dir </> "rts"),
54− " -lidris_rts" ++ extraLib ++ gmpLib ++ " -lpthread"
54+ "-lidris_rts"] ++ extraLib ++ gmpLib ++ ["-lpthread"]
55
55
56getIdrisLibDir = do dir <- getDataDir
56getIdrisLibDir = do dir <- getDataDir
57 return $ addTrailingPathSeparator dir
57 return $ addTrailingPathSeparator dir
58
58
59#if defined(FREEBSD) || defined(DRAGONFLY)
59#if defined(FREEBSD) || defined(DRAGONFLY)
60−extraInclude = " -I/usr/local/include"
60+extraInclude = ["-I/usr/local/include"]
61#else
61#else
62−extraInclude = ""
62+extraInclude = []
63#endif
63#endif
64getIncFlags = do dir <- getDataDir
64getIncFlags = do dir <- getDataDir
65− return $ "-I" ++ dir </> "rts" ++ extraInclude
65+ return $ ("-I" ++ dir </> "rts") : extraInclude
66
66
67getExecutablePom = do dir <- getDataDir
67getExecutablePom = do dir <- getDataDir
68 return $ dir </> "java" </> "executable_pom.xml"
68 return $ dir </> "java" </> "executable_pom.xml"
src/Pkg/Package.hs+1−1
@@ -224,7 +224,7 @@ testLib warn p f
224 (tmpf, tmph) <- tempfile
224 (tmpf, tmph) <- tempfile
225 hClose tmph
225 hClose tmph
226 let libtest = d </> "rts" </> "libtest.c"
226 let libtest = d </> "rts" </> "libtest.c"
227− e <- system $ gcc ++ " " ++ libtest ++ " -l" ++ f ++ " -o " ++ tmpf
227+ e <- rawSystem gcc [libtest, "-l" ++ f, "-o", tmpf]
228 case e of
228 case e of
229 ExitSuccess -> return True
229 ExitSuccess -> return True
230 _ -> do if warn
230 _ -> do if warn