on master help sign in
Add collapsing optimisation and more aggressive erasure
commitfb2b17d572973a732471442769f2c4f3d9036281 authorEdwin Brady <ecb10@st-andrews.ac.uk> dateSun 21 Oct 2012, 15:48 (14 years ago) parenta04b57d
7 files changed+185−27
src/Core/CaseTree.hs+4−2 src/IRTS/Compiler.hs+9−2 src/Idris/DataOpts.hs+122−9 src/Idris/ElabDecls.hs+38−6 src/Idris/UnusedArgs.hs+5−3 test/test001/test001.idr+5−3 test/test015/test015.idr+2−2
src/Core/CaseTree.hs+4−2
@@ -168,8 +168,10 @@ simpleCase tc cover phase fc cs
168168 defaultCase True = STerm Erased
169169 defaultCase False = UnmatchedCase "Error"
170170
171− chkAccessible (avs, l, c) = do mapM_ (acc l) avs
172− return (l, c)
171+ chkAccessible (avs, l, c)
172+ | phase == RunTime = return (l, c)
173+ | otherwise = do mapM_ (acc l) avs
174+ return (l, c)
173175
174176 acc [] n = Error (Inaccessible n)
175177 acc (PV x : xs) n | x == n = OK ()
src/IRTS/Compiler.hs+9−2
@@ -166,11 +166,16 @@ instance ToIR (TT Name) where
166166 = irCon env t a n args
167167 | (P _ n _, args) <- unApply tm
168168 = do i <- get
169+ let collapse = case lookupCtxt Nothing n (idris_optimisation i) of
170+ [oi] -> collapsible oi
171+ _ -> False
169172 let unused = case lookupCtxt Nothing n (idris_callgraph i) of
170173 [CGInfo _ _ _ unusedpos] -> unusedpos
171174 _ -> []
172175 args' <- mapM (ir' env) args
173− return (LApp False (LV (Glob n)) (mkUnused unused 0 args'))
176+ if collapse then return LNothing
177+ else return (LApp False (LV (Glob n))
178+ (mkUnused unused 0 args'))
174179 | (f, args) <- unApply tm
175180 = do f' <- ir' env f
176181 args' <- mapM (ir' env) args
@@ -194,7 +199,9 @@ instance ToIR (TT Name) where
194199 return $ LProj t' i
195200 ir' env (Constant c) = return $ LConst c
196201 ir' env (Set _) = return $ LNothing
197− ir' env _ = return $ LError "Impossible"
202+ ir' env Erased = return $ LNothing
203+ ir' env Impossible = return $ LNothing
204+-- ir' env _ = return $ LError "Impossible"
198205
199206 irCon env t arity n args
200207 | length args == arity = buildApp env (LV (Glob n)) args
src/Idris/DataOpts.hs+122−9
@@ -15,8 +15,8 @@ import Debug.Trace
1515-- optimisations
1616
1717forceArgs :: Name -> Type -> Idris ()
18−forceArgs n t = do let fargs = force 0 t
19− i <- getIState
18+forceArgs n t = do i <- getIState
19+ let fargs = force i 0 t
2020 copt <- case lookupCtxt Nothing n (idris_optimisation i) of
2121 [] -> return $ Optimise False [] []
2222 (op:_) -> return op
@@ -26,13 +26,22 @@ forceArgs n t = do let fargs = force 0 t
2626 iLOG $ "Forced: " ++ show n ++ " " ++ show fargs ++ "\n from " ++
2727 show t
2828 where
29− force :: Int -> Term -> [Int]
30− force i (Bind _ (Pi _) sc)
31− = force (i + 1) $ instantiate (P Bound (MN i "?") Erased) sc
32− force _ sc@(App f a)
29+ force :: IState -> Int -> Term -> [Int]
30+ force ist i (Bind _ (Pi ty) sc)
31+ | collapsibleIn ist ty
32+ = nub $ i : (force ist (i + 1) $ instantiate (P Bound (MN i "?") Erased) sc)
33+ | otherwise = force ist (i + 1) $ instantiate (P Bound (MN i "?") Erased) sc
34+ force _ _ sc@(App f a)
3335 | (_, args) <- unApply sc
3436 = nub $ concatMap guarded args
35− force _ _ = []
37+ force _ _ _ = []
38+
39+ collapsibleIn i t
40+ | (P _ tn _, _) <- unApply t
41+ = case lookupCtxt Nothing tn (idris_optimisation i) of
42+ [oi] -> collapsible oi
43+ _ -> False
44+ | otherwise = False
3645
3746 isF (P _ (MN force "?") _) = Just force
3847 isF _ = Nothing
@@ -49,24 +58,98 @@ forceArgs n t = do let fargs = force 0 t
4958
5059collapseCons :: Name -> [(Name, Type)] -> Idris ()
5160collapseCons ty cons =
52− do i <- getIState
53− return ()
61+ do i <- getIState
62+ let cons' = map (\ (n, t) -> (n, map snd (getArgTys t))) cons
63+ allFR <- mapM (forceRec i) cons'
64+ if and allFR then detaggable (map getRetTy (map snd cons))
65+ else return () -- not collapsible as not detaggable
66+ where
67+ setCollapsible :: Name -> Idris ()
68+ setCollapsible n
69+ = do i <- getIState
70+ iLOG $ show n ++ " collapsible"
71+ case lookupCtxt Nothing n (idris_optimisation i) of
72+ (oi:_) -> do let oi' = oi { collapsible = True }
73+ let opts = addDef n oi' (idris_optimisation i)
74+ putIState (i { idris_optimisation = opts })
75+ [] -> do let oi = Optimise True [] []
76+ let opts = addDef n oi (idris_optimisation i)
77+ putIState (i { idris_optimisation = opts })
78+ addIBC (IBCOpt n)
79+
80+ forceRec :: IState -> (Name, [Type]) -> Idris Bool
81+ forceRec i (n, ts)
82+ = case lookupCtxt Nothing n (idris_optimisation i) of
83+ (oi:_) -> checkFR (forceable oi) 0 ts
84+ _ -> return False
85+ checkFR fs i [] = return True
86+ checkFR fs i (_ : xs) | i `elem` fs = checkFR fs (i + 1) xs
87+ checkFR fs i (t : xs)
88+ -- must be recursive or type is not collapsible
89+ = do let rt = getRetTy t
90+ if (ty `elem` freeNames rt)
91+ then checkFR fs (i+1) xs
92+ else return False
93+
94+ detaggable :: [Type] -> Idris ()
95+ detaggable rtys
96+ = do let rtyArgs = map (snd . unApply) rtys
97+ -- if every rtyArgs is disjoint with every other, it's detaggable,
98+ -- therefore also collapsible given forceable/recursive check
99+ if disjoint rtyArgs
100+ then mapM_ setCollapsible (ty : map fst cons)
101+ else return ()
102+
103+ disjoint :: [[Term]] -> Bool
104+ disjoint [] = True
105+ disjoint [x] = True
106+ disjoint (x : xs) = anyDisjoint x xs && disjoint xs
107+
108+ anyDisjoint x [] = True
109+ anyDisjoint x (y : ys) = disjointCons x y
110+
111+ disjointCons [] [] = False
112+ disjointCons [] y = False
113+ disjointCons x [] = False
114+ disjointCons (x : xs) (y : ys)
115+ = disjointCon x y || disjointCons xs ys
116+
117+ disjointCon x y = let (cx, _) = unApply x
118+ (cy, _) = unApply y in
119+ case (cx, cy) of
120+ (P (DCon _ _) nx _, P (DCon _ _) ny _) -> nx /= ny
121+ _ -> False
54122
55123class Optimisable term where
56124 applyOpts :: term -> Idris term
125+ stripCollapsed :: term -> Idris term
57126
58127instance (Optimisable a, Optimisable b) => Optimisable (a, b) where
59128 applyOpts (x, y) = do x' <- applyOpts x
60129 y' <- applyOpts y
61130 return (x', y')
131+ stripCollapsed (x, y) = do x' <- stripCollapsed x
132+ y' <- stripCollapsed y
133+ return (x', y')
134+
62135
63136instance (Optimisable a, Optimisable b) => Optimisable (vs, a, b) where
64137 applyOpts (v, x, y) = do x' <- applyOpts x
65138 y' <- applyOpts y
66139 return (v, x', y')
140+ stripCollapsed (v, x, y) = do x' <- stripCollapsed x
141+ y' <- stripCollapsed y
142+ return (v, x', y')
67143
68144instance Optimisable a => Optimisable [a] where
69145 applyOpts = mapM applyOpts
146+ stripCollapsed = mapM stripCollapsed
147+
148+instance Optimisable a => Optimisable (Either a (a, a)) where
149+ applyOpts (Left t) = do t' <- applyOpts t; return $ Left t'
150+ applyOpts (Right t) = do t' <- applyOpts t; return $ Right t'
151+ stripCollapsed (Left t) = do t' <- stripCollapsed t; return $ Left t'
152+ stripCollapsed (Right t) = do t' <- stripCollapsed t; return $ Right t'
70153
71154-- Raw is for compile time optimisation (before type checking)
72155-- Term is for run time optimisation (after type checking, collapsing allowed)
@@ -90,12 +173,19 @@ instance Optimisable Raw where
90173 applyOpts (RForce t) = applyOpts t
91174 applyOpts t = return t
92175
176+ stripCollapsed t = return t
177+
93178instance Optimisable t => Optimisable (Binder t) where
94179 applyOpts (Let t v) = do t' <- applyOpts t
95180 v' <- applyOpts v
96181 return (Let t' v')
97182 applyOpts b = do t' <- applyOpts (binderTy b)
98183 return (b { binderTy = t' })
184+ stripCollapsed (Let t v) = do t' <- stripCollapsed t
185+ v' <- stripCollapsed v
186+ return (Let t' v')
187+ stripCollapsed b = do t' <- stripCollapsed (binderTy b)
188+ return (b { binderTy = t' })
99189
100190
101191applyDataOpt :: OptInfo -> Name -> [Raw] -> Raw
@@ -110,6 +200,11 @@ applyDataOpt oi n args
110200-- Run-time: do everything
111201
112202instance Optimisable (TT Name) where
203+ applyOpts c@(P (DCon t arity) n _)
204+ = do i <- getIState
205+ case lookupCtxt Nothing n (idris_optimisation i) of
206+ (oi:_) -> return $ applyDataOptRT oi n t arity []
207+ _ -> return c
113208 applyOpts t@(App f a)
114209 | (c@(P (DCon t arity) n _), args) <- unApply t -- MAGIC HERE
115210 = do args' <- mapM applyOpts args
@@ -123,8 +218,25 @@ instance Optimisable (TT Name) where
123218 applyOpts (Bind n b t) = do b' <- applyOpts b
124219 t' <- applyOpts t
125220 return (Bind n b' t')
221+ applyOpts (Proj t i) = do t' <- applyOpts t
222+ return (Proj t' i)
126223 applyOpts t = return t
127224
225+ stripCollapsed (Bind n (PVar x) t) | (P _ ty _, _) <- unApply x
226+ = do i <- getIState
227+ case lookupCtxt Nothing ty (idris_optimisation i) of
228+ [oi] -> if collapsible oi
229+ then do t' <- stripCollapsed t
230+ return (Bind n (PVar x) (instantiate Erased t'))
231+ else do t' <- stripCollapsed t
232+ return (Bind n (PVar x) t')
233+ _ -> do t' <- stripCollapsed t
234+ return (Bind n (PVar x) t')
235+ stripCollapsed (Bind n (PVar x) t)
236+ = do t' <- stripCollapsed t
237+ return (Bind n (PVar x) t')
238+ stripCollapsed t = return t
239+
128240-- Need to saturate arguments first to ensure that erasure happens uniformly
129241
130242applyDataOptRT :: OptInfo -> Name -> Int -> Int -> [Term] -> Term
@@ -148,3 +260,4 @@ applyDataOptRT oi n tag arity args
148260
149261 keep (forced, _) = not forced
150262
263+
src/Idris/ElabDecls.hs+38−6
@@ -233,23 +233,55 @@ elabClauses :: ElabInfo -> FC -> FnOpts -> Name -> [PClause] -> Idris ()
233233elabClauses info fc opts n_in cs = let n = liftname info n_in in
234234 do ctxt <- getContext
235235 -- Check n actually exists
236− case lookupTy Nothing n ctxt of
236+ fty <- case lookupTy Nothing n ctxt of
237237 [] -> -- TODO: turn into a CAF if there's no arguments
238238 -- question: CAFs in where blocks?
239239 tclift $ tfail $ (At fc (NoTypeDecl n))
240− _ -> return ()
240+ [ty] -> return ty
241241 pats_in <- mapM (elabClause info (TCGen `elem` opts)) cs
242−
242+ -- if the return type of 'ty' is collapsible, the optimised version should
243+ -- just do nothing
244+ ist <- get
245+ let (ap, _) = unApply (getRetTy fty)
246+ logLvl 5 $ "Checking collapsibility of " ++ show (ap, fty)
247+ -- FIXME: Really ought to only do this for total functions!
248+ let doNothing = case ap of
249+ P _ tn _ -> case lookupCtxt Nothing tn
250+ (idris_optimisation ist) of
251+ [oi] -> collapsible oi
252+ _ -> False
253+ _ -> False
243254 solveDeferred n
255+ ist <- get
256+ when doNothing $
257+ case lookupCtxt Nothing n (idris_optimisation ist) of
258+ [oi] -> do let opts = addDef n (oi { collapsible = True })
259+ (idris_optimisation ist)
260+ put (ist { idris_optimisation = opts })
261+ _ -> do let opts = addDef n (Optimise True [] [])
262+ (idris_optimisation ist)
263+ put (ist { idris_optimisation = opts })
264+ addIBC (IBCOpt n)
265+ ist <- get
244266 let pats = pats_in
245267-- logLvl 3 (showSep "\n" (map (\ (l,r) ->
246268-- show l ++ " = " ++
247269-- show r) pats))
248− ist <- get
249270 let tcase = opt_typecase (idris_options ist)
250271 let pdef = map debind $ map (simpl (tt_ctxt ist)) pats
272+
273+ numArgs <- tclift $ sameLength pdef
274+
275+ optpats <- if doNothing
276+ then return $ [Right (mkApp (P Bound n Erased)
277+ (take numArgs (repeat Erased)), Erased)]
278+ else stripCollapsed pats
279+
280+ logLvl 5 $ "Patterns:\n" ++ show pats
281+ logLvl 5 $ "Optimised patterns:\n" ++ show optpats
282+
283+ let optpdef = map debind $ map (simpl (tt_ctxt ist)) optpats
251284 tree@(CaseDef scargs sc _) <- tclift $ simpleCase tcase False CompileTime fc pdef
252− tclift $ sameLength pdef
253285 cov <- coverage
254286 pmissing <-
255287 if cov
@@ -263,7 +295,7 @@ elabClauses info fc opts n_in cs = let n = liftname info n_in in
263295 return missing'
264296 else return []
265297 let pcover = null pmissing
266− pdef' <- applyOpts pdef
298+ pdef' <- applyOpts optpdef
267299 ist <- get
268300-- let wf = wellFounded ist n sc
269301 let tot = if pcover || AssertTotal `elem` opts
src/Idris/UnusedArgs.hs+5−3
@@ -37,18 +37,20 @@ used :: [(Name, Int)] -> Name -> Int -> Idris Bool
3737used path g j
3838 | (g, j) `elem` path = return False -- cycle, never used on the way
3939 | otherwise
40− = do i <- get
40+ = do logLvl 5 $ (show ((g, j) : path))
41+ i <- get
4142 case lookupCtxt Nothing g (idris_callgraph i) of
4243 [CGInfo args calls usedns unused] ->
4344 if (j >= length args)
4445 then -- overapplied, assume used
4546 return True
46− else do let garg = getFargpos calls (args!!j, j)
47+ else do let directuse = args!!j `elem` usedns
48+ let garg = getFargpos calls (args!!j, j)
4749 logLvl 5 $ show (g, j, garg)
4850 recused <- mapM (\ (argn, j, (g', j')) ->
4951 used ((g,j):path) g' j') garg
5052 -- used on any route from here, or not used recursively
51− return (null recused || or recused)
53+ return (directuse || null recused || or recused)
5254 _ -> return True -- no definition, assume used
5355
5456getFargpos :: [(Name, [[Name]])] -> (Name, Int) -> [(Name, Int, (Name, Int))]
test/test001/test001.idr+5−3
@@ -7,7 +7,7 @@ interpTy TyInt = Int
77interpTy TyBool = Bool
88interpTy (TyFun s t) = interpTy s -> interpTy t
99
10−using (G : Vect Ty n) {
10+using (G : Vect Ty n)
1111
1212 data Env : Vect Ty n -> Set where
1313 Nil : Env Nil
@@ -20,6 +20,7 @@ using (G : Vect Ty n) {
2020 lookup : HasType i G t -> Env G -> interpTy t
2121 lookup stop (x :: xs) = x
2222 lookup (pop k) (x :: xs) = lookup k xs
23+ lookup stop [] impossible
2324
2425 data Expr : Vect Ty n -> Ty -> Set where
2526 Var : HasType i G t -> Expr G t
@@ -78,14 +79,15 @@ using (G : Vect Ty n) {
7879 (\y => Bind (App eDouble (Val x))
7980 (\z => App (App eAdd (Val y)) (Val z))))))
8081
81−}
82−
8382test : Int
8483test = interp [] eProg 2 2
8584
8685testFac : Int
8786testFac = interp [] eFac 4
8887
88+testEnv : Int -> Env [TyInt,TyInt]
89+testEnv x = [x,x]
90+
8991main : IO ()
9092main = do { print testFac
9193 print test }
test/test015/test015.idr+2−2
@@ -4,8 +4,8 @@ import parity
44import system
55
66data Bit : Nat -> Set where
7− b0 : Bit 0
8− b1 : Bit 1
7+ b0 : Bit O
8+ b1 : Bit (S O)
99
1010instance Show (Bit n) where
1111 show = show' where