From 17f7922cf94b634c903874f95f791430240c6c3f Mon Sep 17 00:00:00 2001
From: Ilan Cosman <ilancosman@gmail.com>
Date: Wed, 20 Sep 2023 13:44:42 -0700
Subject: [PATCH] Remove setting from prompt display

---
 functions/_tide_sub_configure.fish                   |  3 +--
 .../configure/choices/all/prompt_connection.fish     |  9 ++++++---
 .../all/prompt_connection_andor_frame_color.fish     | 12 ++++++++----
 functions/tide/configure/choices/all/show_time.fish  |  6 ++++--
 4 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/functions/_tide_sub_configure.fish b/functions/_tide_sub_configure.fish
index ec74328..22faf3a 100644
--- a/functions/_tide_sub_configure.fish
+++ b/functions/_tide_sub_configure.fish
@@ -123,10 +123,9 @@ function _tide_menu -a func
     end
 end
 
-function _tide_display_prompt -a var_name var_value
+function _tide_display_prompt
     set -q _flag_auto && return
 
-    test -n "$var_name" && set -g $var_name $var_value
     _fake_tide_cache_variables
     set -l prompt (_fake_tide_prompt)
 
diff --git a/functions/tide/configure/choices/all/prompt_connection.fish b/functions/tide/configure/choices/all/prompt_connection.fish
index cd890eb..97ed440 100644
--- a/functions/tide/configure/choices/all/prompt_connection.fish
+++ b/functions/tide/configure/choices/all/prompt_connection.fish
@@ -2,13 +2,16 @@ function prompt_connection
     _tide_title 'Prompt Connection'
 
     _tide_option 1 Disconnected
-    _tide_display_prompt fake_tide_prompt_icon_connection ' '
+    set -g fake_tide_prompt_icon_connection ' '
+    _tide_display_prompt
 
     _tide_option 2 Dotted
-    _tide_display_prompt fake_tide_prompt_icon_connection '·'
+    set -g fake_tide_prompt_icon_connection '·'
+    _tide_display_prompt
 
     _tide_option 3 Solid
-    _tide_display_prompt fake_tide_prompt_icon_connection '─'
+    set -g fake_tide_prompt_icon_connection '─'
+    _tide_display_prompt
 
     _tide_menu (status function)
     switch $_tide_selected_option
diff --git a/functions/tide/configure/choices/all/prompt_connection_andor_frame_color.fish b/functions/tide/configure/choices/all/prompt_connection_andor_frame_color.fish
index 0fd4349..cefbf2c 100644
--- a/functions/tide/configure/choices/all/prompt_connection_andor_frame_color.fish
+++ b/functions/tide/configure/choices/all/prompt_connection_andor_frame_color.fish
@@ -10,16 +10,20 @@ function prompt_connection_andor_frame_color
     _tide_title "Connection & Frame Color"
 
     _tide_option 1 Lightest
-    _tide_display_prompt fake_tide_prompt_color_frame_and_connection 808080
+    set -g fake_tide_prompt_color_frame_and_connection 808080
+    _tide_display_prompt
 
     _tide_option 2 Light
-    _tide_display_prompt fake_tide_prompt_color_frame_and_connection 6C6C6C
+    set -g fake_tide_prompt_color_frame_and_connection 6C6C6C
+    _tide_display_prompt
 
     _tide_option 3 Dark
-    _tide_display_prompt fake_tide_prompt_color_frame_and_connection 585858
+    set -g fake_tide_prompt_color_frame_and_connection 585858
+    _tide_display_prompt
 
     _tide_option 4 Darkest
-    _tide_display_prompt fake_tide_prompt_color_frame_and_connection 444444
+    set -g fake_tide_prompt_color_frame_and_connection 444444
+    _tide_display_prompt
 
     _tide_menu (status function)
     switch $_tide_selected_option
diff --git a/functions/tide/configure/choices/all/show_time.fish b/functions/tide/configure/choices/all/show_time.fish
index 89d34ea..b66c785 100644
--- a/functions/tide/configure/choices/all/show_time.fish
+++ b/functions/tide/configure/choices/all/show_time.fish
@@ -7,10 +7,12 @@ function show_time
     set -a fake_tide_right_prompt_items time
 
     _tide_option 2 '24-hour format'
-    _tide_display_prompt fake_tide_time_format %T
+    set -g fake_tide_time_format %T
+    _tide_display_prompt
 
     _tide_option 3 '12-hour format'
-    _tide_display_prompt fake_tide_time_format %r
+    set -g fake_tide_time_format %r
+    _tide_display_prompt
 
     _tide_menu (status function)
     switch $_tide_selected_option