LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity
3c212c8535
ladybird/Userland/Libraries/LibWeb/CSS/StyleValue.h

346 lines
18 KiB
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
/*
LibWeb: Move resolution of font weights and slopes to StyleValue This isn't exactly ideal factoring (though I'm not sure what is) but this will make it possible to reuse this code in the parser.
2023-05-24 16:28:09 +03:00
* Copyright (c) 2018-2023, Andreas Kling <kling@serenityos.org>
Everywhere: Use tobyase@serenityos.org for my copyright headers
2021-08-09 22:28:56 +03:00
* Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org>
LibWeb: Convert AbstractImageStyleValue to new pixel units
2022-11-08 19:31:01 +03:00
* Copyright (c) 2021-2023, Sam Atkins <atkinssj@serenityos.org>
LibWeb: Remove some unnecessary .release_value()s in StyleValue And instead propagate these errors. Also while here add my copyright (I've touched these files a lot)
2023-01-14 02:44:44 +03:00
* Copyright (c) 2022-2023, MacDue <macdue@dueutil.tech>
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 11:24:48 +03:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
*/
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
#pragma once
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
#include <AK/Concepts.h>
LibWeb: Convert images to common AbstractImageStyleValue base This commit moves both the ImageStyleValue and LinearGradientStyleValue to a common base class of AbstractImageStyleValue. This abstracts getting the natural_width/height, loading/resolving, and painting the image. Now for 'free' you get: - Linear gradients working with the various background sizing/repeat properties. - Linear gradients working as list-markers :^) -- best feature ever! P.s. This commit is a little large as it's tricky to make this change incrementally without breaking things.
2022-07-31 03:11:59 +03:00
#include <AK/GenericShorthands.h>
LibWeb: Add CalculatedStyleValue to the CSS StyleValues This adds the CalculatedStyleValue and all the structs needed to work with the calc() expressions.
2021-07-23 00:01:39 +03:00
#include <AK/NonnullOwnPtr.h>
AK: Rename Retainable.h => RefCounted.h.
2019-06-21 19:58:45 +03:00
#include <AK/RefCounted.h>
LibHTML: Implement enough of the CSS parser to parse the default stylesheet.
2019-06-22 22:48:21 +03:00
#include <AK/RefPtr.h>
LibWeb+WebContent: Use new String class in CSS::StyleValue Converts uses of DeprecatedString to String in StyleValue, and patches surrounding files that depend on these functions.
2023-01-06 21:02:26 +03:00
#include <AK/String.h>
LibHTML: Implement enough of the CSS parser to parse the default stylesheet.
2019-06-22 22:48:21 +03:00
#include <AK/StringView.h>
LibHTML: Implement basic tiled background image support It's now possible to set a page background image via <body background>. Also, HtmlView now officially handles rendering the body element's background (color, image or both.) LayoutBox is responsible for all other background rendering. Note that it's not yet possible to use CSS background-image properties directly, since we can't parse them yet. :^)
2019-10-19 12:49:46 +03:00
#include <AK/URL.h>
LibWeb: Add CalculatedStyleValue to the CSS StyleValues This adds the CalculatedStyleValue and all the structs needed to work with the calc() expressions.
2021-07-23 00:01:39 +03:00
#include <AK/Variant.h>
#include <AK/Vector.h>
LibHTML: Implement basic tiled background image support It's now possible to set a page background image via <body background>. Also, HtmlView now officially handles rendering the body element's background (color, image or both.) LayoutBox is responsible for all other background rendering. Note that it's not yet possible to use CSS background-image properties directly, since we can't parse them yet. :^)
2019-10-19 12:49:46 +03:00
#include <AK/WeakPtr.h>
LibWeb: Support more CSS image-rendering values This patch adds support for "crisp-edges", "high-quality" and "smooth" for the CSS image-rendering property. "crisp-edges" maps to nearest-neighbor scaling for <canvas> and <img> elements, while "high-quality" and "smooth" both use bilinear blending.
2022-03-06 20:17:50 +03:00
#include <LibGfx/Painter.h>
LibWeb: Use the generated enums instead of defining them in StyleValue.h The remaining enums here are special cases that don't directly correspond to a list of identifiers. But the majority can go. :^)
2022-04-13 19:29:01 +03:00
#include <LibWeb/CSS/Enums.h>
LibWeb: Rename directory LibHTML => LibWeb Let's rename this to LibWeb since it aims to provide more parts of the web platform than just HTML. :^)
2020-03-07 12:32:51 +03:00
#include <LibWeb/CSS/Length.h>
LibWeb: Generate the CSS::ValueID enum and its helper functions
2020-12-15 22:39:09 +03:00
#include <LibWeb/CSS/ValueID.h>
LibWeb: Use "namespace Web::Foo {" since C++20 allows it :^) Thanks @nico for teaching me about this!
2020-07-21 17:23:08 +03:00
#include <LibWeb/Forward.h>
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
LibWeb: Use "namespace Web::Foo {" since C++20 allows it :^) Thanks @nico for teaching me about this!
2020-07-21 17:23:08 +03:00
namespace Web::CSS {
LibHTML: Respect the link color set via <body link> The default style for "a" tags now has { color: -libhtml-link; }. We implement this vendor-specific property by querying the containing document for the appropriate link color. Currently we only use the basic link color, but in the future this can be extended to remember visited links, etc.
2019-10-06 11:25:08 +03:00
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
template<typename T>
struct ValueComparingNonnullRefPtr : public NonnullRefPtr<T> {
using NonnullRefPtr<T>::NonnullRefPtr;
ValueComparingNonnullRefPtr(NonnullRefPtr<T> const& other)
: NonnullRefPtr<T>(other)
{
}
ValueComparingNonnullRefPtr(NonnullRefPtr<T>&& other)
: NonnullRefPtr<T>(move(other))
{
}
bool operator==(ValueComparingNonnullRefPtr const& other) const
{
return this->ptr() == other.ptr() || this->ptr()->equals(*other);
}
private:
using NonnullRefPtr<T>::operator==;
};
template<typename T>
struct ValueComparingRefPtr : public RefPtr<T> {
using RefPtr<T>::RefPtr;
ValueComparingRefPtr(RefPtr<T> const& other)
: RefPtr<T>(other)
{
}
ValueComparingRefPtr(RefPtr<T>&& other)
: RefPtr<T>(move(other))
{
}
template<typename U>
bool operator==(ValueComparingNonnullRefPtr<U> const& other) const
{
return this->ptr() == other.ptr() || (this->ptr() && this->ptr()->equals(*other));
}
bool operator==(ValueComparingRefPtr const& other) const
{
return this->ptr() == other.ptr() || (this->ptr() && other.ptr() && this->ptr()->equals(*other));
}
private:
using RefPtr<T>::operator==;
};
LibWeb: Stop using NonnullRefPtrVector for StyleValueVector
2023-03-06 16:33:11 +03:00
using StyleValueVector = Vector<ValueComparingNonnullRefPtr<StyleValue const>>;
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
AK: Rename Retainable => RefCounted. (And various related renames that go along with it.)
2019-06-21 16:29:31 +03:00
class StyleValue : public RefCounted<StyleValue> {
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
public:
Libraries: Use default constructors/destructors in LibWeb https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-03-14 22:21:51 +03:00
virtual ~StyleValue() = default;
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
LibHTML: Add LengthStyleValue and create those when parsing number values.
2019-07-03 08:55:22 +03:00
enum class Type {
LibWeb: Implement CSS Angle class This corresponds to `<angle>` in the grammar.
2022-02-21 20:43:30 +03:00
Angle,
LibWeb: Implement and use BackgroundStyleValue This one represents one secton of a `background` property, since it can have multiple background values separated by commas. Eventually, we will represent that as a List of BackgroundStyleValues. Also modified some background-foo properties in StyleResolver so that the is_background_x() functions could be removed. I realized that our handling of var() in shorthand properties is wrong, so have been removing the is_builtin_or_dynamic() calls from the parsing code for shorthands. This broke our var() test page, so I have replaced the use of 'background' with 'background-color' there.
2021-08-03 16:56:08 +03:00
Background,
LibWeb: Implement and use BackgroundRepeatStyleValue This wraps an x and y background-repeat value. Potentially, we could use this in place of the background-repeat-x and background-repeat-y pseudo-properties, but for now StyleResolver splits it into those properties, like it did before.
2021-08-10 12:21:42 +03:00
BackgroundRepeat,
LibWeb: Add BackgroundSizeStyleValue There's nothing really background-size-specific about this, but since there is no `<size>` value type defined in the CSS spec at this time, and background-size is the only user of it, I think this name makes more sense. But I'm not 100% convinced.
2021-11-05 15:18:23 +03:00
BackgroundSize,
LibWeb: Implement and use BorderStyleValue
2021-08-05 23:11:38 +03:00
Border,
LibWeb: Implement and use BorderRadiusStyleValue This parses the elliptical border-radius values, though currently we only support circular ones. So, to_length() is overloaded to return the horizontal-radius. This means the code in Layout/Node.cpp does not need to change for now.
2021-08-06 18:55:08 +03:00
BorderRadius,
LibWeb: Rename CombinedBorderRadiusSV -> BorderRadiusShorthandSV
2022-04-18 19:02:39 +03:00
BorderRadiusShorthand,
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
Calculated,
Color,
LibWeb: Add ConicGradientStyleValue This commit adds a simple style value (which is an abstract image) to represent conic-gradient()s. This commit also starts to factor out some reusable parts of the linear-gradient() style value for other gradient types.
2022-10-28 22:44:00 +03:00
ConicGradient,
LibWeb: Parse the `content` property For now, we only understand `none`, `normal`, `<image>` and `<string>`. The various other functions and identifiers can be added later. We can *almost* use a StyleValueList for this, except it's divided into two parts - the content, and the optional "alt text". So, I've added a new StyleValue for it.
2022-02-23 22:56:25 +03:00
Content,
LibWeb: Support multi-keyword syntax for CSS display property The Display class already supported all specific values, and now they will be parsed too. The display property now has a special type DisplayStyleValue.
2023-04-26 22:05:38 +03:00
Display,
LibWeb: Add EdgeStyleValue This represents a single edge and offset, this will be needed for the values of background-position-x/y.
2023-04-03 00:56:45 +03:00
Edge,
LibWeb: Add FilterValueListStyleValue This style value holds a list of CSS filter function calls e.g. blur(10px) invert() grayscale() It will be used to implement backdrop-filter, but the same style value can be used for the image filter property. (The name is a little awkward but it's referenced to as filter-value-list in the spec too).
2022-09-15 10:31:14 +03:00
FilterValueList,
LibWeb: Implement and use FlexStyleValue This is not just moving the code from StyleResolver to Parser. The logic has changed to allow for the `flex-basis` to come before or after the `flex-grow/shrink` values, as well as handle the special one-value cases. Also added test cases to flex.html to check the parsing. It does parse correctly, but elements with `flex-basis: auto` do not calculate their width correctly.
2021-08-04 19:48:08 +03:00
Flex,
LibWeb: Implement and use FlexFlowStyleValue
2021-08-05 19:19:29 +03:00
FlexFlow,
LibWeb: Implement and use FontStyleValue After working with the code for a while, it makes more sense to put all the parsing in Parser, instead of some of it living in StyleResolver. That means our current ValueListStyleValue needs to be replaced with specific StyleValue types for the properties that are shorthands or otherwise combine several values together. Here we implement FontStyleProperty, which represents a `font` CSS property. Also adjusted the fonts.html test page so that font-weights are featured in test cases without things we do not yet support.
2021-08-03 13:37:24 +03:00
Font,
LibWeb: Implement CSS Frequency class This corresponds to `<frequency>` in the grammar.
2022-02-21 20:49:47 +03:00
Frequency,
LibWeb: Parse `grid-area` CSS property
2023-01-16 21:02:39 +03:00
GridAreaShorthand,
LibWeb: Parse `grid-template-areas` CSS property
2023-01-16 20:17:05 +03:00
GridTemplateArea,
LibWeb: Add GridTrackPlacementStyleValue Add GridTrackPlacementStyleValue for the use of CSS properties grid-column-start, grid-column-end, grid-row-start, grid-row-end.
2022-08-24 13:31:00 +03:00
GridTrackPlacement,
LibWeb: Add GridTrackPlacementShorthandStyleValue Add GridTrackPlacementShorthandStyleValue for the use of grid-column and grid-row.
2022-08-24 13:25:56 +03:00
GridTrackPlacementShorthand,
LibWeb: Refactor GridTrackSize classes Refactor various classes in the GridTrackSize file for the incoming named_tracks feature. Previously the ExplicitTrackSizing had mixed responsiblities with the newly-named GridRepeat class. This made it so it was not possible to have multiple repeats within a single 'GridTrackSizeList' definition. The MetaGridTrackSize class had both the responsibilities of being a container for minmax values as well as for simple GridSizes. By uniting the different possible values (repeat, minmax, default) into the ExplicitGridTrack class are able to be more expressive as to the different grid size modalities. The GridTrackSizeList will be useful as compared to a Vector<ExplicitGridTrack> since this way can keep track of the declared line names. These same line names are able to be declared within the values of a repeat function, hence the presence of a GridTrackSizeList inside the GridRepeat class.
2022-10-30 15:27:57 +03:00
GridTrackSizeList,
LibWeb: Parse `grid-template` property
2023-04-29 20:32:56 +03:00
GridTrackSizeListShorthand,
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
Identifier,
Image,
Inherit,
Initial,
Invalid,
Length,
LibWeb: Add LinearGradientStyleValue
2022-07-12 02:09:29 +03:00
LinearGradient,
LibWeb: Implement and use ListStyleStyleValue Yes, the name is silly, but it's a StyleValue for list-style, so... yeah. :^) Since `list-style-type` and `list-style-image` can both have `none` as a value, and can appear in any order, we have to handle it separately, and then assign either or both of those to `none` depending on how many `none`s there are, and whether those sub-properties already have values. Added some extra test cases to lists.html to cover list-style-image and list-style-position parts of the list-style shorthand, and the `none` values.
2021-08-03 17:56:51 +03:00
ListStyle,
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
Numeric,
LibWeb: Implement and use OverflowStyleValue Also added a test page for the `overflow` properties. They apparently don't work, but at least they do parse.
2021-08-09 16:54:40 +03:00
Overflow,
LibWeb: Add PercentageStyleValue, and parse it This is in a slightly weird state, where Percentages are sometimes Lengths and sometimes not, which I will be cleaning up in subsequent commits, in an attempt not to change all of LibWeb in one go. :^)
2022-01-14 20:09:02 +03:00
Percentage,
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
Position,
LibWeb: Implement RadialGradientStyleValue Adds a style value for `radial-gradient()`s and implements some helpers for resolving their properties.
2022-11-11 20:13:00 +03:00
RadialGradient,
LibWeb: Parse rect style value Add ability to parse a rect when it is used as the value of a style property.
2022-07-31 19:46:35 +03:00
Rect,
LibWeb: Implement CSS Resolution class This corresponds to `<resolution>` in the grammar.
2022-02-21 20:51:01 +03:00
Resolution,
LbWeb: Rename BoxShadowFoo => ShadowFoo The `text-shadow` property is almost identical to `box-shadow`: > Values are interpreted as for box-shadow [CSS-BACKGROUNDS-3]. > (But note that the inset keyword are not allowed.) So, let's use the same data structures and parsing code for both. :^)
2022-03-23 19:55:22 +03:00
Shadow,
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
String,
LibWeb: Implement and use TextDecorationStyleValue Modified text-decoration.html to better test that the values can be in any order, and that it adopts the color from the `color` property if no decoration color is specified. Right now, it always does because we do not support a different decoration color. Later, we need to support the `currentcolor` special CSS value for this purpose.
2021-08-04 14:34:14 +03:00
TextDecoration,
LibWeb: Implement CSS Time class This corresponds to `<time>` in the grammar.
2022-02-21 22:29:43 +03:00
Time,
LibWeb: Add transform property to the system This patch adds parsing support as well as all the needed stuctures all over LibWeb to pass Transformations around.
2021-09-18 18:20:00 +03:00
Transformation,
LibWeb: Add new UnresolvedStyleValue class This represents a property value that hasn't been converted to a "proper" StyleValue yet. That is, it's either a custom property's value, or a value that includes `var()` references, (or both!) since neither of those can be fully resolved at parse time.
2021-12-03 15:28:14 +03:00
Unresolved,
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
Unset,
LibWeb: Add URLStyleValue to represent general url() values This is primarily being added to support `fill: url(#gradient)` for SVGs.
2023-04-20 20:31:00 +03:00
Url,
LibWeb: Add LinearGradientStyleValue
2022-07-12 02:09:29 +03:00
ValueList
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
};
Type type() const { return m_type; }
LibWeb: Implement RadialGradientStyleValue Adds a style value for `radial-gradient()`s and implements some helpers for resolving their properties.
2022-11-11 20:13:00 +03:00
bool is_abstract_image() const { return AK::first_is_one_of(type(), Type::Image, Type::LinearGradient, Type::ConicGradient, Type::RadialGradient); }
LibWeb: Implement CSS Angle class This corresponds to `<angle>` in the grammar.
2022-02-21 20:43:30 +03:00
bool is_angle() const { return type() == Type::Angle; }
LibWeb: Implement and use BackgroundStyleValue This one represents one secton of a `background` property, since it can have multiple background values separated by commas. Eventually, we will represent that as a List of BackgroundStyleValues. Also modified some background-foo properties in StyleResolver so that the is_background_x() functions could be removed. I realized that our handling of var() in shorthand properties is wrong, so have been removing the is_builtin_or_dynamic() calls from the parsing code for shorthands. This broke our var() test page, so I have replaced the use of 'background' with 'background-color' there.
2021-08-03 16:56:08 +03:00
bool is_background() const { return type() == Type::Background; }
LibWeb: Implement and use BackgroundRepeatStyleValue This wraps an x and y background-repeat value. Potentially, we could use this in place of the background-repeat-x and background-repeat-y pseudo-properties, but for now StyleResolver splits it into those properties, like it did before.
2021-08-10 12:21:42 +03:00
bool is_background_repeat() const { return type() == Type::BackgroundRepeat; }
LibWeb: Add BackgroundSizeStyleValue There's nothing really background-size-specific about this, but since there is no `<size>` value type defined in the CSS spec at this time, and background-size is the only user of it, I think this name makes more sense. But I'm not 100% convinced.
2021-11-05 15:18:23 +03:00
bool is_background_size() const { return type() == Type::BackgroundSize; }
LibWeb: Implement and use BorderStyleValue
2021-08-05 23:11:38 +03:00
bool is_border() const { return type() == Type::Border; }
LibWeb: Implement and use BorderRadiusStyleValue This parses the elliptical border-radius values, though currently we only support circular ones. So, to_length() is overloaded to return the horizontal-radius. This means the code in Layout/Node.cpp does not need to change for now.
2021-08-06 18:55:08 +03:00
bool is_border_radius() const { return type() == Type::BorderRadius; }
LibWeb: Add missing [as/is]_border_radius_shorthand() methods
2022-04-18 19:04:38 +03:00
bool is_border_radius_shorthand() const { return type() == Type::BorderRadiusShorthand; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_calculated() const { return type() == Type::Calculated; }
bool is_color() const { return type() == Type::Color; }
LibWeb: Add ConicGradientStyleValue This commit adds a simple style value (which is an abstract image) to represent conic-gradient()s. This commit also starts to factor out some reusable parts of the linear-gradient() style value for other gradient types.
2022-10-28 22:44:00 +03:00
bool is_conic_gradient() const { return type() == Type::ConicGradient; }
LibWeb: Parse the `content` property For now, we only understand `none`, `normal`, `<image>` and `<string>`. The various other functions and identifiers can be added later. We can *almost* use a StyleValueList for this, except it's divided into two parts - the content, and the optional "alt text". So, I've added a new StyleValue for it.
2022-02-23 22:56:25 +03:00
bool is_content() const { return type() == Type::Content; }
LibWeb: Support multi-keyword syntax for CSS display property The Display class already supported all specific values, and now they will be parsed too. The display property now has a special type DisplayStyleValue.
2023-04-26 22:05:38 +03:00
bool is_display() const { return type() == Type::Display; }
LibWeb: Add EdgeStyleValue This represents a single edge and offset, this will be needed for the values of background-position-x/y.
2023-04-03 00:56:45 +03:00
bool is_edge() const { return type() == Type::Edge; }
LibWeb: Add FilterValueListStyleValue This style value holds a list of CSS filter function calls e.g. blur(10px) invert() grayscale() It will be used to implement backdrop-filter, but the same style value can be used for the image filter property. (The name is a little awkward but it's referenced to as filter-value-list in the spec too).
2022-09-15 10:31:14 +03:00
bool is_filter_value_list() const { return type() == Type::FilterValueList; }
LibWeb: Implement and use FlexStyleValue This is not just moving the code from StyleResolver to Parser. The logic has changed to allow for the `flex-basis` to come before or after the `flex-grow/shrink` values, as well as handle the special one-value cases. Also added test cases to flex.html to check the parsing. It does parse correctly, but elements with `flex-basis: auto` do not calculate their width correctly.
2021-08-04 19:48:08 +03:00
bool is_flex() const { return type() == Type::Flex; }
LibWeb: Implement and use FlexFlowStyleValue
2021-08-05 19:19:29 +03:00
bool is_flex_flow() const { return type() == Type::FlexFlow; }
LibWeb: Implement and use FontStyleValue After working with the code for a while, it makes more sense to put all the parsing in Parser, instead of some of it living in StyleResolver. That means our current ValueListStyleValue needs to be replaced with specific StyleValue types for the properties that are shorthands or otherwise combine several values together. Here we implement FontStyleProperty, which represents a `font` CSS property. Also adjusted the fonts.html test page so that font-weights are featured in test cases without things we do not yet support.
2021-08-03 13:37:24 +03:00
bool is_font() const { return type() == Type::Font; }
LibWeb: Implement CSS Frequency class This corresponds to `<frequency>` in the grammar.
2022-02-21 20:49:47 +03:00
bool is_frequency() const { return type() == Type::Frequency; }
LibWeb: Parse `grid-area` CSS property
2023-01-16 21:02:39 +03:00
bool is_grid_area_shorthand() const { return type() == Type::GridAreaShorthand; }
LibWeb: Parse `grid-template-areas` CSS property
2023-01-16 20:17:05 +03:00
bool is_grid_template_area() const { return type() == Type::GridTemplateArea; }
LibWeb: Add GridTrackPlacementStyleValue Add GridTrackPlacementStyleValue for the use of CSS properties grid-column-start, grid-column-end, grid-row-start, grid-row-end.
2022-08-24 13:31:00 +03:00
bool is_grid_track_placement() const { return type() == Type::GridTrackPlacement; }
LibWeb: Add GridTrackPlacementShorthandStyleValue Add GridTrackPlacementShorthandStyleValue for the use of grid-column and grid-row.
2022-08-24 13:25:56 +03:00
bool is_grid_track_placement_shorthand() const { return type() == Type::GridTrackPlacementShorthand; }
LibWeb: Refactor GridTrackSize classes Refactor various classes in the GridTrackSize file for the incoming named_tracks feature. Previously the ExplicitTrackSizing had mixed responsiblities with the newly-named GridRepeat class. This made it so it was not possible to have multiple repeats within a single 'GridTrackSizeList' definition. The MetaGridTrackSize class had both the responsibilities of being a container for minmax values as well as for simple GridSizes. By uniting the different possible values (repeat, minmax, default) into the ExplicitGridTrack class are able to be more expressive as to the different grid size modalities. The GridTrackSizeList will be useful as compared to a Vector<ExplicitGridTrack> since this way can keep track of the declared line names. These same line names are able to be declared within the values of a repeat function, hence the presence of a GridTrackSizeList inside the GridRepeat class.
2022-10-30 15:27:57 +03:00
bool is_grid_track_size_list() const { return type() == Type::GridTrackSizeList; }
LibWeb: Parse `grid-template` property
2023-04-29 20:32:56 +03:00
bool is_grid_track_size_list_shorthand() const { return type() == Type::GridTrackSizeListShorthand; }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
bool is_identifier() const { return type() == Type::Identifier; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_image() const { return type() == Type::Image; }
bool is_inherit() const { return type() == Type::Inherit; }
bool is_initial() const { return type() == Type::Initial; }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
bool is_length() const { return type() == Type::Length; }
LibWeb: Add LinearGradientStyleValue
2022-07-12 02:09:29 +03:00
bool is_linear_gradient() const { return type() == Type::LinearGradient; }
LibWeb: Implement and use ListStyleStyleValue Yes, the name is silly, but it's a StyleValue for list-style, so... yeah. :^) Since `list-style-type` and `list-style-image` can both have `none` as a value, and can appear in any order, we have to handle it separately, and then assign either or both of those to `none` depending on how many `none`s there are, and whether those sub-properties already have values. Added some extra test cases to lists.html to cover list-style-image and list-style-position parts of the list-style shorthand, and the `none` values.
2021-08-03 17:56:51 +03:00
bool is_list_style() const { return type() == Type::ListStyle; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_numeric() const { return type() == Type::Numeric; }
LibWeb: Implement and use OverflowStyleValue Also added a test page for the `overflow` properties. They apparently don't work, but at least they do parse.
2021-08-09 16:54:40 +03:00
bool is_overflow() const { return type() == Type::Overflow; }
LibWeb: Add PercentageStyleValue, and parse it This is in a slightly weird state, where Percentages are sometimes Lengths and sometimes not, which I will be cleaning up in subsequent commits, in an attempt not to change all of LibWeb in one go. :^)
2022-01-14 20:09:02 +03:00
bool is_percentage() const { return type() == Type::Percentage; }
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
bool is_position() const { return type() == Type::Position; }
LibWeb: Implement RadialGradientStyleValue Adds a style value for `radial-gradient()`s and implements some helpers for resolving their properties.
2022-11-11 20:13:00 +03:00
bool is_radial_gradient() const { return type() == Type::RadialGradient; }
LibWeb: Parse rect style value Add ability to parse a rect when it is used as the value of a style property.
2022-07-31 19:46:35 +03:00
bool is_rect() const { return type() == Type::Rect; }
LibWeb: Implement CSS Resolution class This corresponds to `<resolution>` in the grammar.
2022-02-21 20:51:01 +03:00
bool is_resolution() const { return type() == Type::Resolution; }
LbWeb: Rename BoxShadowFoo => ShadowFoo The `text-shadow` property is almost identical to `box-shadow`: > Values are interpreted as for box-shadow [CSS-BACKGROUNDS-3]. > (But note that the inset keyword are not allowed.) So, let's use the same data structures and parsing code for both. :^)
2022-03-23 19:55:22 +03:00
bool is_shadow() const { return type() == Type::Shadow; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_string() const { return type() == Type::String; }
LibWeb: Implement and use TextDecorationStyleValue Modified text-decoration.html to better test that the values can be in any order, and that it adopts the color from the `color` property if no decoration color is specified. Right now, it always does because we do not support a different decoration color. Later, we need to support the `currentcolor` special CSS value for this purpose.
2021-08-04 14:34:14 +03:00
bool is_text_decoration() const { return type() == Type::TextDecoration; }
LibWeb: Implement CSS Time class This corresponds to `<time>` in the grammar.
2022-02-21 22:29:43 +03:00
bool is_time() const { return type() == Type::Time; }
LibWeb: Add transform property to the system This patch adds parsing support as well as all the needed stuctures all over LibWeb to pass Transformations around.
2021-09-18 18:20:00 +03:00
bool is_transformation() const { return type() == Type::Transformation; }
LibWeb: Add new UnresolvedStyleValue class This represents a property value that hasn't been converted to a "proper" StyleValue yet. That is, it's either a custom property's value, or a value that includes `var()` references, (or both!) since neither of those can be fully resolved at parse time.
2021-12-03 15:28:14 +03:00
bool is_unresolved() const { return type() == Type::Unresolved; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_unset() const { return type() == Type::Unset; }
LibWeb: Add URLStyleValue to represent general url() values This is primarily being added to support `fill: url(#gradient)` for SVGs.
2023-04-20 20:31:00 +03:00
bool is_url() const { return type() == Type::Url; }
LibWeb: Alphabetically sort StyleValues The random order keeps confuzing me!
2021-09-23 18:30:40 +03:00
bool is_value_list() const { return type() == Type::ValueList; }
LibWeb: Expose StyleValue parsing method in CSS Parser Now that StyleResolver is going to deal with StyleComponentValueRules, it will need to be able to parse those into StyleValues, using `parse_css_value()`. Also added StyleValue::is_builtin_or_dynamic(), which returns true for values that are valid anywhere - things like `initial` and `inherit`, along with `var()`, `attr()` and `calc()` - which we want to test for easily.
2021-07-18 19:12:23 +03:00
LibWeb: Implement CSS `unset` builtin value This is equivalent to `initial` or `inherit`, depending on if the property is inherited by default.
2021-08-20 21:52:36 +03:00
bool is_builtin() const { return is_inherit() || is_initial() || is_unset(); }
LibWeb: Add StyleValue.is_builtin() convenience function
2021-08-10 14:23:27 +03:00
LibWeb: Convert images to common AbstractImageStyleValue base This commit moves both the ImageStyleValue and LinearGradientStyleValue to a common base class of AbstractImageStyleValue. This abstracts getting the natural_width/height, loading/resolving, and painting the image. Now for 'free' you get: - Linear gradients working with the various background sizing/repeat properties. - Linear gradients working as list-markers :^) -- best feature ever! P.s. This commit is a little large as it's tricky to make this change incrementally without breaking things.
2022-07-31 03:11:59 +03:00
AbstractImageStyleValue const& as_abstract_image() const;
LibWeb: Implement CSS Angle class This corresponds to `<angle>` in the grammar.
2022-02-21 20:43:30 +03:00
AngleStyleValue const& as_angle() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BackgroundStyleValue const& as_background() const;
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
BackgroundRepeatStyleValue const& as_background_repeat() const;
LibWeb: Add BackgroundSizeStyleValue There's nothing really background-size-specific about this, but since there is no `<size>` value type defined in the CSS spec at this time, and background-size is the only user of it, I think this name makes more sense. But I'm not 100% convinced.
2021-11-05 15:18:23 +03:00
BackgroundSizeStyleValue const& as_background_size() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BorderRadiusStyleValue const& as_border_radius() const;
LibWeb: Add missing [as/is]_border_radius_shorthand() methods
2022-04-18 19:04:38 +03:00
BorderRadiusShorthandStyleValue const& as_border_radius_shorthand() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BorderStyleValue const& as_border() const;
CalculatedStyleValue const& as_calculated() const;
ColorStyleValue const& as_color() const;
LibWeb: Add ConicGradientStyleValue This commit adds a simple style value (which is an abstract image) to represent conic-gradient()s. This commit also starts to factor out some reusable parts of the linear-gradient() style value for other gradient types.
2022-10-28 22:44:00 +03:00
ConicGradientStyleValue const& as_conic_gradient() const;
LibWeb: Parse the `content` property For now, we only understand `none`, `normal`, `<image>` and `<string>`. The various other functions and identifiers can be added later. We can *almost* use a StyleValueList for this, except it's divided into two parts - the content, and the optional "alt text". So, I've added a new StyleValue for it.
2022-02-23 22:56:25 +03:00
ContentStyleValue const& as_content() const;
LibWeb: Support multi-keyword syntax for CSS display property The Display class already supported all specific values, and now they will be parsed too. The display property now has a special type DisplayStyleValue.
2023-04-26 22:05:38 +03:00
DisplayStyleValue const& as_display() const;
LibWeb: Add EdgeStyleValue This represents a single edge and offset, this will be needed for the values of background-position-x/y.
2023-04-03 00:56:45 +03:00
EdgeStyleValue const& as_edge() const;
LibWeb: Add FilterValueListStyleValue This style value holds a list of CSS filter function calls e.g. blur(10px) invert() grayscale() It will be used to implement backdrop-filter, but the same style value can be used for the image filter property. (The name is a little awkward but it's referenced to as filter-value-list in the spec too).
2022-09-15 10:31:14 +03:00
FilterValueListStyleValue const& as_filter_value_list() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
FlexFlowStyleValue const& as_flex_flow() const;
FlexStyleValue const& as_flex() const;
FontStyleValue const& as_font() const;
LibWeb: Implement CSS Frequency class This corresponds to `<frequency>` in the grammar.
2022-02-21 20:49:47 +03:00
FrequencyStyleValue const& as_frequency() const;
LibWeb: Parse `grid-area` CSS property
2023-01-16 21:02:39 +03:00
GridAreaShorthandStyleValue const& as_grid_area_shorthand() const;
LibWeb: Parse `grid-template-areas` CSS property
2023-01-16 20:17:05 +03:00
GridTemplateAreaStyleValue const& as_grid_template_area() const;
LibWeb: Add GridTrackPlacementShorthandStyleValue Add GridTrackPlacementShorthandStyleValue for the use of grid-column and grid-row.
2022-08-24 13:25:56 +03:00
GridTrackPlacementShorthandStyleValue const& as_grid_track_placement_shorthand() const;
LibWeb: Add GridTrackPlacementStyleValue Add GridTrackPlacementStyleValue for the use of CSS properties grid-column-start, grid-column-end, grid-row-start, grid-row-end.
2022-08-24 13:31:00 +03:00
GridTrackPlacementStyleValue const& as_grid_track_placement() const;
LibWeb: Parse `grid-template` property
2023-04-29 20:32:56 +03:00
GridTrackSizeListShorthandStyleValue const& as_grid_track_size_list_shorthand() const;
LibWeb: Change name of GridTrackSizeListStyleValue Change the name of GridTrackSizeStyleValue to GridTrackSizeListStyleValue which is more accurate.
2023-04-29 18:59:07 +03:00
GridTrackSizeListStyleValue const& as_grid_track_size_list() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
IdentifierStyleValue const& as_identifier() const;
ImageStyleValue const& as_image() const;
InheritStyleValue const& as_inherit() const;
InitialStyleValue const& as_initial() const;
LengthStyleValue const& as_length() const;
LibWeb: Add LinearGradientStyleValue
2022-07-12 02:09:29 +03:00
LinearGradientStyleValue const& as_linear_gradient() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
ListStyleStyleValue const& as_list_style() const;
NumericStyleValue const& as_numeric() const;
OverflowStyleValue const& as_overflow() const;
LibWeb: Add PercentageStyleValue, and parse it This is in a slightly weird state, where Percentages are sometimes Lengths and sometimes not, which I will be cleaning up in subsequent commits, in an attempt not to change all of LibWeb in one go. :^)
2022-01-14 20:09:02 +03:00
PercentageStyleValue const& as_percentage() const;
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
PositionStyleValue const& as_position() const;
LibWeb: Implement RadialGradientStyleValue Adds a style value for `radial-gradient()`s and implements some helpers for resolving their properties.
2022-11-11 20:13:00 +03:00
RadialGradientStyleValue const& as_radial_gradient() const;
LibWeb: Parse rect style value Add ability to parse a rect when it is used as the value of a style property.
2022-07-31 19:46:35 +03:00
RectStyleValue const& as_rect() const;
LibWeb: Implement CSS Resolution class This corresponds to `<resolution>` in the grammar.
2022-02-21 20:51:01 +03:00
ResolutionStyleValue const& as_resolution() const;
LbWeb: Rename BoxShadowFoo => ShadowFoo The `text-shadow` property is almost identical to `box-shadow`: > Values are interpreted as for box-shadow [CSS-BACKGROUNDS-3]. > (But note that the inset keyword are not allowed.) So, let's use the same data structures and parsing code for both. :^)
2022-03-23 19:55:22 +03:00
ShadowStyleValue const& as_shadow() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
StringStyleValue const& as_string() const;
TextDecorationStyleValue const& as_text_decoration() const;
LibWeb: Implement CSS Time class This corresponds to `<time>` in the grammar.
2022-02-21 22:29:43 +03:00
TimeStyleValue const& as_time() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
TransformationStyleValue const& as_transformation() const;
LibWeb: Add new UnresolvedStyleValue class This represents a property value that hasn't been converted to a "proper" StyleValue yet. That is, it's either a custom property's value, or a value that includes `var()` references, (or both!) since neither of those can be fully resolved at parse time.
2021-12-03 15:28:14 +03:00
UnresolvedStyleValue const& as_unresolved() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
UnsetStyleValue const& as_unset() const;
LibWeb: Add URLStyleValue to represent general url() values This is primarily being added to support `fill: url(#gradient)` for SVGs.
2023-04-20 20:31:00 +03:00
URLStyleValue const& as_url() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
StyleValueList const& as_value_list() const;
LibWeb: Convert images to common AbstractImageStyleValue base This commit moves both the ImageStyleValue and LinearGradientStyleValue to a common base class of AbstractImageStyleValue. This abstracts getting the natural_width/height, loading/resolving, and painting the image. Now for 'free' you get: - Linear gradients working with the various background sizing/repeat properties. - Linear gradients working as list-markers :^) -- best feature ever! P.s. This commit is a little large as it's tricky to make this change incrementally without breaking things.
2022-07-31 03:11:59 +03:00
AbstractImageStyleValue& as_abstract_image() { return const_cast<AbstractImageStyleValue&>(const_cast<StyleValue const&>(*this).as_abstract_image()); }
LibWeb: Implement CSS Angle class This corresponds to `<angle>` in the grammar.
2022-02-21 20:43:30 +03:00
AngleStyleValue& as_angle() { return const_cast<AngleStyleValue&>(const_cast<StyleValue const&>(*this).as_angle()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BackgroundStyleValue& as_background() { return const_cast<BackgroundStyleValue&>(const_cast<StyleValue const&>(*this).as_background()); }
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
BackgroundRepeatStyleValue& as_background_repeat() { return const_cast<BackgroundRepeatStyleValue&>(const_cast<StyleValue const&>(*this).as_background_repeat()); }
LibWeb: Add BackgroundSizeStyleValue There's nothing really background-size-specific about this, but since there is no `<size>` value type defined in the CSS spec at this time, and background-size is the only user of it, I think this name makes more sense. But I'm not 100% convinced.
2021-11-05 15:18:23 +03:00
BackgroundSizeStyleValue& as_background_size() { return const_cast<BackgroundSizeStyleValue&>(const_cast<StyleValue const&>(*this).as_background_size()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BorderRadiusStyleValue& as_border_radius() { return const_cast<BorderRadiusStyleValue&>(const_cast<StyleValue const&>(*this).as_border_radius()); }
LibWeb: Add missing [as/is]_border_radius_shorthand() methods
2022-04-18 19:04:38 +03:00
BorderRadiusShorthandStyleValue& as_border_radius_shorthand() { return const_cast<BorderRadiusShorthandStyleValue&>(const_cast<StyleValue const&>(*this).as_border_radius_shorthand()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
BorderStyleValue& as_border() { return const_cast<BorderStyleValue&>(const_cast<StyleValue const&>(*this).as_border()); }
CalculatedStyleValue& as_calculated() { return const_cast<CalculatedStyleValue&>(const_cast<StyleValue const&>(*this).as_calculated()); }
ColorStyleValue& as_color() { return const_cast<ColorStyleValue&>(const_cast<StyleValue const&>(*this).as_color()); }
LibWeb: Add ConicGradientStyleValue This commit adds a simple style value (which is an abstract image) to represent conic-gradient()s. This commit also starts to factor out some reusable parts of the linear-gradient() style value for other gradient types.
2022-10-28 22:44:00 +03:00
ConicGradientStyleValue& as_conic_gradient() { return const_cast<ConicGradientStyleValue&>(const_cast<StyleValue const&>(*this).as_conic_gradient()); }
LibWeb: Parse the `content` property For now, we only understand `none`, `normal`, `<image>` and `<string>`. The various other functions and identifiers can be added later. We can *almost* use a StyleValueList for this, except it's divided into two parts - the content, and the optional "alt text". So, I've added a new StyleValue for it.
2022-02-23 22:56:25 +03:00
ContentStyleValue& as_content() { return const_cast<ContentStyleValue&>(const_cast<StyleValue const&>(*this).as_content()); }
LibWeb: Support multi-keyword syntax for CSS display property The Display class already supported all specific values, and now they will be parsed too. The display property now has a special type DisplayStyleValue.
2023-04-26 22:05:38 +03:00
DisplayStyleValue& as_display() { return const_cast<DisplayStyleValue&>(const_cast<StyleValue const&>(*this).as_display()); }
LibWeb: Add EdgeStyleValue This represents a single edge and offset, this will be needed for the values of background-position-x/y.
2023-04-03 00:56:45 +03:00
EdgeStyleValue& as_edge() { return const_cast<EdgeStyleValue&>(const_cast<StyleValue const&>(*this).as_edge()); }
LibWeb: Add FilterValueListStyleValue This style value holds a list of CSS filter function calls e.g. blur(10px) invert() grayscale() It will be used to implement backdrop-filter, but the same style value can be used for the image filter property. (The name is a little awkward but it's referenced to as filter-value-list in the spec too).
2022-09-15 10:31:14 +03:00
FilterValueListStyleValue& as_filter_value_list() { return const_cast<FilterValueListStyleValue&>(const_cast<StyleValue const&>(*this).as_filter_value_list()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
FlexFlowStyleValue& as_flex_flow() { return const_cast<FlexFlowStyleValue&>(const_cast<StyleValue const&>(*this).as_flex_flow()); }
FlexStyleValue& as_flex() { return const_cast<FlexStyleValue&>(const_cast<StyleValue const&>(*this).as_flex()); }
FontStyleValue& as_font() { return const_cast<FontStyleValue&>(const_cast<StyleValue const&>(*this).as_font()); }
LibWeb: Implement CSS Frequency class This corresponds to `<frequency>` in the grammar.
2022-02-21 20:49:47 +03:00
FrequencyStyleValue& as_frequency() { return const_cast<FrequencyStyleValue&>(const_cast<StyleValue const&>(*this).as_frequency()); }
LibWeb: Parse `grid-area` CSS property
2023-01-16 21:02:39 +03:00
GridAreaShorthandStyleValue& as_grid_area_shorthand() { return const_cast<GridAreaShorthandStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_area_shorthand()); }
LibWeb: Parse `grid-template-areas` CSS property
2023-01-16 20:17:05 +03:00
GridTemplateAreaStyleValue& as_grid_template_area() { return const_cast<GridTemplateAreaStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_template_area()); }
LibWeb: Add GridTrackPlacementShorthandStyleValue Add GridTrackPlacementShorthandStyleValue for the use of grid-column and grid-row.
2022-08-24 13:25:56 +03:00
GridTrackPlacementShorthandStyleValue& as_grid_track_placement_shorthand() { return const_cast<GridTrackPlacementShorthandStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_track_placement_shorthand()); }
LibWeb: Add GridTrackPlacementStyleValue Add GridTrackPlacementStyleValue for the use of CSS properties grid-column-start, grid-column-end, grid-row-start, grid-row-end.
2022-08-24 13:31:00 +03:00
GridTrackPlacementStyleValue& as_grid_track_placement() { return const_cast<GridTrackPlacementStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_track_placement()); }
LibWeb: Parse `grid-template` property
2023-04-29 20:32:56 +03:00
GridTrackSizeListShorthandStyleValue& as_grid_track_size_list_shorthand() { return const_cast<GridTrackSizeListShorthandStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_track_size_list_shorthand()); }
LibWeb: Change name of GridTrackSizeListStyleValue Change the name of GridTrackSizeStyleValue to GridTrackSizeListStyleValue which is more accurate.
2023-04-29 18:59:07 +03:00
GridTrackSizeListStyleValue& as_grid_track_size_list() { return const_cast<GridTrackSizeListStyleValue&>(const_cast<StyleValue const&>(*this).as_grid_track_size_list()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
IdentifierStyleValue& as_identifier() { return const_cast<IdentifierStyleValue&>(const_cast<StyleValue const&>(*this).as_identifier()); }
ImageStyleValue& as_image() { return const_cast<ImageStyleValue&>(const_cast<StyleValue const&>(*this).as_image()); }
InheritStyleValue& as_inherit() { return const_cast<InheritStyleValue&>(const_cast<StyleValue const&>(*this).as_inherit()); }
InitialStyleValue& as_initial() { return const_cast<InitialStyleValue&>(const_cast<StyleValue const&>(*this).as_initial()); }
LengthStyleValue& as_length() { return const_cast<LengthStyleValue&>(const_cast<StyleValue const&>(*this).as_length()); }
LibWeb: Add LinearGradientStyleValue
2022-07-12 02:09:29 +03:00
LinearGradientStyleValue& as_linear_gradient() { return const_cast<LinearGradientStyleValue&>(const_cast<StyleValue const&>(*this).as_linear_gradient()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
ListStyleStyleValue& as_list_style() { return const_cast<ListStyleStyleValue&>(const_cast<StyleValue const&>(*this).as_list_style()); }
NumericStyleValue& as_numeric() { return const_cast<NumericStyleValue&>(const_cast<StyleValue const&>(*this).as_numeric()); }
OverflowStyleValue& as_overflow() { return const_cast<OverflowStyleValue&>(const_cast<StyleValue const&>(*this).as_overflow()); }
LibWeb: Add PercentageStyleValue, and parse it This is in a slightly weird state, where Percentages are sometimes Lengths and sometimes not, which I will be cleaning up in subsequent commits, in an attempt not to change all of LibWeb in one go. :^)
2022-01-14 20:09:02 +03:00
PercentageStyleValue& as_percentage() { return const_cast<PercentageStyleValue&>(const_cast<StyleValue const&>(*this).as_percentage()); }
LibWeb: Parse CSS `background-position` property This is done a bit differently from other properties: using a TokenStream instead of just a Vector of ComponentValues. The reason for this is, we can then use call the same function when parsing the `background` shorthand. Otherwise, we would have to know in advance how many values to pass down, which basically would involve duplicating the `background-position` parsing code inside `background`. The StyleValue is PositionStyleValue, since it represents a `<position>`: https://www.w3.org/TR/css-values-4/#typedef-position Unfortunately, background-position's parsing is a bit different from `<position>`'s, (background-position allows 3-value syntax and `<position>` doesn't) so we'll need to come back and write a different parsing function for that later.
2021-10-31 19:02:29 +03:00
PositionStyleValue& as_position() { return const_cast<PositionStyleValue&>(const_cast<StyleValue const&>(*this).as_position()); }
LibWeb: Implement RadialGradientStyleValue Adds a style value for `radial-gradient()`s and implements some helpers for resolving their properties.
2022-11-11 20:13:00 +03:00
RadialGradientStyleValue& as_radial_gradient() { return const_cast<RadialGradientStyleValue&>(const_cast<StyleValue const&>(*this).as_radial_gradient()); }
LibWeb: Parse rect style value Add ability to parse a rect when it is used as the value of a style property.
2022-07-31 19:46:35 +03:00
RectStyleValue& as_rect() { return const_cast<RectStyleValue&>(const_cast<StyleValue const&>(*this).as_rect()); }
LibWeb: Implement CSS Resolution class This corresponds to `<resolution>` in the grammar.
2022-02-21 20:51:01 +03:00
ResolutionStyleValue& as_resolution() { return const_cast<ResolutionStyleValue&>(const_cast<StyleValue const&>(*this).as_resolution()); }
LbWeb: Rename BoxShadowFoo => ShadowFoo The `text-shadow` property is almost identical to `box-shadow`: > Values are interpreted as for box-shadow [CSS-BACKGROUNDS-3]. > (But note that the inset keyword are not allowed.) So, let's use the same data structures and parsing code for both. :^)
2022-03-23 19:55:22 +03:00
ShadowStyleValue& as_shadow() { return const_cast<ShadowStyleValue&>(const_cast<StyleValue const&>(*this).as_shadow()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
StringStyleValue& as_string() { return const_cast<StringStyleValue&>(const_cast<StyleValue const&>(*this).as_string()); }
TextDecorationStyleValue& as_text_decoration() { return const_cast<TextDecorationStyleValue&>(const_cast<StyleValue const&>(*this).as_text_decoration()); }
LibWeb: Implement CSS Time class This corresponds to `<time>` in the grammar.
2022-02-21 22:29:43 +03:00
TimeStyleValue& as_time() { return const_cast<TimeStyleValue&>(const_cast<StyleValue const&>(*this).as_time()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
TransformationStyleValue& as_transformation() { return const_cast<TransformationStyleValue&>(const_cast<StyleValue const&>(*this).as_transformation()); }
LibWeb: Add new UnresolvedStyleValue class This represents a property value that hasn't been converted to a "proper" StyleValue yet. That is, it's either a custom property's value, or a value that includes `var()` references, (or both!) since neither of those can be fully resolved at parse time.
2021-12-03 15:28:14 +03:00
UnresolvedStyleValue& as_unresolved() { return const_cast<UnresolvedStyleValue&>(const_cast<StyleValue const&>(*this).as_unresolved()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
UnsetStyleValue& as_unset() { return const_cast<UnsetStyleValue&>(const_cast<StyleValue const&>(*this).as_unset()); }
LibWeb: Add URLStyleValue to represent general url() values This is primarily being added to support `fill: url(#gradient)` for SVGs.
2023-04-20 20:31:00 +03:00
URLStyleValue& as_url() { return const_cast<URLStyleValue&>(const_cast<StyleValue const&>(*this).as_url()); }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
StyleValueList& as_value_list() { return const_cast<StyleValueList&>(const_cast<StyleValue const&>(*this).as_value_list()); }
LibWeb: Simplify StyleValue API now that `auto` isn't a length Now that LengthStyleValue never contains `auto`, IdentifierStyleValue is the only type that can hold an identifier. This lets us remove a couple of virtual methods from StyleValue. I've kept `has_auto()` and `to_identifier()` for convenience, but they are now simple non-virtual methods.
2023-04-19 14:00:38 +03:00
bool has_auto() const;
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
virtual bool has_color() const { return false; }
virtual bool has_length() const { return false; }
LibWeb: Parse rect style value Add ability to parse a rect when it is used as the value of a style property.
2022-07-31 19:46:35 +03:00
virtual bool has_rect() const { return false; }
LibWeb: Clarify StyleValue API with new naming scheme This does a few things, that are hard to separate. For a while now, it's been confuzing what `StyleValue::is_foo()` actually means. It sometimes was used to check the type, and sometimes to see if it could return a certain value type. The new naming scheme is: - `is_length()` - is it a LengthStyleValue? - `as_length()` - casts it to LengthStyleValue - `has_length()` - can it return a Length? - `to_length()` - gets the internal value out (eg, Length) This also means, no more `static_cast<LengthStyleValue const&>(*this)` stuff when dealing with StyleValues. :^) Hopefully this will be a bit clearer going forward. There are lots of places using the original methods, so I'll be going through them to hopefully catch any issues.
2021-09-23 21:54:19 +03:00
virtual bool has_number() const { return false; }
LibWeb: Distinguish between integer and float in NumericStyleValue We have this information when parsing, and some properties specifically only allow integers, so it makes sense to keep that around.
2021-10-19 18:43:56 +03:00
virtual bool has_integer() const { return false; }
LibWeb: Add range-checking to property_accepts_value() For `number` and `integer` types, you can add a range afterwards to add a range check, using similar syntax to that used in the CSS specs. For example: ```json "font-weight": { ... "valid-types": [ "number [1,1000]" ], ... } ``` This limits any numbers to the range `1 <= n <= 1000`.
2021-09-23 14:45:08 +03:00
LibWeb: Propagate errors from absolutizing StyleValues
2023-05-01 22:09:05 +03:00
virtual ErrorOr<ValueComparingNonnullRefPtr<StyleValue const>> absolutized(CSSPixelRect const& viewport_rect, Length::FontMetrics const& font_metrics, Length::FontMetrics const& root_font_metrics) const;
LibWeb: Make StyleValue absolutization non-destructive Instead of awkwardly visiting and mutating lengths inside StyleValues, we now simply create a new StyleValue instead. This fixes an issue where inherited relative lengths could get absolutized using a parent as reference, and then not having the correct values when used in a child context.
2022-02-26 03:35:25 +03:00
LibWeb: Allow doing .to_color() on a StyleValue without a layout node This will be needed to access the color of a stop from a SVG gradient <stop> element (which does not participate in layout, so does not have a layout node).
2023-04-19 20:31:00 +03:00
virtual Color to_color(Optional<Layout::NodeWithStyle const&>) const { return {}; }
LibWeb: Simplify StyleValue API now that `auto` isn't a length Now that LengthStyleValue never contains `auto`, IdentifierStyleValue is the only type that can hold an identifier. This lets us remove a couple of virtual methods from StyleValue. I've kept `has_auto()` and `to_identifier()` for convenience, but they are now simple non-virtual methods.
2023-04-19 14:00:38 +03:00
ValueID to_identifier() const;
LibWeb: VERIFY when getting a length from an invalid StyleValue
2022-02-18 17:48:01 +03:00
virtual Length to_length() const { VERIFY_NOT_REACHED(); }
LibWeb: Distinguish between integer and float in NumericStyleValue We have this information when parsing, and some properties specifically only allow integers, so it makes sense to keep that around.
2021-10-19 18:43:56 +03:00
virtual float to_number() const { return 0; }
virtual float to_integer() const { return 0; }
LibWeb+WebContent: Use new String class in CSS::StyleValue Converts uses of DeprecatedString to String in StyleValue, and patches surrounding files that depend on these functions.
2023-01-06 21:02:26 +03:00
virtual ErrorOr<String> to_string() const = 0;
LibHTML: Finish the block width calculation Also add horizontal box values to the layout tree dump.
2019-08-18 09:09:56 +03:00
LibWeb: Move resolution of font weights and slopes to StyleValue This isn't exactly ideal factoring (though I'm not sure what is) but this will make it possible to reuse this code in the parser.
2023-05-24 16:28:09 +03:00
[[nodiscard]] int to_font_weight() const;
[[nodiscard]] int to_font_slope() const;
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
virtual bool equals(StyleValue const& other) const = 0;
bool operator==(StyleValue const& other) const
{
return this->equals(other);
}
LibWeb: Virtualize StyleValue equality check And use this to simplify comparing two IdentifierStyleValues.
2020-12-14 17:04:13 +03:00
LibHTML: Add the outline of a CSS stylesheet object graph.
2019-06-21 00:25:25 +03:00
protected:
explicit StyleValue(Type);
private:
Type m_type { Type::Invalid };
};
LibHTML: Implement enough of the CSS parser to parse the default stylesheet.
2019-06-22 22:48:21 +03:00
LibWeb: Use default equality operators for StyleValues This removes a load of manually implemented equality operators. This is done with a little pattern where all properties of a StyleValue are placed inside a Properties member struct, with a defaulted equality operator. This is then used to do the actual StyleValue compare. There is also a CTRP class to avoid manually implementing the virtual operator==()s for all StyleValues.
2023-02-11 21:12:00 +03:00
template<typename T>
struct StyleValueWithDefaultOperators : public StyleValue {
using StyleValue::StyleValue;
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
virtual bool equals(StyleValue const& other) const override
LibWeb: Use default equality operators for StyleValues This removes a load of manually implemented equality operators. This is done with a little pattern where all properties of a StyleValue are placed inside a Properties member struct, with a defaulted equality operator. This is then used to do the actual StyleValue compare. There is also a CTRP class to avoid manually implementing the virtual operator==()s for all StyleValues.
2023-02-11 21:12:00 +03:00
{
if (type() != other.type())
return false;
auto const& typed_other = static_cast<T const&>(other);
LibWeb: Replace `RefPtr` with `ValueComparingRefPtr` in StyleValue Like the name suggests this pointer type compares its pointees by value rather than just by the pointer. This is needed for the defaulted struct Properties equality operator. This commit also contains a few changes to StyleValue such as replacing the operator==()s with a .equals() again. This is done to avoid the new reversed operator==()s ambiguity in C++20.
2023-02-20 03:41:51 +03:00
return static_cast<T const&>(*this).properties_equal(typed_other);
LibWeb: Use default equality operators for StyleValues This removes a load of manually implemented equality operators. This is done with a little pattern where all properties of a StyleValue are placed inside a Properties member struct, with a defaulted equality operator. This is then used to do the actual StyleValue compare. There is also a CTRP class to avoid manually implementing the virtual operator==()s for all StyleValues.
2023-02-11 21:12:00 +03:00
}
};
LibWeb: Move everything into the Web namespace
2020-03-07 12:27:02 +03:00
}
LibWeb: Allow comma- or space-separated StyleValueLists This lets us produce valid CSS in its to_string() method, instead of always adding commas as before. :^) Also, finally added a Formatter for StyleValues.
2022-02-02 23:53:55 +03:00
template<>
struct AK::Formatter<Web::CSS::StyleValue> : Formatter<StringView> {
ErrorOr<void> format(FormatBuilder& builder, Web::CSS::StyleValue const& style_value)
{
LibWeb+WebContent: Use new String class in CSS::StyleValue Converts uses of DeprecatedString to String in StyleValue, and patches surrounding files that depend on these functions.
2023-01-06 21:02:26 +03:00
return Formatter<StringView>::format(builder, TRY(style_value.to_string()));
LibWeb: Allow comma- or space-separated StyleValueLists This lets us produce valid CSS in its to_string() method, instead of always adding commas as before. :^) Also, finally added a Formatter for StyleValues.
2022-02-02 23:53:55 +03:00
}
};
Reference in New Issue Copy Permalink