LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity
b05078b610
ladybird/Userland/Libraries/LibGUI/IconView.h

168 lines
5.5 KiB
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 11:24:48 +03:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
*/
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
#pragma once
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
#include <AK/IterationDecision.h>
LibGUI: Remove leading G from filenames
2020-02-06 22:33:02 +03:00
#include <LibGUI/AbstractView.h>
LibGUI: Add forwarding header This patch adds <LibGUI/Forward.h> and uses it a bunch. It also dragged various header dependency reduction changes into it.
2020-02-16 11:17:49 +03:00
#include <LibGUI/Forward.h>
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
#include <LibGUI/Variant.h>
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 17:07:41 +03:00
namespace GUI {
LibGUI: The UI calls it 'Icon view', fix the name in the code
2020-05-01 03:09:04 +03:00
class IconView : public AbstractView {
C_OBJECT(IconView)
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
public:
LibGUI: The UI calls it 'Icon view', fix the name in the code
2020-05-01 03:09:04 +03:00
virtual ~IconView() override;
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
LibGUI: Support top-to-bottom flow in IconView Sometimes you might want your icons to flow from top-to-bottom instead of from left-to-right. :^)
2020-12-27 16:44:49 +03:00
enum class FlowDirection {
LeftToRight,
TopToBottom,
};
FlowDirection flow_direction() const { return m_flow_direction; }
void set_flow_direction(FlowDirection);
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
int horizontal_padding() const { return m_horizontal_padding; }
LibGUI: Implement the virtual IconView::scroll_into_view() This is virtual in AbstractView so let's not shadow it with an IconView specific variant.
2020-09-01 16:41:56 +03:00
virtual void scroll_into_view(const ModelIndex&, bool scroll_horizontally = true, bool scroll_vertically = true) override;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 11:57:59 +03:00
Gfx::IntSize effective_item_size() const { return m_effective_item_size; }
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
LibGUI: add 'always_wrap_item_labels' property to IconView. In some circumstances (like template selection dialogs,) displaying as much item label as possible, on all items, may be desired. The default setting is 'false', which matches the default behaviour from before; only wrapping on hover or selection.
2021-01-29 08:26:04 +03:00
bool always_wrap_item_labels() const { return m_always_wrap_item_labels; }
void set_always_wrap_item_labels(bool value) { m_always_wrap_item_labels = value; }
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
int model_column() const { return m_model_column; }
void set_model_column(int column) { m_model_column = column; }
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 11:57:59 +03:00
virtual ModelIndex index_at_event_position(const Gfx::IntPoint&) const override;
LibGUI: Support inline editing in GUI::IconView IconView now responds to the editing key (F2) if the view is editable. It does feel a little bit weird to have content_rect() return the text rect for an item, and not the whole item rect. This internal API could probably be better.
2020-09-24 12:40:19 +03:00
virtual Gfx::IntRect content_rect(const ModelIndex&) const override;
LibGUI: Move index_at_event_position() up to GAbstractView It's now an abstract (pure virtual) public method in GAbstractView that individual widgets have to implement. This will allow us to move more selection-related logic into GAbstractView in order to share it between implementations.
2020-01-22 18:13:01 +03:00
LibGUI: Make descendants of AbstractView define their own select_all() (#1201) AbstractView does not know which column it's displaying which makes it impossible to implement the select_all functionality up there. Now descendants override the pure virtual select_all method and implement it themselves.
2020-02-25 18:03:15 +03:00
virtual void select_all() override;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
private:
LibGUI: The UI calls it 'Icon view', fix the name in the code
2020-05-01 03:09:04 +03:00
IconView();
LibGUI: Convert GItemView to ObjectPtr
2019-09-21 16:47:58 +03:00
LibGUI: Remove `AbstractView::did_update_model()' ...and use `ModelClient::model_did_update()' instead. This makes AbstractView a ModelClient (which it always was anyway).
2020-11-26 10:40:14 +03:00
virtual void model_did_update(unsigned flags) override;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 17:07:41 +03:00
virtual void paint_event(PaintEvent&) override;
virtual void second_paint_event(PaintEvent&) override;
virtual void resize_event(ResizeEvent&) override;
virtual void mousedown_event(MouseEvent&) override;
virtual void mousemove_event(MouseEvent&) override;
virtual void mouseup_event(MouseEvent&) override;
LibGUI: Improve and simplify IconView item name wrapping Move the wrapping logic to get_item_rects(). This makes mouse events able to hit the wrapped labels, and various other little things stop glitching out as well. Also, instead of having a per-line width when wrapping icon names, make the text rect wide enough to fit every line.
2020-10-27 18:10:30 +03:00
virtual void did_change_hovered_index(const ModelIndex& old_index, const ModelIndex& new_index) override;
virtual void did_change_cursor_index(const ModelIndex& old_index, const ModelIndex& new_index) override;
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
LibGUI: Teach IconView to use AbstractView::move_cursor() This makes it possible to manipulate the cursor programmatically via the AbstractView interface.
2020-09-01 15:43:16 +03:00
virtual void move_cursor(CursorMovement, SelectionUpdate) override;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
struct ItemData {
Gfx::IntRect text_rect;
Gfx::IntRect icon_rect;
int icon_offset_y;
int text_offset_y;
LibGUI: Improve and simplify IconView item name wrapping Move the wrapping logic to get_item_rects(). This makes mouse events able to hit the wrapped labels, and various other little things stop glitching out as well. Also, instead of having a per-line width when wrapping icon names, make the text rect wide enough to fit every line.
2020-10-27 18:10:30 +03:00
String text;
Vector<StringView> wrapped_text_lines;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
ModelIndex index;
bool valid { false };
bool selected { false }; // always valid
bool selection_toggled; // only used as a temporary marker
bool is_valid() const { return valid; }
void invalidate()
{
valid = false;
LibGUI: Improve and simplify IconView item name wrapping Move the wrapping logic to get_item_rects(). This makes mouse events able to hit the wrapped labels, and various other little things stop glitching out as well. Also, instead of having a per-line width when wrapping icon names, make the text rect wide enough to fit every line.
2020-10-27 18:10:30 +03:00
text = {};
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
}
bool is_intersecting(const Gfx::IntRect& rect) const
{
Everywhere: Rename ASSERT => VERIFY (...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED) Since all of these checks are done in release builds as well, let's rename them to VERIFY to prevent confusion, as everyone is used to assertions being compiled out in release. We can introduce a new ASSERT macro that is specifically for debug checks, but I'm doing this wholesale conversion first since we've accumulated thousands of these already, and it's not immediately obvious which ones are suitable for ASSERT.
2021-02-23 22:42:32 +03:00
VERIFY(valid);
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
return icon_rect.intersects(rect) || text_rect.intersects(rect);
}
bool is_containing(const Gfx::IntPoint& point) const
{
Everywhere: Rename ASSERT => VERIFY (...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED) Since all of these checks are done in release builds as well, let's rename them to VERIFY to prevent confusion, as everyone is used to assertions being compiled out in release. We can introduce a new ASSERT macro that is specifically for debug checks, but I'm doing this wholesale conversion first since we've accumulated thousands of these already, and it's not immediately obvious which ones are suitable for ASSERT.
2021-02-23 22:42:32 +03:00
VERIFY(valid);
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
return icon_rect.contains(point) || text_rect.contains(point);
}
LibGUI: Improve IconView rubberband performance Rather than invalidating the entire window, which is very expensive on the transparent desktop widget, just invalidate the areas that actually need updating.
2021-02-16 05:30:47 +03:00
Gfx::IntRect rect() const
{
return text_rect.united(icon_rect);
}
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
};
template<typename Function>
LibGUI: Move some large IconView internal helpers to the .cpp file Stuff that's only used internally by the class is nice to keep out of the header when possible.
2020-12-27 13:34:38 +03:00
IterationDecision for_each_item_intersecting_rect(const Gfx::IntRect&, Function) const;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
template<typename Function>
LibGUI: Move some large IconView internal helpers to the .cpp file Stuff that's only used internally by the class is nice to keep out of the header when possible.
2020-12-27 13:34:38 +03:00
IterationDecision for_each_item_intersecting_rects(const Vector<Gfx::IntRect>&, Function) const;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
void column_row_from_content_position(const Gfx::IntPoint& content_position, int& row, int& column) const
{
row = max(0, min(m_visual_row_count - 1, content_position.y() / effective_item_size().height()));
column = max(0, min(m_visual_column_count - 1, content_position.x() / effective_item_size().width()));
}
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
int item_count() const;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 11:57:59 +03:00
Gfx::IntRect item_rect(int item_index) const;
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
void update_content_size();
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
void update_item_rects(int item_index, ItemData& item_data) const;
void get_item_rects(int item_index, ItemData& item_data, const Gfx::Font&) const;
LibGUI: Implement IconView auto-scrolling when trying to select items out of view If selecting in a large icon view, and dragging the mouse outside of the widget, or close to the border of it, start scrolling automatically. This allows for selecting large amount of items that exceed the amount that can be displayed.
2020-07-08 20:42:32 +03:00
bool update_rubber_banding(const Gfx::IntPoint&);
void scroll_out_of_view_timer_fired();
LibGUI: Support top-to-bottom flow in IconView Sometimes you might want your icons to flow from top-to-bottom instead of from left-to-right. :^)
2020-12-27 16:44:49 +03:00
int items_per_page() const;
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
LibGUI: Remove some unused cruft from GUI::IconView
2021-04-23 18:40:10 +03:00
void rebuild_item_cache() const;
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
int model_index_to_item_index(const ModelIndex& model_index) const
{
Everywhere: Rename ASSERT => VERIFY (...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED) Since all of these checks are done in release builds as well, let's rename them to VERIFY to prevent confusion, as everyone is used to assertions being compiled out in release. We can introduce a new ASSERT macro that is specifically for debug checks, but I'm doing this wholesale conversion first since we've accumulated thousands of these already, and it's not immediately obvious which ones are suitable for ASSERT.
2021-02-23 22:42:32 +03:00
VERIFY(model_index.row() < item_count());
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
return model_index.row();
}
virtual void did_update_selection() override;
virtual void clear_selection() override;
virtual void add_selection(const ModelIndex& new_index) override;
virtual void set_selection(const ModelIndex& new_index) override;
virtual void toggle_selection(const ModelIndex& new_index) override;
ItemData& get_item_data(int) const;
ItemData* item_data_from_content_position(const Gfx::IntPoint&) const;
void do_clear_selection();
bool do_add_selection(ItemData&);
void add_selection(ItemData&);
void remove_selection(ItemData&);
void toggle_selection(ItemData&);
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
int m_horizontal_padding { 5 };
int m_model_column { 0 };
int m_visual_column_count { 0 };
int m_visual_row_count { 0 };
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 11:57:59 +03:00
Gfx::IntSize m_effective_item_size { 80, 80 };
LibGUI: Add basic rubber band selection in GItemView
2020-01-04 23:18:48 +03:00
LibGUI: add 'always_wrap_item_labels' property to IconView. In some circumstances (like template selection dialogs,) displaying as much item label as possible, on all items, may be desired. The default setting is 'false', which matches the default behaviour from before; only wrapping on hover or selection.
2021-01-29 08:26:04 +03:00
bool m_always_wrap_item_labels { false };
LibGUI: Add basic rubber band selection in GItemView
2020-01-04 23:18:48 +03:00
bool m_rubber_banding { false };
LibGUI: Implement IconView auto-scrolling when trying to select items out of view If selecting in a large icon view, and dragging the mouse outside of the widget, or close to the border of it, start scrolling automatically. This allows for selecting large amount of items that exceed the amount that can be displayed.
2020-07-08 20:42:32 +03:00
RefPtr<Core::Timer> m_out_of_view_timer;
Gfx::IntPoint m_out_of_view_position;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 11:57:59 +03:00
Gfx::IntPoint m_rubber_band_origin;
Gfx::IntPoint m_rubber_band_current;
LibGUI: Indicate ItemView drag acceptance with a little rectangle If an index accepts a drag, we now draw a little rectangle around it when the drag moves over it.
2020-02-13 23:50:50 +03:00
LibGUI: Support top-to-bottom flow in IconView Sometimes you might want your icons to flow from top-to-bottom instead of from left-to-right. :^)
2020-12-27 16:44:49 +03:00
FlowDirection m_flow_direction { FlowDirection::LeftToRight };
LibGUI: Improve IconView performance with large selections This implements the following optimizations: * Rather than clearing a HashTable of selected items and re-populating it every time the selection rectangle changes, determine the delta by only examining the items that might be in the area where the selection may have changed compared to the previous area. Then only add/remove selection items as needed. * When painting, only query and paint the items actually visible. Also, keep a local cache of item information such as calculated rectangles and selection state, so it doesn't have to be calculated over and over again.
2020-07-11 16:02:03 +03:00
mutable Vector<ItemData> m_item_data_cache;
mutable int m_selected_count_cache { 0 };
mutable int m_first_selected_hint { 0 };
mutable bool m_item_data_cache_valid { false };
bool m_changing_selection { false };
LibGUI: Scroll selection into view when the IconView is first laid out If we set selection before the IconView is laid out, it has no size. So it can't correctly calculate where to scroll. Forcing scroll after the first resize fixes that.
2021-03-02 00:32:27 +03:00
bool m_had_valid_size { false };
LibGUI: Add a GItemView class. This is a GAbstractView subclass that implements a icon-based view onto a GModel. It still need a bunch of work, but it's in basic usable shape.
2019-03-23 05:53:51 +03:00
};
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 17:07:41 +03:00
}
Reference in New Issue Copy Permalink