LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-07 19:57:45 +03:00
Code Issues Packages Projects Releases Wiki Activity
d1ed04a6cb
ladybird/Userland/Applications/Browser/InspectorWidget.h

57 lines
1.6 KiB
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
Browser: Replace inspector's dom_node_id with a Selection struct
2022-03-04 19:16:57 +03:00
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
Applications: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-02-10 22:28:48 +03:00
* Copyright (c) 2022, the SerenityOS developers.
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 11:24:48 +03:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 11:38:21 +03:00
*/
Meta: Add a script check the presence of "#pragma once" in header files .. and make travis run it. I renamed check-license-headers.sh to check-style.sh and expanded it so that it now also checks for the presence of "#pragma once" in .h files. It also checks the presence of a (single) blank line above and below the "#pragma once" line. I also added "#pragma once" to all the files that need it: even the ones we are not check. I also added/removed blank lines in order to make the script not fail. I also ran clang-format on the files I modified.
2020-05-28 21:40:53 +03:00
#pragma once
Browser+LibWeb: Add an Element size preview widget to inspector This Adds an element size preview widget to the inspector widget in a new tab. This functions similar to chrome and firefox and shows the margin, border, padding, and content size of the selected element in the inspector. The colors for the size preview widget are taken from the chrome browser.
2022-02-27 03:38:12 +03:00
#include "ElementSizePreviewWidget.h"
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
#include <AK/StringView.h>
LibGUI: Remove leading G from filenames
2020-02-06 22:33:02 +03:00
#include <LibGUI/Widget.h>
LibWeb: Rename directory LibHTML => LibWeb Let's rename this to LibWeb since it aims to provide more parts of the web platform than just HTML. :^)
2020-03-07 12:32:51 +03:00
#include <LibWeb/Forward.h>
Browser+LibWeb: Add an Element size preview widget to inspector This Adds an element size preview widget to the inspector widget in a new tab. This functions similar to chrome and firefox and shows the margin, border, padding, and content size of the selected element in the inspector. The colors for the size preview widget are taken from the chrome browser.
2022-02-27 03:38:12 +03:00
#include <LibWeb/Layout/BoxModelMetrics.h>
LibWebView: Move OutOfProcessWebView to a new LibWebView library Also moves WebContentClient and the references to the generated IPC descriptions, since they are all components of OutOfProcessWebView. This patch has no functional changes.
2022-04-30 11:46:33 +03:00
#include <LibWebView/Forward.h>
Browser: Add a missing include in InspectorWidget
2023-02-25 20:42:57 +03:00
Browser: Move InspectorWidget into the Browser namespace
2020-05-08 22:38:30 +03:00
namespace Browser {
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 17:07:41 +03:00
class InspectorWidget final : public GUI::Widget {
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
C_OBJECT(InspectorWidget)
Browser: Replace inspector's dom_node_id with a Selection struct
2022-03-04 19:16:57 +03:00
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
public:
static NonnullRefPtr<InspectorWidget> create(WebView::OutOfProcessWebView& content_view);
virtual ~InspectorWidget();
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
void inspect();
void reset();
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
Browser: Reset the DOM Inspector's state when re-opening it This resets the DOM Inspector to a default state when re-opening it, instead of it displaying the previous selection and properties, which may be outdated. This is closer to how Chrome and Firefox behave. Eventually, it probably makes sense to copy their behavior of selecting the `<body>` element by default.
2021-08-27 22:21:30 +03:00
void select_default_node();
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
void select_hovered_node();
Browser: Implement "Inspect Element" context menu action This is finally working for OOPWV! :^)
2021-08-27 19:40:25 +03:00
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
private:
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
explicit InspectorWidget(WebView::OutOfProcessWebView& content_view);
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
Browser+WebContent: Fixup some DOM inspector weirdness This fixes a few things I noticed whilst working on the inspector for Ladybird. 1. The computed and resolved values were being passed swapped around from the inspect_dom_node() IPC call. I.e. computed values were passed as resolved values and vice versa. This was then fixed by swapping them again in the InspectorWidget (two errors canceled out). 2. Resolved values were called "specified values" seemingly only in the inspect_dom_node() IPC calls. This was a little confusing so I've renamed them to back to "resolved values" for consistency. 3. The inspector took and stored the DOM JSON strings unnecessarily, all the models immediately parse the JSON and don't need the strings to hang around.
2022-12-19 01:49:09 +03:00
void load_style_json(StringView computed_values_json, StringView resolved_values_json, StringView custom_properties_json);
Browser: Reset the DOM Inspector's state when re-opening it This resets the DOM Inspector to a default state when re-opening it, instead of it displaying the previous selection and properties, which may be outdated. This is closer to how Chrome and Firefox behave. Eventually, it probably makes sense to copy their behavior of selecting the `<body>` element by default.
2021-08-27 22:21:30 +03:00
void clear_style_json();
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
void update_node_box_model(StringView node_box_sizing_json);
Browser: Fix crash if clicking on non-visible nodes in the inspector If you attempt to inspect a non-visible dom node it will hit various assertions as things like style have not been computed. With this change attempting to inspect these nodes will simply clear the style and box model tabs.
2022-07-03 18:56:26 +03:00
void clear_node_box_model();
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 23:30:11 +03:00
Browser: Port the Inspector to the WebView InspectorClient
2023-11-24 03:50:16 +03:00
void update_aria_properties_state_model(StringView aria_properties_state_json);
RefPtr<WebView::OutOfProcessWebView> m_inspector_view;
OwnPtr<WebView::InspectorClient> m_inspector_client;
Browser: Display style properties in DOM Inspector This makes use of the new `inspect_dom_node()` IPC call.
2021-09-02 14:05:32 +03:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 17:07:41 +03:00
RefPtr<GUI::TableView> m_computed_style_table_view;
Browser: Rename Inspector table view member names to match contents
2022-03-15 22:00:51 +03:00
RefPtr<GUI::TableView> m_resolved_style_table_view;
Browser+LibWeb+WebContent: Add variables display to Inspector This allows us to see which custom properties apply to a given element, which previously wasn't shown.
2021-12-08 14:51:26 +03:00
RefPtr<GUI::TableView> m_custom_properties_table_view;
Browser+LibWebView: Load and Display ARIA Properites and State The inspector widget now has a new ARIA tab which displays an individual element's ARIA properties and state. The view itself is pretty basic for now, just being a table- there is definitely room for some better UX here but it's enough for a first cut.
2023-05-21 16:52:03 +03:00
RefPtr<GUI::TableView> m_aria_properties_state_view;
Browser+LibWeb: Add an Element size preview widget to inspector This Adds an element size preview widget to the inspector widget in a new tab. This functions similar to chrome and firefox and shows the margin, border, padding, and content size of the selected element in the inspector. The colors for the size preview widget are taken from the chrome browser.
2022-02-27 03:38:12 +03:00
RefPtr<ElementSizePreviewWidget> m_element_size_view;
Web::Layout::BoxModelMetrics m_node_box_sizing;
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 16:55:19 +03:00
};
Browser: Move InspectorWidget into the Browser namespace
2020-05-08 22:38:30 +03:00
}
Reference in New Issue Copy Permalink