LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-17 01:10:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Meta: Suppress rule V1076 in PVS-Studio Static Analysis

Browse Source 
This rule attempts to flag invisible Unicode characters which would
potentially be used by an attacker to hide code that humans can't see.
https://pvs-studio.com/en/docs/warnings/v1076/

AKA the "Trojan Source" attack: https://arxiv.org/abs/2111.00169

Unfortunately our `LibUnicode` source code contains these hidden
characters as they are part of the Unicode character set that the
library exposes. So we have, and will always have 100s of false
positives.
This commit is contained in:
Brian Gianforcaro 2022-02-12 07:14:41 -08:00 committed by Idan Horowitz
parent d1c4a94659
commit 01cd838a4c
Notes: sideshowbarker 2024-07-17 18:57:41 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/01cd838a4c
Pull-request: https://github.com/SerenityOS/serenity/pull/12463
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/workflows/pvs-studio-static-analysis.yml vendored
View File

@ -101,11 +101,14 @@ jobs:
# - We are the system headers: V677 Custom declaration of a standard '<example>' type. The declaration from system header files should be used instead.
# - We have no choice: V1061 Extending the 'std' namespace may result in undefined behavior.
# - TRY(..) macro breaks this rule: V530 The return value of function 'release_value' is required to be utilized.
# - False positives: V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference.
# - False positives:
# V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference.
# V1076 Code contains invisible characters that may alter its logic.
#
- name: Filter PVS Log
working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }}
run: |
pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 project.plog
pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 project.plog
pvs-studio-analyzer filter-suppressed project.plog
- name: Print PVS Log