mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 05:25:32 +03:00
LibJS: Implement BigInt IsLessThan according to the spec
This commit is contained in:
parent
9ad3debf35
commit
02b7bf34c9
Notes:
sideshowbarker
2024-07-17 19:55:25 +09:00
Author: https://github.com/trflynn89 Commit: https://github.com/SerenityOS/serenity/commit/02b7bf34c99 Pull-request: https://github.com/SerenityOS/serenity/pull/12228 Reviewed-by: https://github.com/linusg ✅
@ -48,14 +48,6 @@ static inline bool same_type_for_equality(const Value& lhs, const Value& rhs)
|
||||
|
||||
static const Crypto::SignedBigInteger BIGINT_ZERO { 0 };
|
||||
|
||||
static bool is_valid_bigint_value(StringView string)
|
||||
{
|
||||
string = string.trim_whitespace();
|
||||
if (string.length() > 1 && (string[0] == '-' || string[0] == '+'))
|
||||
string = string.substring_view(1, string.length() - 1);
|
||||
return all_of(string, [](auto ch) { return isdigit(ch); });
|
||||
}
|
||||
|
||||
ALWAYS_INLINE bool both_number(const Value& lhs, const Value& rhs)
|
||||
{
|
||||
return lhs.is_number() && rhs.is_number();
|
||||
@ -1513,23 +1505,23 @@ ThrowCompletionOr<TriState> is_less_than(GlobalObject& global_object, bool left_
|
||||
}
|
||||
|
||||
if (x_primitive.is_bigint() && y_primitive.is_string()) {
|
||||
auto& y_string = y_primitive.as_string().string();
|
||||
if (!is_valid_bigint_value(y_string))
|
||||
auto y_bigint = y_primitive.string_to_bigint(global_object);
|
||||
if (!y_bigint.has_value())
|
||||
return TriState::Unknown;
|
||||
if (x_primitive.as_bigint().big_integer() < Crypto::SignedBigInteger::from_base(10, y_string))
|
||||
|
||||
if (x_primitive.as_bigint().big_integer() < (*y_bigint)->big_integer())
|
||||
return TriState::True;
|
||||
else
|
||||
return TriState::False;
|
||||
return TriState::False;
|
||||
}
|
||||
|
||||
if (x_primitive.is_string() && y_primitive.is_bigint()) {
|
||||
auto& x_string = x_primitive.as_string().string();
|
||||
if (!is_valid_bigint_value(x_string))
|
||||
auto x_bigint = x_primitive.string_to_bigint(global_object);
|
||||
if (!x_bigint.has_value())
|
||||
return TriState::Unknown;
|
||||
if (Crypto::SignedBigInteger::from_base(10, x_string) < y_primitive.as_bigint().big_integer())
|
||||
|
||||
if ((*x_bigint)->big_integer() < y_primitive.as_bigint().big_integer())
|
||||
return TriState::True;
|
||||
else
|
||||
return TriState::False;
|
||||
return TriState::False;
|
||||
}
|
||||
|
||||
auto x_numeric = TRY(x_primitive.to_numeric(global_object));
|
||||
|
@ -129,6 +129,70 @@ describe("correct behavior", () => {
|
||||
expect(a === a).toBeTrue();
|
||||
expect(a === b).toBeFalse();
|
||||
});
|
||||
|
||||
test("less-than operators", () => {
|
||||
expect(1n < 1n).toBeFalse();
|
||||
expect(1n < 1).toBeFalse();
|
||||
expect(1 < 1n).toBeFalse();
|
||||
expect(1n < 2n).toBeTrue();
|
||||
expect(1n < 2).toBeTrue();
|
||||
expect(1 < 2n).toBeTrue();
|
||||
expect(1n < 1.23).toBeTrue();
|
||||
expect(1.23 < 1n).toBeFalse();
|
||||
|
||||
expect(1n <= 1n).toBeTrue();
|
||||
expect(1n <= 1).toBeTrue();
|
||||
expect(1 <= 1n).toBeTrue();
|
||||
expect(1n <= 2n).toBeTrue();
|
||||
expect(1n <= 2).toBeTrue();
|
||||
expect(1 <= 2n).toBeTrue();
|
||||
expect(1n <= 1.23).toBeTrue();
|
||||
expect(1.23 <= 1n).toBeFalse();
|
||||
|
||||
expect(1n < "1").toBeFalse();
|
||||
expect(1n < "2").toBeTrue();
|
||||
expect(1n < "1.23").toBeFalse();
|
||||
|
||||
expect(1n <= "1").toBeTrue();
|
||||
expect(1n <= "2").toBeTrue();
|
||||
expect(1n <= "1.23").toBeFalse();
|
||||
|
||||
expect(1n < "0b1").toBeFalse();
|
||||
expect(1n < "0B10").toBeTrue();
|
||||
expect(1n < "0o1").toBeFalse();
|
||||
expect(1n < "0O2").toBeTrue();
|
||||
expect(1n < "0x1").toBeFalse();
|
||||
expect(1n < "0X2").toBeTrue();
|
||||
|
||||
expect(1n <= "0b1").toBeTrue();
|
||||
expect(1n <= "0B10").toBeTrue();
|
||||
expect(1n <= "0o1").toBeTrue();
|
||||
expect(1n <= "0O2").toBeTrue();
|
||||
expect(1n <= "0x1").toBeTrue();
|
||||
expect(1n <= "0X2").toBeTrue();
|
||||
|
||||
expect("1" < 1n).toBeFalse();
|
||||
expect("1" < 2n).toBeTrue();
|
||||
expect("1.23" < 1n).toBeFalse();
|
||||
|
||||
expect("1" <= 1n).toBeTrue();
|
||||
expect("1" <= 2n).toBeTrue();
|
||||
expect("1.23" <= 1n).toBeFalse();
|
||||
|
||||
expect("0b1" < 1n).toBeFalse();
|
||||
expect("0B1" < 2n).toBeTrue();
|
||||
expect("0o1" < 1n).toBeFalse();
|
||||
expect("0O1" < 2n).toBeTrue();
|
||||
expect("0x1" < 1n).toBeFalse();
|
||||
expect("0X1" < 2n).toBeTrue();
|
||||
|
||||
expect("0b1" <= 1n).toBeTrue();
|
||||
expect("0B10" <= 2n).toBeTrue();
|
||||
expect("0o1" <= 1n).toBeTrue();
|
||||
expect("0O2" <= 2n).toBeTrue();
|
||||
expect("0x1" <= 1n).toBeTrue();
|
||||
expect("0X2" <= 2n).toBeTrue();
|
||||
});
|
||||
});
|
||||
|
||||
describe("errors", () => {
|
||||
|
Loading…
Reference in New Issue
Block a user