From 03df8882dff0ac79e126b90bf450d02924421521 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 23 May 2021 09:22:16 +0200 Subject: [PATCH] InspectorServer: Remove unnecessary greet() message --- Userland/DevTools/Inspector/InspectorServerClient.h | 1 - Userland/Services/InspectorServer/ClientConnection.cpp | 4 ---- Userland/Services/InspectorServer/ClientConnection.h | 1 - Userland/Services/InspectorServer/InspectorServer.ipc | 3 --- 4 files changed, 9 deletions(-) diff --git a/Userland/DevTools/Inspector/InspectorServerClient.h b/Userland/DevTools/Inspector/InspectorServerClient.h index 477ad1cf69f..a63f174b16b 100644 --- a/Userland/DevTools/Inspector/InspectorServerClient.h +++ b/Userland/DevTools/Inspector/InspectorServerClient.h @@ -20,7 +20,6 @@ class InspectorServerClient final public: virtual void handshake() override { - greet(); } virtual ~InspectorServerClient() override = default; diff --git a/Userland/Services/InspectorServer/ClientConnection.cpp b/Userland/Services/InspectorServer/ClientConnection.cpp index b7bd2d08782..c03f4e3c6a8 100644 --- a/Userland/Services/InspectorServer/ClientConnection.cpp +++ b/Userland/Services/InspectorServer/ClientConnection.cpp @@ -27,10 +27,6 @@ void ClientConnection::die() s_connections.remove(client_id()); } -void ClientConnection::greet() -{ -} - Messages::InspectorServer::GetAllObjectsResponse ClientConnection::get_all_objects(pid_t pid) { auto process = InspectableProcess::from_pid(pid); diff --git a/Userland/Services/InspectorServer/ClientConnection.h b/Userland/Services/InspectorServer/ClientConnection.h index 812f7250811..f525f54f0ca 100644 --- a/Userland/Services/InspectorServer/ClientConnection.h +++ b/Userland/Services/InspectorServer/ClientConnection.h @@ -24,7 +24,6 @@ public: virtual void die() override; private: - virtual void greet() override; virtual Messages::InspectorServer::GetAllObjectsResponse get_all_objects(pid_t) override; virtual Messages::InspectorServer::SetInspectedObjectResponse set_inspected_object(pid_t, u64 object_id) override; virtual Messages::InspectorServer::SetObjectPropertyResponse set_object_property(pid_t, u64 object_id, String const& name, String const& value) override; diff --git a/Userland/Services/InspectorServer/InspectorServer.ipc b/Userland/Services/InspectorServer/InspectorServer.ipc index ed1696274d2..9d9d4c618fe 100644 --- a/Userland/Services/InspectorServer/InspectorServer.ipc +++ b/Userland/Services/InspectorServer/InspectorServer.ipc @@ -1,10 +1,7 @@ endpoint InspectorServer { - greet() => () - get_all_objects(i32 pid) => (String json) set_inspected_object(i32 pid, u64 object_id) => (bool success) set_object_property(i32 pid, u64 object_id, String name, String value) => (bool success) identify(i32 pid) => (String json) - }