Ladybird: Add app icon for macOS

Author: https://github.com/bplaat
Commit: https://github.com/SerenityOS/serenity/commit/059857d26f
Pull-request: https://github.com/SerenityOS/serenity/pull/20334

Ladybird/CMakeLists.txt

@@ -160,6 +160,8 @@ if (APPLE)
         COMMAND "${CMAKE_COMMAND}" -E copy_if_different "$<TARGET_FILE:WebDriver>" "${app_dir}"
         COMMAND "${CMAKE_COMMAND}" -E copy_if_different "$<TARGET_FILE:WebSocketServer>" "${app_dir}"
         COMMAND "${CMAKE_COMMAND}" -E copy_if_different "$<TARGET_FILE:headless-browser>" "${app_dir}"
+        COMMAND "mkdir" -p "${bundle_dir}/Contents/Resources"
+        COMMAND "iconutil" --convert icns "${CMAKE_CURRENT_SOURCE_DIR}/Icons/macos/app_icon.iconset" --output "${bundle_dir}/Contents/Resources/app_icon.icns"
     )
 endif()
 

Ladybird/Info.plist

@@ -5,7 +5,7 @@
         <key>NSPrincipalClass</key>
         <string>NSApplication</string>
         <key>CFBundleIconFile</key>
-        <string></string>
+        <string>app_icon.icns</string>
         <key>CFBundlePackageType</key>
         <string>APPL</string>
         <key>CFBundleGetInfoString</key>