LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 02:08:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibCompress: Check for impossible back references in DeflateDecompressor

Browse Source 
This commit makes sure that we fail if an encoded lz77 back reference
references bytes that are outside our sliding window, instead of just
silently failing, which triggers an assertion down the line.
This commit is contained in:
Idan Horowitz 2021-03-17 17:42:08 +02:00 committed by Andreas Kling
parent 9e6d0dd879
commit 071ee7c6f4
Notes: sideshowbarker 2024-07-18 21:16:22 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/071ee7c6f46
Pull-request: https://github.com/SerenityOS/serenity/pull/5847
Issue: https://github.com/SerenityOS/serenity/issues/5838
Issue: https://github.com/SerenityOS/serenity/issues/5839
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibCompress/Deflate.cpp
View File

@ -178,6 +178,10 @@ bool DeflateDecompressor::CompressedBlock::try_read_more()
for (size_t idx = 0; idx < length; ++idx) {
u8 byte = 0;
m_decompressor.m_output_stream.read({ &byte, sizeof(byte) }, distance);
if (m_decompressor.m_output_stream.handle_any_error()) {
m_decompressor.set_fatal_error();
return false; // a back reference was requested that was too far back (outside our current sliding window)
}
m_decompressor.m_output_stream << byte;
}