LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Return StringViews from CSS Token bracket-string getters

Browse Source 
These don't need to be full Strings, so let's be lightweight.
This commit is contained in:
Sam Atkins 2023-02-11 15:54:53 +00:00 committed by Linus Groh
parent 562594c416
commit 09f7682feb
Notes: sideshowbarker 2024-07-17 00:26:25 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/09f7682feb
Pull-request: https://github.com/SerenityOS/serenity/pull/17440
Reviewed-by: https://github.com/linusg
2 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Userland/Libraries/LibWeb/CSS/Parser/Token.cpp
View File

@ -1,6 +1,6 @@
/*
* Copyright (c) 2020-2021, the SerenityOS developers.
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -156,62 +156,62 @@ Token::Type Token::mirror_variant() const
return Type::Invalid;
}
DeprecatedString Token::bracket_string() const
StringView Token::bracket_string() const
{
if (is(Token::Type::OpenCurly)) {
return "{";
return "{"sv;
}
if (is(Token::Type::CloseCurly)) {
return "}";
return "}"sv;
}
if (is(Token::Type::OpenSquare)) {
return "[";
return "["sv;
}
if (is(Token::Type::CloseSquare)) {
return "]";
return "]"sv;
}
if (is(Token::Type::OpenParen)) {
return "(";
return "("sv;
}
if (is(Token::Type::CloseParen)) {
return ")";
return ")"sv;
}
return "";
return ""sv;
}
DeprecatedString Token::bracket_mirror_string() const
StringView Token::bracket_mirror_string() const
{
if (is(Token::Type::OpenCurly)) {
return "}";
return "}"sv;
}
if (is(Token::Type::CloseCurly)) {
return "{";
return "{"sv;
}
if (is(Token::Type::OpenSquare)) {
return "]";
return "]"sv;
}
if (is(Token::Type::CloseSquare)) {
return "[";
return "["sv;
}
if (is(Token::Type::OpenParen)) {
return ")";
return ")"sv;
}
if (is(Token::Type::CloseParen)) {
return "(";
return "("sv;
}
return "";
return ""sv;
}
}

6
Userland/Libraries/LibWeb/CSS/Parser/Token.h
View File

@ -1,6 +1,6 @@
/*
* Copyright (c) 2020-2021, the SerenityOS developers.
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021-2023, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -142,8 +142,8 @@ public:
}
Type mirror_variant() const;
DeprecatedString bracket_string() const;
DeprecatedString bracket_mirror_string() const;
StringView bracket_string() const;
StringView bracket_mirror_string() const;
DeprecatedString to_deprecated_string() const;
DeprecatedString to_debug_string() const;