mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-20 01:37:39 +03:00
Kernel: Mark Console::{hide,show}_cursor methods protected
Only the Console code in the Graphics directory should be able to call on these methods. The set_cursor method stays public as VirtualConsole uses that method to change the cursor position.
This commit is contained in:
parent
a40f289ee5
commit
0a5416a87a
Notes:
sideshowbarker
2024-07-17 06:46:41 +09:00
Author: https://github.com/supercomputer7 Commit: https://github.com/SerenityOS/serenity/commit/0a5416a87a Pull-request: https://github.com/SerenityOS/serenity/pull/15301
@ -50,8 +50,6 @@ public:
|
||||
virtual bool has_hardware_cursor() const = 0;
|
||||
|
||||
virtual void set_cursor(size_t x, size_t y) = 0;
|
||||
virtual void hide_cursor() = 0;
|
||||
virtual void show_cursor() = 0;
|
||||
|
||||
virtual void clear(size_t x, size_t y, size_t length) = 0;
|
||||
virtual void write(size_t x, size_t y, char ch, Color background, Color foreground, bool critical = false) = 0;
|
||||
@ -62,6 +60,9 @@ public:
|
||||
virtual ~Console() = default;
|
||||
|
||||
protected:
|
||||
virtual void hide_cursor() = 0;
|
||||
virtual void show_cursor() = 0;
|
||||
|
||||
Console(size_t width, size_t height)
|
||||
: m_width(width)
|
||||
, m_height(height)
|
||||
|
@ -24,8 +24,6 @@ public:
|
||||
virtual bool has_hardware_cursor() const override { return false; }
|
||||
|
||||
virtual void set_cursor(size_t x, size_t y) override;
|
||||
virtual void hide_cursor() override;
|
||||
virtual void show_cursor() override;
|
||||
|
||||
virtual void clear(size_t x, size_t y, size_t length) override;
|
||||
virtual void write(size_t x, size_t y, char ch, Color background, Color foreground, bool critical = false) override;
|
||||
@ -38,6 +36,9 @@ public:
|
||||
virtual void set_resolution(size_t width, size_t height, size_t pitch) = 0;
|
||||
|
||||
protected:
|
||||
virtual void hide_cursor() override;
|
||||
virtual void show_cursor() override;
|
||||
|
||||
GenericFramebufferConsoleImpl(size_t width, size_t height, size_t pitch)
|
||||
: Console(width, height)
|
||||
, m_pitch(pitch)
|
||||
|
@ -21,8 +21,6 @@ public:
|
||||
|
||||
virtual size_t bytes_per_base_glyph() const override { return 2; }
|
||||
virtual void set_cursor(size_t x, size_t y) override;
|
||||
virtual void hide_cursor() override;
|
||||
virtual void show_cursor() override;
|
||||
virtual void clear(size_t x, size_t y, size_t length) override;
|
||||
virtual void write(size_t x, size_t y, char ch, bool critical = false) override;
|
||||
virtual void write(size_t x, size_t y, char ch, Color background, Color foreground, bool critical = false) override;
|
||||
@ -33,6 +31,9 @@ public:
|
||||
virtual void disable() override { }
|
||||
|
||||
private:
|
||||
virtual void hide_cursor() override;
|
||||
virtual void show_cursor() override;
|
||||
|
||||
void clear_vga_row(u16 row);
|
||||
|
||||
explicit VGATextModeConsole(NonnullOwnPtr<Memory::Region>);
|
||||
|
Loading…
Reference in New Issue
Block a user