LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-07 20:31:04 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Skip page scrolling for wheel events consumed by scrollable box

Browse Source 
Leftover from 90879a07ba
This commit is contained in:
Aliaksandr Kalenik 2024-03-17 08:02:52 +01:00 committed by Andreas Kling
parent a386ebde02
commit 0afbd827e0
Notes: sideshowbarker 2024-07-17 02:29:45 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/0afbd827e0
Pull-request: https://github.com/SerenityOS/serenity/pull/23614
3 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/wheel-events-consumed-by-scrollable-should-not-be-propagated-to-body-2.txt Normal file
View File

@ -0,0 +1,2 @@
scrollable.scrollTop: 200
window.scrollY: 0

33
Tests/LibWeb/Text/input/wheel-events-consumed-by-scrollable-should-not-be-propagated-to-body-2.html Normal file
View File

@ -0,0 +1,33 @@
<!DOCTYPE html>
<style>
body {
height: 2000px;
margin: 0;
}
#box {
margin-top: 500px;
width: 100px;
height: 100px;
background-color: red;
}
#scrollable {
width: 400px;
height: 400px;
overflow: scroll;
border: 10px solid black;
}
</style>
<div id="scrollable">
<div id="box"></div>
</div>
<script src="include.js"></script>
<script>
test(() => {
internals.wheel(10, 10, 0, 1000);
const scrollable = document.getElementById("scrollable");
println("scrollable.scrollTop: " + scrollable.scrollTop);
println("window.scrollY: " + window.scrollY);
});
</script>

3
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View File

@ -180,7 +180,8 @@ bool EventHandler::handle_mousewheel(CSSPixelPoint position, CSSPixelPoint scree
containing_block = containing_block->containing_block();
}
paintable->handle_mousewheel({}, position, buttons, modifiers, wheel_delta_x, wheel_delta_y);
if (paintable->handle_mousewheel({}, position, buttons, modifiers, wheel_delta_x, wheel_delta_y))
return true;
auto node = dom_node_for_event_dispatch(*paintable);