LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-06 11:09:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Cache valid indices in IndexedPropertyIterator

Browse Source 
Refetching the list of indices every time we increment the iterator was
showing up hot & heavy in a profile of Discord.
This commit is contained in:
Andreas Kling 2022-02-05 17:59:14 +01:00
parent 483dce9750
commit 0d60cf211d
Notes: sideshowbarker 2024-07-17 19:45:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/0d60cf211dc
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/IndexedProperties.cpp
View File

@ -177,8 +177,10 @@ IndexedPropertyIterator::IndexedPropertyIterator(const IndexedProperties& indexe
, m_index(staring_index)
, m_skip_empty(skip_empty)
{
if (m_skip_empty)
if (m_skip_empty) {
m_cached_indices = m_indexed_properties.indices();
skip_empty_indices();
}
}
IndexedPropertyIterator& IndexedPropertyIterator::operator++()
@ -203,8 +205,7 @@ bool IndexedPropertyIterator::operator!=(const IndexedPropertyIterator& other) c
void IndexedPropertyIterator::skip_empty_indices()
{
auto indices = m_indexed_properties.indices();
for (auto i : indices) {
for (auto i : m_cached_indices) {
if (i < m_index)
continue;
m_index = i;

1
Userland/Libraries/LibJS/Runtime/IndexedProperties.h
View File

@ -106,6 +106,7 @@ private:
void skip_empty_indices();
const IndexedProperties& m_indexed_properties;
Vector<u32> m_cached_indices;
u32 m_index;
bool m_skip_empty;
};