LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI+SoundPlayer: Use 'increase_slider_by_page_steps()'

Browse Source 
This method allow us to avoid repeating the pattern
'set_value(value() + page_step() * page_number)'.
This commit is contained in:
Elyse 2021-10-31 12:37:17 -06:00 committed by Andreas Kling
parent 8d1fb299b1
commit 0d660b27ae
Notes: sideshowbarker 2024-07-17 21:55:11 +09:00 
Author: https://github.com/elyse0
Commit: https://github.com/SerenityOS/serenity/commit/0d660b27ae4
Pull-request: https://github.com/SerenityOS/serenity/pull/11163
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
Reviewed-by: https://github.com/metmo ✅
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp
View File

@ -149,7 +149,7 @@ void SoundPlayerWidgetAdvancedView::keydown_event(GUI::KeyEvent& event)
m_stop_button->click();
if (event.key() == Key_Up)
m_volume_slider->set_value(m_volume_slider->value() + m_volume_slider->page_step());
m_volume_slider->increase_slider_by_page_steps(1);
if (event.key() == Key_Down)
m_volume_slider->set_value(m_volume_slider->value() - m_volume_slider->page_step());

2
Userland/Libraries/LibGUI/Slider.cpp
View File

@ -104,7 +104,7 @@ void Slider::mousedown_event(MouseEvent& event)
auto knob_first_edge = knob_rect().first_edge_for_orientation(orientation());
auto knob_last_edge = knob_rect().last_edge_for_orientation(orientation());
if (mouse_offset > knob_last_edge)
set_value(value() + page_step());
increase_slider_by_page_steps(1);
else if (mouse_offset < knob_first_edge)
set_value(value() - page_step());
}