LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Stop sending "load" event twice to iframes

Browse Source 
The "completely finish loading" algorithm (from the HTML spec) is
responsible for sending a "load" event to nested browsing context
containers (iframes).

This patch removes the old mechanism for sending "load" events, which we
had mistakenly kept around, causing two events to be sent instead of
one. :^)
This commit is contained in:
Andreas Kling 2021-12-04 14:47:24 +01:00
parent 58309444d7
commit 108de5dea0
Notes: sideshowbarker 2024-07-17 23:11:36 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/108de5dea03
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/BrowsingContextContainer.cpp
View File

@ -56,9 +56,4 @@ const DOM::Document* BrowsingContextContainer::content_document() const
return m_nested_browsing_context ? m_nested_browsing_context->active_document() : nullptr;
}
void BrowsingContextContainer::nested_browsing_context_did_load(Badge<FrameLoader>)
{
dispatch_event(DOM::Event::create(EventNames::load));
}
}

2
Userland/Libraries/LibWeb/HTML/BrowsingContextContainer.h
View File

@ -23,8 +23,6 @@ public:
Origin content_origin() const;
bool may_access_from_origin(const Origin&) const;
void nested_browsing_context_did_load(Badge<FrameLoader>);
virtual void inserted() override;
protected:

3
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View File

@ -309,9 +309,6 @@ void FrameLoader::resource_did_load()
else
browsing_context().set_viewport_scroll_offset({ 0, 0 });
if (auto* container = browsing_context().container())
container->nested_browsing_context_did_load({});
if (auto* page = browsing_context().page())
page->client().page_did_finish_loading(url);
}