LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-31 23:22:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement the HTMLMediaElement "potentially playing" concept

Browse Source
This commit is contained in:
Timothy Flynn 2023-04-20 07:20:42 -04:00 committed by Andreas Kling
parent 9f71799456
commit 12c15641c1
Notes: sideshowbarker 2024-07-17 03:27:40 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/12c15641c1
Pull-request: https://github.com/SerenityOS/serenity/pull/18438
Reviewed-by: https://github.com/Zaggy1024 ✅
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@ -1211,6 +1211,35 @@ void HTMLMediaElement::set_paused(bool paused)
on_paused();
}
// https://html.spec.whatwg.org/multipage/media.html#blocked-media-element
bool HTMLMediaElement::blocked() const
{
// A media element is a blocked media element if its readyState attribute is in the HAVE_NOTHING state, the HAVE_METADATA
// state, or the HAVE_CURRENT_DATA state, or if the element has paused for user interaction or paused for in-band content.
switch (m_ready_state) {
case ReadyState::HaveNothing:
case ReadyState::HaveMetadata:
case ReadyState::HaveCurrentData:
return true;
default:
break;
}
// FIXME: Implement "paused for user interaction" (namely "the user agent has reached a point in the media resource
// where the user has to make a selection for the resource to continue").
// FIXME: Implement "paused for in-band content".
return false;
}
// https://html.spec.whatwg.org/multipage/media.html#potentially-playing
bool HTMLMediaElement::potentially_playing() const
{
// A media element is said to be potentially playing when its paused attribute is false, the element has not ended
// playback, playback has not stopped due to errors, and the element is not a blocked media element.
// FIXME: Implement "stopped due to errors".
return !paused() && !ended() && !blocked();
}
// https://html.spec.whatwg.org/multipage/media.html#eligible-for-autoplay
bool HTMLMediaElement::is_eligible_for_autoplay() const
{

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h
View File

@ -70,6 +70,7 @@ public:
double duration() const;
bool paused() const { return m_paused; }
bool ended() const;
bool potentially_playing() const;
WebIDL::ExceptionOr<JS::NonnullGCPtr<JS::Promise>> play();
WebIDL::ExceptionOr<void> pause();
@ -115,6 +116,7 @@ private:
void set_paused(bool);
void set_duration(double);
bool blocked() const;
bool is_eligible_for_autoplay() const;
bool has_ended_playback() const;
WebIDL::ExceptionOr<void> reached_end_of_media_playback();