From 12c15641c1986788c717d37923b8046df8ba430e Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 20 Apr 2023 07:20:42 -0400 Subject: [PATCH] LibWeb: Implement the HTMLMediaElement "potentially playing" concept --- .../LibWeb/HTML/HTMLMediaElement.cpp | 29 +++++++++++++++++++ .../Libraries/LibWeb/HTML/HTMLMediaElement.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp index 73eed82b279..9fec1596ba9 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp +++ b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp @@ -1211,6 +1211,35 @@ void HTMLMediaElement::set_paused(bool paused) on_paused(); } +// https://html.spec.whatwg.org/multipage/media.html#blocked-media-element +bool HTMLMediaElement::blocked() const +{ + // A media element is a blocked media element if its readyState attribute is in the HAVE_NOTHING state, the HAVE_METADATA + // state, or the HAVE_CURRENT_DATA state, or if the element has paused for user interaction or paused for in-band content. + switch (m_ready_state) { + case ReadyState::HaveNothing: + case ReadyState::HaveMetadata: + case ReadyState::HaveCurrentData: + return true; + default: + break; + } + + // FIXME: Implement "paused for user interaction" (namely "the user agent has reached a point in the media resource + // where the user has to make a selection for the resource to continue"). + // FIXME: Implement "paused for in-band content". + return false; +} + +// https://html.spec.whatwg.org/multipage/media.html#potentially-playing +bool HTMLMediaElement::potentially_playing() const +{ + // A media element is said to be potentially playing when its paused attribute is false, the element has not ended + // playback, playback has not stopped due to errors, and the element is not a blocked media element. + // FIXME: Implement "stopped due to errors". + return !paused() && !ended() && !blocked(); +} + // https://html.spec.whatwg.org/multipage/media.html#eligible-for-autoplay bool HTMLMediaElement::is_eligible_for_autoplay() const { diff --git a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h index c5af05622c7..307402b13b3 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h +++ b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h @@ -70,6 +70,7 @@ public: double duration() const; bool paused() const { return m_paused; } bool ended() const; + bool potentially_playing() const; WebIDL::ExceptionOr> play(); WebIDL::ExceptionOr pause(); @@ -115,6 +116,7 @@ private: void set_paused(bool); void set_duration(double); + bool blocked() const; bool is_eligible_for_autoplay() const; bool has_ended_playback() const; WebIDL::ExceptionOr reached_end_of_media_playback();