LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make sure private identifier is valid in optional chain

Browse Source 
If we don't check that a private identifier is valid this can break the
assumption that we have a private environment when evaluation the
private identifier. Also an unknown private identifier this should
be a SyntaxError.
This commit is contained in:
davidot 2022-11-17 10:24:20 +01:00 committed by Linus Groh
parent 49fc0e2514
commit 16ac43c9d4
Notes: sideshowbarker 2024-07-17 04:24:22 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/16ac43c9d4
Pull-request: https://github.com/SerenityOS/serenity/pull/16094
Reviewed-by: https://github.com/linusg
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibJS/Parser.cpp
View File

@ -3174,6 +3174,9 @@ NonnullRefPtr<OptionalChain> Parser::parse_optional_chain(NonnullRefPtr<Expressi
} else if (match(TokenType::Period)) {
consume();
if (match(TokenType::PrivateIdentifier)) {
if (!is_private_identifier_valid())
syntax_error(String::formatted("Reference to undeclared private field or method '{}'", m_state.current_token.value()));
auto start = position();
auto private_identifier = consume();
chain.append(OptionalChain::PrivateMemberReference {

35
Userland/Libraries/LibJS/Tests/classes/class-private-fields.js
View File

@ -148,3 +148,38 @@ test("using 'arguments' via indirect eval throws at runtime instead of parse tim
}
}).toThrowWithMessage(ReferenceError, "'arguments' is not defined");
});
test("unknown private name gives SyntaxError", () => {
expect(`#n`).not.toEval();
expect(`obj.#n`).not.toEval();
expect(`this.#n`).not.toEval();
expect(`if (#n) 1;`).not.toEval();
expect(`1?.#n`).not.toEval();
expect(`1?.n.#n`).not.toEval();
});
// OSS-FUZZ Issue 53363: top level unknown private names seg faults
expect(() => eval(`#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`obj.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`this.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`if (#n) 1;`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`1?.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);
expect(() => eval(`1?.n.#n`)).toThrowWithMessage(
SyntaxError,
"Reference to undeclared private field or method '#n'"
);