LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 02:08:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Enforce proper const-propogation with {Nonnull,}GCPtr

Browse Source
This commit is contained in:
Matthew Olsson 2023-02-25 10:46:54 -07:00 committed by Linus Groh
parent c0b2fa74ac
commit 176beeb08e
Notes: sideshowbarker 2024-07-17 05:21:12 +09:00 
Author: https://github.com/mattco98
Commit: https://github.com/SerenityOS/serenity/commit/176beeb08e
Pull-request: https://github.com/SerenityOS/serenity/pull/17620
Issue: https://github.com/SerenityOS/serenity/issues/16988
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/linusg
1 changed files with 36 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
Userland/Libraries/LibJS/Heap/GCPtr.h
View File

@ -23,12 +23,6 @@ public:
{
}
NonnullGCPtr(T const& ptr)
requires(!IsConst<T>)
: m_ptr(&const_cast<T&>(ptr))
{
}
template<typename U>
NonnullGCPtr(U& ptr)
requires(IsConvertible<U*, T*>)
@ -36,31 +30,21 @@ public:
{
}
template<typename U>
NonnullGCPtr(U const& ptr)
requires(IsConvertible<U*, T*> && !IsConst<T>)
: m_ptr(&const_cast<T&>(static_cast<T const&>(ptr)))
NonnullGCPtr(NonnullGCPtr const& other)
: m_ptr(other.ptr())
{
}
template<typename U>
NonnullGCPtr(NonnullGCPtr<U> ptr)
NonnullGCPtr(NonnullGCPtr<U> const& other)
requires(IsConvertible<U*, T*>)
: m_ptr(ptr)
: m_ptr(other.ptr())
{
}
NonnullGCPtr& operator=(T const& other)
NonnullGCPtr& operator=(NonnullGCPtr const& other)
{
m_ptr = &const_cast<T&>(other);
return *this;
}
template<typename U>
NonnullGCPtr& operator=(U const& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = &const_cast<T&>(static_cast<T const&>(other));
m_ptr = other.ptr();
return *this;
}
@ -68,7 +52,21 @@ public:
NonnullGCPtr& operator=(NonnullGCPtr<U> const& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = const_cast<T*>(static_cast<T const*>(other.ptr()));
m_ptr = static_cast<T*>(other.ptr());
return *this;
}
NonnullGCPtr& operator=(T& other)
{
m_ptr = &other;
return *this;
}
template<typename U>
NonnullGCPtr& operator=(U& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = &static_cast<T&>(other);
return *this;
}
@ -96,32 +94,20 @@ public:
{
}
GCPtr(T const& ptr)
requires(!IsConst<T>)
: m_ptr(&const_cast<T&>(ptr))
{
}
GCPtr(T* ptr)
: m_ptr(ptr)
{
}
GCPtr(T const* ptr)
requires(!IsConst<T>)
: m_ptr(const_cast<T*>(ptr))
{
}
GCPtr(NonnullGCPtr<T> ptr)
: m_ptr(ptr)
GCPtr(NonnullGCPtr<T> const& other)
: m_ptr(other.ptr())
{
}
template<typename U>
GCPtr(NonnullGCPtr<U> ptr)
GCPtr(NonnullGCPtr<U> const& other)
requires(IsConvertible<U*, T*>)
: m_ptr(ptr)
: m_ptr(other.ptr())
{
}
@ -137,13 +123,13 @@ public:
GCPtr& operator=(GCPtr<U> const& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = const_cast<T*>(static_cast<T const*>(other.ptr()));
m_ptr = static_cast<T*>(other.ptr());
return *this;
}
GCPtr& operator=(NonnullGCPtr<T> const& other)
{
m_ptr = const_cast<T*>(other.ptr());
m_ptr = other.ptr();
return *this;
}
@ -151,35 +137,35 @@ public:
GCPtr& operator=(NonnullGCPtr<U> const& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = const_cast<T*>(static_cast<T const*>(other.ptr()));
m_ptr = static_cast<T*>(other.ptr());
return *this;
}
GCPtr& operator=(T const& other)
GCPtr& operator=(T& other)
{
m_ptr = &const_cast<T&>(other);
m_ptr = &other;
return *this;
}
template<typename U>
GCPtr& operator=(U const& other)
GCPtr& operator=(U& other)
requires(IsConvertible<U*, T*>)
{
m_ptr = &const_cast<T&>(static_cast<T const&>(other));
m_ptr = &static_cast<T&>(other);
return *this;
}
GCPtr& operator=(T const* other)
GCPtr& operator=(T* other)
{
m_ptr = const_cast<T*>(other);
m_ptr = other;
return *this;
}
template<typename U>
GCPtr& operator=(U const* other)
GCPtr& operator=(U* other)
requires(IsConvertible<U*, T*>)
{
m_ptr = const_cast<T*>(static_cast<T const*>(other));
m_ptr = static_cast<T*>(other);
return *this;
}