LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 17:27:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't crash when visiting about:srcdoc

Browse Source 
When navigating to about:srcdoc we try to populate the session history
by calling populate_session_history_entry_document, if the resource is
an about:srcdoc this method will rely on the document_resource in the
SessionHistoryEntry to have a String in order for it call the right
method to create navigation params.

However when navigating to about:srcdoc directly, document_resource
will have an Empty, this leads populate_session_history_entry_document
to call the wrong method to create navigation params.

This fixes the issue by populating document_resource with an empty
string if it has an Empty and we're dealing with an about:srcdoc.

Issue: #23216
This commit is contained in:
mobounya 2024-03-08 22:17:36 +01:00 committed by Andrew Kaster
parent 9aefc5c927
commit 190a8f948e
Notes: sideshowbarker 2024-07-17 11:29:41 +09:00 
Author: https://github.com/mobounya
Commit: https://github.com/SerenityOS/serenity/commit/190a8f948e
Pull-request: https://github.com/SerenityOS/serenity/pull/23531
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View File

@ -1388,8 +1388,12 @@ WebIDL::ExceptionOr<void> Navigable::navigate(NavigateParams params)
document_state->set_navigable_target_name(target_name());
// 5. If url matches about:blank or is about:srcdoc, then set documentState's origin to documentState's initiator origin.
// FIXME: should this say "matches about:srcdoc"
if (url_matches_about_blank(url) || url == "about:srcdoc"sv) {
if (url_matches_about_blank(url) || url_matches_about_srcdoc(url)) {
// document_resource cannot have an Empty if the url is about:srcdoc since we rely on document_resource
// having a String to call create_navigation_params_from_a_srcdoc_resource
if (url_matches_about_srcdoc(url) && document_resource.has<Empty>()) {
document_state->set_resource({ String {} });
}
// 1. Set documentState's origin to initiatorOriginSnapshot.
document_state->set_origin(document_state->initiator_origin());